Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-organize plotting/balmer code #10

Closed
4 tasks done
astrochun opened this issue Jan 31, 2020 · 0 comments · Fixed by #53
Closed
4 tasks done

Re-organize plotting/balmer code #10

astrochun opened this issue Jan 31, 2020 · 0 comments · Fixed by #53
Assignees
@astrochun
Labels
organization Simplify with imports, remove extraneous stuff

Comments

@astrochun
Copy link
Owner

astrochun commented Jan 31, 2020 •
edited
Loading

Changes include:

  • Fixes to variable names (combine_asc, Bneg0)
  • PEP8 compatibility
  • missing imports (e.g., numpy)
  • Missing variables (dx, wave_beta, wave_gamma, wave_delta)
  • Add docstrings to document each function [c87ecce, 362bb4d]

Since this feature was created, MSC has significantly evolved. It needs to be updated to:

  1. Use file name handling from column_names [5021fb7, 4dee557]
  2. Include EBV and Balmer decrement info in plots [2165c50, 7ed3945]
  3. Use stack naming approach to identify files and retrieve composite spectra. In addition, this should also identify bin_emission_line_fit table. [5021fb7]
  4. Will need to also update attenuation. It needs to use line_name_short to get names (cd02279) and column_names for filenames (bc80a0b)

Changes are part of feature/plotting_balmer and part of release/1.1.0
@astrochun astrochun added the organization Simplify with imports, remove extraneous stuff label Jan 31, 2020
@astrochun astrochun self-assigned this Jan 31, 2020
astrochun added a commit that referenced this issue Jan 31, 2020
@astrochun
plotting.balmer: Fix variable name (bug): combine_ascii -> astropy ta…
ac9ae4a 
…ble (iss #10)
astrochun added a commit that referenced this issue Jan 31, 2020
@astrochun
plotting.balmer.extract_fit: Strip astropy column to get numpy array …
4b51da9 
…(iss #10)
astrochun added a commit that referenced this issue Jan 31, 2020
@astrochun
plotting.balmer: Import numpy (iss #10)
f4625a8
astrochun added a commit that referenced this issue Jan 31, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Define wave_beta, wave_gamma, wave_delta…
2b2d444 
… (iss #10)
astrochun added a commit that referenced this issue Jan 31, 2020
@astrochun
plotting.balmer.extract_fit: PEP8 and update docstrings (iss #10)
761e7b7
astrochun added a commit that referenced this issue Feb 1, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Remove unused variables (iss #10)
46802b5
astrochun added a commit that referenced this issue Feb 1, 2020
@astrochun
plotting.balmer.HbHgHd_fits: rename variables for readability (iss #10)
e242d07
astrochun added a commit that referenced this issue Feb 1, 2020
@astrochun
plotting.balmer: Fix extra spaces, missing spaces, etc (iss #10)
62a3d4a
@astrochun astrochun mentioned this issue Feb 12, 2020
Merged
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.extract_fit: Use column_names definition #25 (iss #10)
c9e7dca
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Fix line name, Hgamma -> HGAMMA (iss #10)
9f895f3
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.HbHgHd_fits: PEP compatibility (iss #10)
cf0fa2b
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Remove dispersion definition -unused (iss …
8f2440d 
…#10)
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.fitting_result: Fix incorrect name (iss #10)
10f03ce
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.fitting_result: Switch to double-quote docstrings (iss …
028697d 
…#10)
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer: Rename of arrays, PEP8 rules (iss #10)
5f87da0
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.fitting_result: Fix bug - define dx (iss #10)
faa9c65
astrochun added a commit that referenced this issue Mar 1, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Ignore unbound issue with definition wit…
8a769b3 
…hin if statement (iss #10)
astrochun added a commit that referenced this issue Mar 5, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Remove dx definition - not used (iss #10)
43577ac
astrochun added a commit that referenced this issue May 22, 2020
@astrochun
plotting.balmer.extract_fit.fitting_result: Update docstrings (iss #10)
c87ecce
astrochun added a commit that referenced this issue May 22, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Change pdf_pages variable name for PEP8 …
2568966 
…(iss #10)
astrochun added a commit that referenced this issue May 22, 2020
@astrochun
plotting.balmer.HbHgHd_fits: Update docstrings (iss #10)
362bb4d
astrochun added a commit that referenced this issue May 25, 2020
@astrochun
attenuation: Update docstrings and PEP8 formatting (iss #10)
ab0d355
astrochun added a commit that referenced this issue May 29, 2020
@astrochun
attenuation.compute_EBV: Use os.path.join (iss #10)
199acb8
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Use dust0 from column_names (iss #10)
06bbc9d
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Use correct name for ID columns (iss …
2daa8ab 
…#10)
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Add Balmer decrement line ratios an…
9fb7a2f 
…d use Columns to later incorporate in tables (iss #10)
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation: Fix typo (iss #10)
2035ac2
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Update derived properties table wit…
0ad4b65 
…h dust attenuation (iss #10)
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Allow for use_revised keyword optio…
3f13ccb 
…ns to specify different inputs (iss #10)
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation: Fix typo (iss #10)
7234f67
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Check for derived properties file b…
2191654 
…efore adding dust attenuation information (iss #10)
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Fix a few typos (iss #10)
7a39db4
astrochun added a commit that referenced this issue Jun 3, 2020
@astrochun
analysis.attenuation.compute_EBV: Fix a typo in Column name (iss #10)
0cf7167
astrochun added a commit that referenced this issue Jun 4, 2020
@astrochun
valid_table.compare_to_by_eye: Check if file exists (iss #10)
ea4f63b
astrochun added a commit that referenced this issue Jun 4, 2020
@astrochun
valid_table.compare_to_by_eye: Raise error; Strip out manual coding (…
f12fd68 
…iss #10)
astrochun added a commit that referenced this issue Jun 5, 2020
@astrochun
plotting.balmer.extract_fit: Fix memory caching for single entries fr…
d9238d5 
…om astropy tables (iss #10)
astrochun added a commit that referenced this issue Jun 5, 2020
@astrochun
balmer.HbHgHd_fits: Plot aesthetics, include Balmer decrements in ann…
2165c50 
…otation (iss #10)
astrochun added a commit that referenced this issue Jun 5, 2020
@astrochun
balmer.HbHgHd_fits: Plot aesthetics for white space (iss #10)
9d9097f
astrochun added a commit that referenced this issue Jun 5, 2020
@astrochun
balmer.HbHgHd_fits: Compute EBV and annotate plots (iss #10)
7ed3945
astrochun added a commit that referenced this issue Jun 5, 2020
@astrochun
balmer.HbHgHd_fits: Add fitspath input, fix out_pdf prefix, use colum…
5021fb7 
…n_names for filename convention (iss #10)
astrochun added a commit that referenced this issue Jun 7, 2020
@astrochun
balmer.HbHgHd_fits: Use comp_spec filename_dict definition (iss #10)
4dee557
astrochun added a commit that referenced this issue Jun 8, 2020
@astrochun
balmer.HbHgHd_fits: Bug fix in annotation input (iss #10)
147bddf
astrochun added a commit that referenced this issue Jun 10, 2020
@astrochun
balmer.HbHgHd_fits: Label axes (iss #10)
57605f1
astrochun added a commit that referenced this issue Jun 10, 2020
@astrochun
balmer.HbHgHd_fits: Fix file path to provide absolute one (iss #10)
ce66e50
astrochun added a commit that referenced this issue Jun 10, 2020
@astrochun
balmer.HbHgHd_fits: Plot aesthetics for less white space, tick labels…
2e20212 
… (iss #10)
astrochun added a commit that referenced this issue Jun 10, 2020
@astrochun
balmer.HbHgHd_fits: Force ticks on the inside (iss #10)
29d30df
astrochun added a commit that referenced this issue Jun 10, 2020
@astrochun
balmer.HbHgHd_fits: smaller wspace for subplots_adjust (iss #10)
0d11b1b
astrochun added a commit that referenced this issue Jun 14, 2020
@astrochun
error_prop.fluxes_derived_prop: Additional documentation (iss #10; #5)
59ab051
astrochun added a commit that referenced this issue Jun 14, 2020
@astrochun
column_names: Minor fix in order for dust0 definition (iss #10)
fd066ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@astrochun astrochun

Labels
organization Simplify with imports, remove extraneous stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release/1.1.0 astrochun/Metallicity_Stack_Commons
1 participant
@astrochun