roachtest: some more logging for costfuzz and unoptimized query oracle #102038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
added
the
backport-23.1.x
yuzefovich
requested review from
smg260 and
renatolabs
and removed request for
a team
|
This change is |
DrewKimball
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @renatolabs and @smg260)
This commit modifies the costfuzz and unoptimized query oracle tests to always log each "main" statement. The stmt is commented out so that the log is still replayable. Additionally, a timestamp is included to help with debugging later. Epic: None Release note: None
|
TFTR! bors r+ |
|
Build succeeded: |
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
Jan 25, 2024
…ts logs In cockroachdb#102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in cockroachdb#118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in cockroachdb#118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Release note: None
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
Jan 27, 2024
…ts logs In cockroachdb#102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in cockroachdb#118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in cockroachdb#118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
118312: roachtest: remove interesting whitespace characters in random SQL test logs r=mgartner a=mgartner In #102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in #118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in #118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Epic: None Release note: None 118368: roachprod: fix default backup schedule creation on start r=herkolategan a=renatolabs For a while now, `roachprod` has created a default backup schedule on cluster creation when `--schedule-backups` is passed. This is also the default in clusters created to run roachtests. When we fixed an issue with starting external-process tenants in 3715eb5, however, we unadvertently changed the order of two operations performed by roachprod on cluster start: setting the default cluster settings, and creating the default backup schedule. As a consequence, the command used to create the backup schedule fails because, at that point, we haven't configured a license key yet. To make matters worse, there was a bug in the error handling of `createFixedBackupSchedule` that prevented errors from being reported to the user; these errors were being swallowed and went unnoticed for a few months. In this commit, we fix the error checking in that function, and also officially remove code that partially supported creating backups or admin users in tenants. Currently, roachprod will run that part of the setup for the system tenant. In the future, we might revisit this and also create a backup schedule and admin users for application tenants. Epic: none Release note: None 118476: changefeedccl: use correct channel size in parallelio r=jayshrivastava a=jayshrivastava Previously, the channels used for sending requests and receiving results were too small. This meant that a caller could block on sending a request even after acquiring quota. This change ensures that the size of the channels is large enough so that this blocking does not occur. Closes: #118463 Closes: #118462 Closes: #118461 Closes: #118460 Closes: #118459 Closes: #118458 Epic: none 118482: kvserver: increase shutdown propagation time in range merge test r=andrewbaptist a=kvoli `TestStoreRangeMergeDuringShutDown` could occasionally flake when the shutdown hadn't propagated before applying the lease. Increase the post-shutdown sleep from 10ms to 20ms. Fixes: #118348 Release note: None 118483: roachpb: increase test make priority trials r=andrewbaptist a=kvoli `TestMakePriority` could (very) rarely flake due to slight differences in the sampled vs underlying distribution. Increase the trial runs by 33% from 750k to 1000k to reduce the likelihood of this occurring. Fixes: #118399 Release note: None 118498: gcjob_test: deflake TestSchemaChangeGCJob r=rafiss a=rafiss This updates a test assertion so that if the GC TTL already began, the test does not fail. fixes #117485 fixes #118467 Release note: None Co-authored-by: Marcus Gartner <[email protected]> Co-authored-by: Renato Costa <[email protected]> Co-authored-by: Jayant Shrivastava <[email protected]> Co-authored-by: Austen McClernon <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
…ts logs In #102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in #118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in #118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Release note: None
blathers-crl bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
…ts logs In #102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in #118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in #118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Release note: None
mgartner
added a commit
that referenced
this pull request
Jan 31, 2024
…ts logs In #102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in #118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in #118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Release note: None
mgartner
added a commit
that referenced
this pull request
Jan 31, 2024
…ts logs In #102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in #118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in #118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Release note: None
wenyihu6
pushed a commit
to wenyihu6/cockroach
that referenced
this pull request
Feb 21, 2024
…ts logs In cockroachdb#102038 we started writing statements to the query log in SQL comments. The change removes newline characters in the statement to ensure that the statement will be on one line all within the comment. However, we still see test logs where the comments are broken onto multiple lines, as in cockroachdb#118273, which makes the file invalid syntactically. This makes reproducing the test failure more difficult because the comments have to be manually fixed so that the log file can be successfully parsed. I was able to determine that the line breaks are coming from other "interesting" whitespace characters. The `xxd` output from the log file in cockroachdb#118273 shows the carriage return character, `0d` being used in the middle of a column name: 00000090: 2041 5320 2263 6f0d 6c33 3830 2246 524f AS "co.l380"FRO This commit strips all interesting whitespace characters from the statement to prevent the comment from being broken on multiple lines. Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the costfuzz and unoptimized query oracle tests to always log each "main" statement. The stmt is commented out so that the log is still replayable. Additionally, a timestamp is included to help with debugging later.
Informs: #101823.
Epic: None
Release note: None