-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Vailland / Gree AC #1587
Comments
Hey Christian, Please have a read of https://github.com/crankyoldgit/IRremoteESP8266/wiki/Adding-support-for-a-new-AC-protocol You'll need to work out what bits & bytes correspond to the (new) features you want supported, and how they work. Lines 36 to 77 in 21e7dd4
Once you've got that analysis done, we'll write the code if you can't. In the meantime, I'll update the supported model info you've provided. Thanks! |
You should probably start with capturing the existing and original remote to collect the data for your ACs structure, it will also tell you which protocol, if any that is already supporting. "Testing" which protocol it "responds to" is unreliable at best. |
Thanks for your reply. I will give it a try and come back when I encounter problems. |
Oh so very true. I forgot to say/recommend that. There are a number of A/Cs that respond to multiple different protocols, but the remote's one is different. |
@chkr1011 How are you going with this? |
I prepared my hardware (ESP32) and now started reverse engineering. I also have a list what is working so far and now I am playing around with the raw state (changing bits etc.). I also built a receiver for my remote and capturing the raw state. Current state is: I can basically use the Gree code but things like the "ModelA" are used for the Ion filter instead. I wonder if I should modify the Gree code or better copy it as a new "IRVaillant_AC" class. What do you recomment? Please do not expect a final result within the next 2-3 weeks. I will let you know when I have more results. |
That depends on the data and how different it is. In short, it depends. |
OK then I will create a pull request which uses a modified Gree class copy as "IRVAillant_AC. Then you can decide how it fits best. |
Looking forward to it |
Friendly ping. How did you go with this? |
I already found some new bits which I use already. I had some hard times trying to decode the signal from the remote. I tried the code from the samples but unfortunately the receiver gets a lot of noise. So I often have to guess. Do you have a recommendation for me? Should I change tolerance etc.? I also tried a pull-up resistor and capacitor but no success. Here is a snipped from my C# code. There you can see the new field like "Energy Saver" and "Horizontal Swing". I still need to find more bits. The ! sign means that the purpose of the bit is verified by me. I still need to find how 5 fan levels are managed (1-3 are working already with the existing code).
|
Are the modes the same as existing models?
What are the values for this, and what do they do?
What does L+ and R+ mean? General: For capture issue, have you tried everything in the troubleshooting guide? |
Yes they are the same.
They are controlling the display at the wall mounted device. They are already implemented in the "Gree" class properly. Values are the same.
L+ = Between left and center position. Something in between.
Basically yes. It seems that I have a bad device. I will try to tweak some values and order some alternative IR receivers. |
* Add `(set|get)SwingHorizontal()` methods. * Integrate into `IRac` class. * Update unit tests etc. * Fix typo in supported brand name. For #1587
* Add methods. * Update `IRac` class. * Update and add unit tests. For #1587
@chkr1011 I've created branch https://github.com/crankyoldgit/IRremoteESP8266/tree/Vailland / PR #1653 that should add the SwingH & Econo settings you've documented. Can you please download that branch, test it out, and let me know what works and doesn't etc? |
Sure thing... |
Any luck/results? |
Sorry I had no time yet to proceeded. I hopefully get some time this weekend. Sorry for the delay. |
Merging the PR based on no feedback/confirmation. We can change it later. |
* Add `(set|get)SwingHorizontal()` & `(set|get)Econo()` methods. * Integrate into `IRac` class. * Update unit tests etc. * Fix typo in supported brand name. For #1587
_v2.8.0 (20211119)_ **[Bug Fixes]** - Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640) - Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619) **[Features]** - SAMSUNG_AC - Change `clean` setting to a toggle. (#1676 #1677) - Highest fan speed is available without Powerful setting. (#1675 #1678) - Change `beep` setting to a toggle. (#1669 #1671) - Fix Beep for AR12TXEAAWKNEU (#1668 #1669) - Add support for Horizontal Swing & Econo (#1277 #1667) - Add support for On, Off, & Sleep Timers (#1277 #1662) - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650) - HAIER_AC176/HAIER_AC_YRW02 - Add support A/B unit setting (#1672) - Add support degree Fahrenheit (#1659) - Add support `Lock` function (#1652) - Implement horizontal swing feature (#1641) - Implement Quiet setting. (#1634 #1635) - Basic support for Airton Protocol (#1670 #1681) - HAIER_AC176: Add Turbo and Quiet settings (#1634) - Gree: Add `SwingH` & `Econo` control. (#1587 #1653) - MIRAGE - Add experimental detailed support. (#1573 #1615) - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660) - ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645) - Add Russian translation (#1649) - Add Swedish translation (#1627) - Reduce flash space used. (#1633) - Strings finally in Flash! (#1493 #1614 #1623) - Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630) - Make `IRAc::opmodeToString()` output nicer for humans. (#1613) - TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602) - Support for Arris protocol. (#1598) - SharpAc: Allow position control of SwingV (#1590 #1594) **[Misc]** - HAIER_AC176/HAIER_AC_YRW02 - Replace some magic numbers with constants (#1679) - Small fix `Quiet` and `Turbo` test (#1674) - Fix `IRHaierAC176::getTemp()` return value description (#1663) - Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680) - IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661) - IRMQTTServer - Use the correct string for Fan mode in Home Assistant. (#1610 #1657) - Move a lot of the strings/text to flash. (#1638) - Minor code style improvements. (#1656) - Update Supported Devices - HAIER_AC176 (#1673) - LG A/C (#1651 #1655) - Symphony (#1603 #1605) - Epson (#1574 #1601) - GREE (#1587 #1588) - SharpAc (#1590 #1591) - Add extra tests for LG2 protocol (#1654) - Fix parameter expansion in several macros. - Move some strings to `IRtext.cpp` & `locale/default.h` (#1637) - RHOSS: Move include and defines to their correct places (#1636) - Make makefile only build required files when running `run-%` target (#1632) - Update Portuguese translation (#1628) - Add possibility to run specific test case (#1625) - Change `googletest` library ignore (#1626) - Re-work "Fan Only" strings & matching. (#1610) - Address `C0209` pylint warnings. (#1608)
## _v2.8.0 (20211119)_ **[Bug Fixes]** - Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640) - Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619) **[Features]** - SAMSUNG_AC - Change `clean` setting to a toggle. (#1676 #1677) - Highest fan speed is available without Powerful setting. (#1675 #1678) - Change `beep` setting to a toggle. (#1669 #1671) - Fix Beep for AR12TXEAAWKNEU (#1668 #1669) - Add support for Horizontal Swing & Econo (#1277 #1667) - Add support for On, Off, & Sleep Timers (#1277 #1662) - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650) - HAIER_AC176/HAIER_AC_YRW02 - Add support A/B unit setting (#1672) - Add support degree Fahrenheit (#1659) - Add support `Lock` function (#1652) - Implement horizontal swing feature (#1641) - Implement Quiet setting. (#1634 #1635) - Basic support for Airton Protocol (#1670 #1681) - HAIER_AC176: Add Turbo and Quiet settings (#1634) - Gree: Add `SwingH` & `Econo` control. (#1587 #1653) - MIRAGE - Add experimental detailed support. (#1573 #1615) - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660) - ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645) - Add Russian translation (#1649) - Add Swedish translation (#1627) - Reduce flash space used. (#1633) - Strings finally in Flash! (#1493 #1614 #1623) - Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630) - Make `IRAc::opmodeToString()` output nicer for humans. (#1613) - TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602) - Support for Arris protocol. (#1598) - SharpAc: Allow position control of SwingV (#1590 #1594) **[Misc]** - HAIER_AC176/HAIER_AC_YRW02 - Replace some magic numbers with constants (#1679) - Small fix `Quiet` and `Turbo` test (#1674) - Fix `IRHaierAC176::getTemp()` return value description (#1663) - Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680) - IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661) - IRMQTTServer - Use the correct string for Fan mode in Home Assistant. (#1610 #1657) - Move a lot of the strings/text to flash. (#1638) - Minor code style improvements. (#1656) - Update Supported Devices - HAIER_AC176 (#1673) - LG A/C (#1651 #1655) - Symphony (#1603 #1605) - Epson (#1574 #1601) - GREE (#1587 #1588) - SharpAc (#1590 #1591) - Add extra tests for LG2 protocol (#1654) - Fix parameter expansion in several macros. - Move some strings to `IRtext.cpp` & `locale/default.h` (#1637) - RHOSS: Move include and defines to their correct places (#1636) - Make makefile only build required files when running `run-%` target (#1632) - Update Portuguese translation (#1628) - Add possibility to run specific test case (#1625) - Change `googletest` library ignore (#1626) - Re-work "Fan Only" strings & matching. (#1610) - Address `C0209` pylint warnings. (#1608)
FYI, the changes mentioned above have now been included in the new v2.8.0 release of the library. |
Closing this due to no response or update. |
@crankyoldgit I finally had some time testing your changes. They look good from API declaration perspective but I have one issue. The swing states are combined with a automatic mode for vertical swing (setSwingVertical). The modes are either fixed positions OR automatic. There is no way to combine auto mode with a position. I have to choose either a position OR full auto mode. My remote shows that I am able to active a mode like "automatic and moving from top to center only" but my device only moves the full range regardless of the state shown at the remote. Also the "ModelA" feature must be removed completely because this flag is used for the ion filter (which I still need to verify but unfortunately my device has no icon for this. Only the remote shows if it is active and while reverse engineering the received data I seems that my assumption is correct.). I am wondering if the "ModelA" detection is required due to this comment: " // May not be needed. See #814". |
Can you please supply some captures using I've reviewed #814 and this issue again, and I notice I'm not getting a lot of ground-truth data from our tools, so I'm not sure what to trust. |
I will collect some sample data within the next days and share it here. |
Friendly chase up for this data. It's been three weeks. |
@chkr1011 Another chase up ping. |
@chkr1011 Another chase up ping. It's getting close to two months. If we dont hear from you soon, we will close this issue. |
I will close the ticket because I do not have the required hardware yet and not much time to work on this ticket. The current integration works currently fine for me. Maybe I will come back to this issue in several month. |
Hi,
I recently got an AC installed. The manufacturer is "Vaillant" (German brand, which seems to use Gree devices).
I tested this library and I am able to control the AC when using either Kelvinator or Gree components. But unfortunately not all features are available in this library. I someone able to help me out with the missing stuff? I will provide any information required including dumps etc.
What I know so far:
Device responds to "Kelvinator" and "Gree" commands.
Brand: Vaillant
Model: VAI5-035WNI
Remote Model: YACIFB
Remote: https://www.amazon.de/Calvas-Universal-Electrolux-Klimaanlage-Fernbedienung/dp/B07W7YMCZ4
Manual: https://www.vaillant.de/documents/download/423203
The text was updated successfully, but these errors were encountered: