String manipulations giving grief. As usual. #1639
Assignees
Labels
Comments
|
Thanks for the report. Can you please tell us what build target, platform, and IDE you're using so we can replicate this? |
|
I'm asking because this isn't showing up in our automated build system (which is PlatformIO). |
|
The IDE is Visual Studio with PlatformIO |
|
Interesting. I don't get the same result with my env. i.e. Full output of the build below: However, in the meantime, assuming you can't upgrade, I'll look to see what is the "best" fix to give you backward compatiblity. |
|
Oh, and I'm using the current master branch head, not that I think it matters. Just for reference. |
|
FWIW, that is just an educated guess. I didn't look to see if it was something that was fixed, but it wouldn't surprise me if it was something that was fixed. |
|
@jimmys01 & @TD-er Can you please test it against your build environment? I'm going to assume it works as I've basically taking @jimmys01's suggested changes. Branch: https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1639 (PR #1640) To save me the effort of downgrading my environment, any chance I can get you to run the following in your build env (i.e. 2.6.x) in the That is to see if we can flush out any other compiler warning/error oddities I'm not finding in my build env. Thanks in advance. |
|
I don't know why that "custom IR" build env. is still using 2.6.3 Still working on 3.0.x support as it had a lot more to change than I would have expected it to be. |
|
@TD-er I'd be interested to see what "version" they fixed this in (assuming I'm correct) .. I'm hunting through to find when/where they fixed it. |
|
Well there has been a recent merge of PR of mine regarding the way how FlashStrings are being dealt with in the |
|
My current leading candidate is: esp8266/Arduino#7781 where they fixed/corrected the |
|
Yep, looks like a good candidate for what we're seeing here. Concatenating directly to flashstring items used to be quite problematic in the past. |
|
My review of https://github.com/esp8266/Arduino/releases looking for likely changes is 3.0.0 introduced the improvement. i.e. My guess above as the best candidate PR for the change. Anyway. Just waiting for review etc and I'll merge the suggestions. I just fear in all the recent string work we've done there is going to be some other pre-3.0.0 compile issue that we've missed. 🤞 |
crankyoldgit
added
Hacktoberfest
|
With the suggested changes made by @jimmys01 the build was successful. |
Thanks. |
crankyoldgit
added a commit
that referenced
this issue
Nov 19, 2021
_v2.8.0 (20211119)_ **[Bug Fixes]** - Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640) - Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619) **[Features]** - SAMSUNG_AC - Change `clean` setting to a toggle. (#1676 #1677) - Highest fan speed is available without Powerful setting. (#1675 #1678) - Change `beep` setting to a toggle. (#1669 #1671) - Fix Beep for AR12TXEAAWKNEU (#1668 #1669) - Add support for Horizontal Swing & Econo (#1277 #1667) - Add support for On, Off, & Sleep Timers (#1277 #1662) - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650) - HAIER_AC176/HAIER_AC_YRW02 - Add support A/B unit setting (#1672) - Add support degree Fahrenheit (#1659) - Add support `Lock` function (#1652) - Implement horizontal swing feature (#1641) - Implement Quiet setting. (#1634 #1635) - Basic support for Airton Protocol (#1670 #1681) - HAIER_AC176: Add Turbo and Quiet settings (#1634) - Gree: Add `SwingH` & `Econo` control. (#1587 #1653) - MIRAGE - Add experimental detailed support. (#1573 #1615) - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660) - ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645) - Add Russian translation (#1649) - Add Swedish translation (#1627) - Reduce flash space used. (#1633) - Strings finally in Flash! (#1493 #1614 #1623) - Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630) - Make `IRAc::opmodeToString()` output nicer for humans. (#1613) - TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602) - Support for Arris protocol. (#1598) - SharpAc: Allow position control of SwingV (#1590 #1594) **[Misc]** - HAIER_AC176/HAIER_AC_YRW02 - Replace some magic numbers with constants (#1679) - Small fix `Quiet` and `Turbo` test (#1674) - Fix `IRHaierAC176::getTemp()` return value description (#1663) - Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680) - IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661) - IRMQTTServer - Use the correct string for Fan mode in Home Assistant. (#1610 #1657) - Move a lot of the strings/text to flash. (#1638) - Minor code style improvements. (#1656) - Update Supported Devices - HAIER_AC176 (#1673) - LG A/C (#1651 #1655) - Symphony (#1603 #1605) - Epson (#1574 #1601) - GREE (#1587 #1588) - SharpAc (#1590 #1591) - Add extra tests for LG2 protocol (#1654) - Fix parameter expansion in several macros. - Move some strings to `IRtext.cpp` & `locale/default.h` (#1637) - RHOSS: Move include and defines to their correct places (#1636) - Make makefile only build required files when running `run-%` target (#1632) - Update Portuguese translation (#1628) - Add possibility to run specific test case (#1625) - Change `googletest` library ignore (#1626) - Re-work "Fan Only" strings & matching. (#1610) - Address `C0209` pylint warnings. (#1608)
Merged
crankyoldgit
added a commit
that referenced
this issue
Nov 19, 2021
## _v2.8.0 (20211119)_ **[Bug Fixes]** - Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640) - Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619) **[Features]** - SAMSUNG_AC - Change `clean` setting to a toggle. (#1676 #1677) - Highest fan speed is available without Powerful setting. (#1675 #1678) - Change `beep` setting to a toggle. (#1669 #1671) - Fix Beep for AR12TXEAAWKNEU (#1668 #1669) - Add support for Horizontal Swing & Econo (#1277 #1667) - Add support for On, Off, & Sleep Timers (#1277 #1662) - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650) - HAIER_AC176/HAIER_AC_YRW02 - Add support A/B unit setting (#1672) - Add support degree Fahrenheit (#1659) - Add support `Lock` function (#1652) - Implement horizontal swing feature (#1641) - Implement Quiet setting. (#1634 #1635) - Basic support for Airton Protocol (#1670 #1681) - HAIER_AC176: Add Turbo and Quiet settings (#1634) - Gree: Add `SwingH` & `Econo` control. (#1587 #1653) - MIRAGE - Add experimental detailed support. (#1573 #1615) - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660) - ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645) - Add Russian translation (#1649) - Add Swedish translation (#1627) - Reduce flash space used. (#1633) - Strings finally in Flash! (#1493 #1614 #1623) - Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630) - Make `IRAc::opmodeToString()` output nicer for humans. (#1613) - TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602) - Support for Arris protocol. (#1598) - SharpAc: Allow position control of SwingV (#1590 #1594) **[Misc]** - HAIER_AC176/HAIER_AC_YRW02 - Replace some magic numbers with constants (#1679) - Small fix `Quiet` and `Turbo` test (#1674) - Fix `IRHaierAC176::getTemp()` return value description (#1663) - Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680) - IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661) - IRMQTTServer - Use the correct string for Fan mode in Home Assistant. (#1610 #1657) - Move a lot of the strings/text to flash. (#1638) - Minor code style improvements. (#1656) - Update Supported Devices - HAIER_AC176 (#1673) - LG A/C (#1651 #1655) - Symphony (#1603 #1605) - Epson (#1574 #1601) - GREE (#1587 #1588) - SharpAc (#1590 #1591) - Add extra tests for LG2 protocol (#1654) - Fix parameter expansion in several macros. - Move some strings to `IRtext.cpp` & `locale/default.h` (#1637) - RHOSS: Move include and defines to their correct places (#1636) - Make makefile only build required files when running `run-%` target (#1632) - Update Portuguese translation (#1628) - Add possibility to run specific test case (#1625) - Change `googletest` library ignore (#1626) - Re-work "Fan Only" strings & matching. (#1610) - Address `C0209` pylint warnings. (#1608)
|
FYI, the changes mentioned above have now been included in the new v2.8.0 release of the library. |
|
Thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version/revision of the library used
Latest and greatest self compiled build
Describe the bug
The Compiler is nagging about
IRutils.cpp:98:50: error: conversion from 'const __FlashStringHelper* const' to 'const StringSumHelper' is ambiguous return kDashStr + uint64ToString(-input, base);My fix ( I do not know if is the best solution)
return String(kDashStr) + uint64ToString(-input, base);Also
My fix (also dont know if this is the best solution)
? kOffStr : String(uint64ToString(getSensorTemp()) + 'C'), kSensorTempStr);Expected behaviour
To compile.
Keep up the excelent work
Mutsos Gracias
The text was updated successfully, but these errors were encountered: