Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SamsungAc: Add support for Horizontal Swing & Econo #1667

Merged
merged 4 commits into from
Nov 10, 2021
Merged

SamsungAc: Add support for Horizontal Swing & Econo #1667

merged 4 commits into from
Nov 10, 2021

Conversation

crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Nov 9, 2021 •
edited
Loading

  • Update swing functions to work with both vertical & horizontal.
  • Add Econo setting control.
  • Add extra bit related to sleep timer mode.
  • Extend & update unit tests.
  • Remove old/redundant TODOs.
  • Move some internal constants to the .cpp file.
  • Bump string allocation in toString().

For #1277 (comment)

@crankyoldgit
SamsungAc: Add support for Horizontal Swing.
d74a4e2 
* Update swing functions to work with both vertical & horizontal.
* Extend & update unit tests.
* Remove old/redundant TODOs.
* Move some internal constants to the .cpp file.
* Bump string allocation in `toString()`.

For #1277 (comment)
@crankyoldgit crankyoldgit added enhancement Pending Confirmation Waiting for confirmation from user labels Nov 9, 2021
@crankyoldgit crankyoldgit self-assigned this Nov 9, 2021
@crankyoldgit crankyoldgit mentioned this pull request Nov 9, 2021
Closed
NiKiZe
NiKiZe approved these changes Nov 9, 2021
View reviewed changes
src/ir_Samsung.cpp Outdated Show resolved Hide resolved
@crankyoldgit
Code Review Feedback.
5a5956a 
Cleanup so minor formating and code style issues.
@xorbital
Copy link
Contributor

Decoding with IRrecvDumpV3 works, the codes are identical to the original remote 👍
Sending works, the A/C is picking up the codes properly.
Thank you very much!

@crankyoldgit
SamsungAc: Add support for Econo (Eco) setting.
25d9636 
* Add `setEcono()` & `getEcono()`
* Add to `IRac` as well.
* Improve Unit tests.

For #1277
@crankyoldgit
Copy link
Owner Author

Decoding with IRrecvDumpV3 works, the codes are identical to the original remote 👍 Sending works, the A/C is picking up the codes properly. Thank you very much!

@xorbital No problems. I just added "Econo" (Eco) support as well to that branch/this PR. Care you give it a quick test too?

@crankyoldgit crankyoldgit changed the title SamsungAc: Add support for Horizontal Swing. SamsungAc: Add support for Horizontal Swing & Econo Nov 10, 2021
@crankyoldgit
SamsungAc: Set a bit in state[5] for sleep timer.
d68bb84 
* Seems we missed a bit that changes wit h the sleep timer in `state[5]`.
* Make the timers get reported in `::toString()`.
* Add a unit test to confirm we can build the same message as the remote generates.

Ref: #1277 (comment)
@crankyoldgit crankyoldgit added Pending Confirmation Waiting for confirmation from user and removed Pending Confirmation Waiting for confirmation from user labels Nov 10, 2021
@xorbital
Copy link
Contributor

xorbital commented Nov 10, 2021 •
edited
Loading

Thanks for the quick update - squashing issues faster than I can create them 👍
Eco Mode is working - I think. The remote can only send a short code to activate Eco Mode, however the A/C reacts properly even with the long code, and the codes are identical except the format.
There's no indication whether Eco Mode is on at the Unit, but I think it's working.

The sleep timer is formatted properly now as well, and a little clock icon appears on the unit 👍
So all in all, everything in this PR seems to be working fine, thanks again 🙂

@crankyoldgit
Copy link
Owner Author

Thanks for confirming.

@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Nov 10, 2021
@crankyoldgit crankyoldgit merged commit 817517c into master Nov 10, 2021
@crankyoldgit crankyoldgit deleted the samsung_swing branch November 12, 2021 23:24
crankyoldgit added a commit that referenced this pull request Nov 19, 2021
@crankyoldgit
v2.8.0 release
d31c432 
_v2.8.0 (20211119)_

**[Bug Fixes]**
- Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640)
- Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619)

**[Features]**
- SAMSUNG_AC
  - Change `clean` setting to a toggle. (#1676 #1677)
  - Highest fan speed is available without Powerful setting. (#1675 #1678)
  - Change `beep` setting to a toggle. (#1669 #1671)
  - Fix Beep for AR12TXEAAWKNEU (#1668 #1669)
  - Add support for Horizontal Swing & Econo (#1277 #1667)
  - Add support for On, Off, & Sleep Timers (#1277 #1662)
  - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650)
- HAIER_AC176/HAIER_AC_YRW02
  - Add support A/B unit setting (#1672)
  - Add support degree Fahrenheit (#1659)
  - Add support `Lock` function (#1652)
  - Implement horizontal swing feature (#1641)
  - Implement Quiet setting. (#1634 #1635)
- Basic support for Airton Protocol (#1670 #1681)
- HAIER_AC176: Add Turbo and Quiet settings (#1634)
- Gree: Add `SwingH` & `Econo` control. (#1587 #1653)
- MIRAGE
  - Add experimental detailed support. (#1573 #1615)
  - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660)
- ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645)
- Add Russian translation (#1649)
- Add Swedish translation (#1627)
- Reduce flash space used. (#1633)
- Strings finally in Flash! (#1493 #1614 #1623)
- Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630)
- Make `IRAc::opmodeToString()` output nicer for humans. (#1613)
- TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602)
- Support for Arris protocol. (#1598)
- SharpAc: Allow position control of SwingV (#1590 #1594)

**[Misc]**
- HAIER_AC176/HAIER_AC_YRW02
  - Replace some magic numbers with constants (#1679)
  - Small fix `Quiet` and `Turbo` test (#1674)
  - Fix `IRHaierAC176::getTemp()` return value description (#1663)
- Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680)
- IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661)
- IRMQTTServer
  - Use the correct string for Fan mode in Home Assistant. (#1610 #1657)
  - Move a lot of the strings/text to flash. (#1638)
- Minor code style improvements. (#1656)
- Update Supported Devices
  - HAIER_AC176 (#1673)
  - LG A/C (#1651 #1655)
  - Symphony (#1603 #1605)
  - Epson (#1574 #1601)
  - GREE (#1587 #1588)
  - SharpAc (#1590 #1591)
- Add extra tests for LG2 protocol (#1654)
- Fix parameter expansion in several macros.
- Move some strings to `IRtext.cpp` & `locale/default.h` (#1637)
- RHOSS: Move include and defines to their correct places (#1636)
- Make makefile only build required files when running `run-%` target (#1632)
- Update Portuguese translation (#1628)
- Add possibility to run specific test case (#1625)
- Change `googletest` library ignore (#1626)
- Re-work "Fan Only" strings & matching. (#1610)
- Address `C0209` pylint warnings. (#1608)
@crankyoldgit crankyoldgit mentioned this pull request Nov 19, 2021
Merged
crankyoldgit added a commit that referenced this pull request Nov 19, 2021
@crankyoldgit
v2.8.0 release (#1682)
7b13d24 
## _v2.8.0 (20211119)_

**[Bug Fixes]**
- Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640)
- Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619)

**[Features]**
- SAMSUNG_AC
  - Change `clean` setting to a toggle. (#1676 #1677)
  - Highest fan speed is available without Powerful setting. (#1675 #1678)
  - Change `beep` setting to a toggle. (#1669 #1671)
  - Fix Beep for AR12TXEAAWKNEU (#1668 #1669)
  - Add support for Horizontal Swing & Econo (#1277 #1667)
  - Add support for On, Off, & Sleep Timers (#1277 #1662)
  - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650)
- HAIER_AC176/HAIER_AC_YRW02
  - Add support A/B unit setting (#1672)
  - Add support degree Fahrenheit (#1659)
  - Add support `Lock` function (#1652)
  - Implement horizontal swing feature (#1641)
  - Implement Quiet setting. (#1634 #1635)
- Basic support for Airton Protocol (#1670 #1681)
- HAIER_AC176: Add Turbo and Quiet settings (#1634)
- Gree: Add `SwingH` & `Econo` control. (#1587 #1653)
- MIRAGE
  - Add experimental detailed support. (#1573 #1615)
  - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660)
- ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645)
- Add Russian translation (#1649)
- Add Swedish translation (#1627)
- Reduce flash space used. (#1633)
- Strings finally in Flash! (#1493 #1614 #1623)
- Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630)
- Make `IRAc::opmodeToString()` output nicer for humans. (#1613)
- TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602)
- Support for Arris protocol. (#1598)
- SharpAc: Allow position control of SwingV (#1590 #1594)

**[Misc]**
- HAIER_AC176/HAIER_AC_YRW02
  - Replace some magic numbers with constants (#1679)
  - Small fix `Quiet` and `Turbo` test (#1674)
  - Fix `IRHaierAC176::getTemp()` return value description (#1663)
- Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680)
- IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661)
- IRMQTTServer
  - Use the correct string for Fan mode in Home Assistant. (#1610 #1657)
  - Move a lot of the strings/text to flash. (#1638)
- Minor code style improvements. (#1656)
- Update Supported Devices
  - HAIER_AC176 (#1673)
  - LG A/C (#1651 #1655)
  - Symphony (#1603 #1605)
  - Epson (#1574 #1601)
  - GREE (#1587 #1588)
  - SharpAc (#1590 #1591)
- Add extra tests for LG2 protocol (#1654)
- Fix parameter expansion in several macros.
- Move some strings to `IRtext.cpp` & `locale/default.h` (#1637)
- RHOSS: Move include and defines to their correct places (#1636)
- Make makefile only build required files when running `run-%` target (#1632)
- Update Portuguese translation (#1628)
- Add possibility to run specific test case (#1625)
- Change `googletest` library ignore (#1626)
- Re-work "Fan Only" strings & matching. (#1610)
- Address `C0209` pylint warnings. (#1608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

@PtilopsisLeucotis PtilopsisLeucotis Awaiting requested review from PtilopsisLeucotis

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crankyoldgit @xorbital @NiKiZe