Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting "Beep" doesn't work on Samsung AR12TXEAAWKNEU #1669

Closed
xorbital opened this issue Nov 10, 2021 · 4 comments · Fixed by #1671
Closed

Setting "Beep" doesn't work on Samsung AR12TXEAAWKNEU #1669

xorbital opened this issue Nov 10, 2021 · 4 comments · Fixed by #1671
Assignees
@crankyoldgit
Labels
bug enhancement

Comments

@xorbital
Copy link
Contributor

xorbital commented Nov 10, 2021 •
edited
Loading

Version/revision of the library used

master (817517c)

Describe the bug

Setting "Beep: On" doesn't toggle the beep state on my unit.

To Reproduce

Set "Beep: On" when sending a Samsung IR message.

Example code used

N/A

Expected behaviour

The code should spit out a valid IR message that toggles the beep state.

Output of raw data from IRrecvDumpV2.ino or V3 (if applicable)

I can upload a dump if you need it - however I've figured out what's causing the issue and fixed it in #1668 . Also I don't want to raise your blood pressure by posting VS1838b dumps.

What brand/model IR demodulator are you using?

I think it's called B14Y, however somehow the results from that are even worse than from my VS1838b

If VS1838b: That is likely your problem. Please buy a better one & try again. Reporting a capture or decode issue when you use one of these is effectively wasting our & your time. See the FAQ

Yes, I agree, it's a piece of ****, however it's been working fine with 30% tolerance for all captures.
Also, I've put the whole circuit in a long, dark box, gave it a few headpats and the results are good.

Circuit diagram and hardware used (if applicable)

N/A

I have followed the steps in the Troubleshooting Guide & read the FAQ

Yes

Has this library/code previously worked as expected for you?

No, the beep never worked

Other useful information

When Sending "Beep: On", the last nibble will be set to 2 (0010), while it's required to be set to 4 (0100). This is fixed in #1668 , however I have no knowledge of C++, so I'll need you to take a look at my PR to see if I just broke the whole thing / broke compatibility with other models.
Using the fix in the PR makes my unit beep like it's supposed to, exactly like the original remote.
@crankyoldgit crankyoldgit mentioned this issue Nov 11, 2021
Merged
crankyoldgit pushed a commit that referenced this issue Nov 11, 2021
@xorbital
Fix Beep for AR12TXEAAWKNEU (#1668)
d896068 
The bit for Beep needs to be at this different location.

For #1669
@crankyoldgit crankyoldgit self-assigned this Nov 11, 2021
@crankyoldgit
Copy link
Owner

@xorbital You've mentioned this is (beep) is a toggle.
Just confirming: Does that mean when it is present in a message it will change what ever the current setting is on the A/C?
i.e. If the bit is zero in a message, everything stays the same beep-wise. A single message with the beep-bit set will change on->off, and off->on.

If so, I'll need to make some additional changes other than your PR #1668

crankyoldgit added a commit that referenced this issue Nov 11, 2021
@crankyoldgit
SamsungAc: Change beep setting to a toggle.
4f53750 
* Use the `beep` bit as a toggle setting.
* Update `IRSamsungAc` & `IRac` classes.
* Revise unit tests accordingly.

Fixes #1669
@crankyoldgit crankyoldgit mentioned this issue Nov 11, 2021
Merged
@crankyoldgit
Copy link
Owner

Assuming it is a toggle, PR #1671 / Branch https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1669 should handle it better. Let me know etc. If it isn't a toggle, then we can ignore #1671

@xorbital
Copy link
Contributor Author

xorbital commented Nov 11, 2021 •
edited
Loading

Yes, exactly, it does behave like a toggle. IIRC that's also true for the CLEAN setting.
I'll re-test the CLEAN setting and will open a new issue if it's a toggle as well.
Currently testing #1671, thanks for the quick fix :)

crankyoldgit added a commit that referenced this issue Nov 11, 2021
@crankyoldgit
SamsungAc: Change beep setting to a toggle. (#1671)
291f13b 
* Use the `beep` bit as a toggle setting.
* Update `IRSamsungAc` & `IRac` classes.
* Revise unit tests accordingly.

Fixes #1669
crankyoldgit added a commit that referenced this issue Nov 19, 2021
@crankyoldgit
v2.8.0 release
d31c432 
_v2.8.0 (20211119)_

**[Bug Fixes]**
- Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640)
- Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619)

**[Features]**
- SAMSUNG_AC
  - Change `clean` setting to a toggle. (#1676 #1677)
  - Highest fan speed is available without Powerful setting. (#1675 #1678)
  - Change `beep` setting to a toggle. (#1669 #1671)
  - Fix Beep for AR12TXEAAWKNEU (#1668 #1669)
  - Add support for Horizontal Swing & Econo (#1277 #1667)
  - Add support for On, Off, & Sleep Timers (#1277 #1662)
  - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650)
- HAIER_AC176/HAIER_AC_YRW02
  - Add support A/B unit setting (#1672)
  - Add support degree Fahrenheit (#1659)
  - Add support `Lock` function (#1652)
  - Implement horizontal swing feature (#1641)
  - Implement Quiet setting. (#1634 #1635)
- Basic support for Airton Protocol (#1670 #1681)
- HAIER_AC176: Add Turbo and Quiet settings (#1634)
- Gree: Add `SwingH` & `Econo` control. (#1587 #1653)
- MIRAGE
  - Add experimental detailed support. (#1573 #1615)
  - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660)
- ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645)
- Add Russian translation (#1649)
- Add Swedish translation (#1627)
- Reduce flash space used. (#1633)
- Strings finally in Flash! (#1493 #1614 #1623)
- Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630)
- Make `IRAc::opmodeToString()` output nicer for humans. (#1613)
- TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602)
- Support for Arris protocol. (#1598)
- SharpAc: Allow position control of SwingV (#1590 #1594)

**[Misc]**
- HAIER_AC176/HAIER_AC_YRW02
  - Replace some magic numbers with constants (#1679)
  - Small fix `Quiet` and `Turbo` test (#1674)
  - Fix `IRHaierAC176::getTemp()` return value description (#1663)
- Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680)
- IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661)
- IRMQTTServer
  - Use the correct string for Fan mode in Home Assistant. (#1610 #1657)
  - Move a lot of the strings/text to flash. (#1638)
- Minor code style improvements. (#1656)
- Update Supported Devices
  - HAIER_AC176 (#1673)
  - LG A/C (#1651 #1655)
  - Symphony (#1603 #1605)
  - Epson (#1574 #1601)
  - GREE (#1587 #1588)
  - SharpAc (#1590 #1591)
- Add extra tests for LG2 protocol (#1654)
- Fix parameter expansion in several macros.
- Move some strings to `IRtext.cpp` & `locale/default.h` (#1637)
- RHOSS: Move include and defines to their correct places (#1636)
- Make makefile only build required files when running `run-%` target (#1632)
- Update Portuguese translation (#1628)
- Add possibility to run specific test case (#1625)
- Change `googletest` library ignore (#1626)
- Re-work "Fan Only" strings & matching. (#1610)
- Address `C0209` pylint warnings. (#1608)
@crankyoldgit crankyoldgit mentioned this issue Nov 19, 2021
Merged
crankyoldgit added a commit that referenced this issue Nov 19, 2021
@crankyoldgit
v2.8.0 release (#1682)
7b13d24 
## _v2.8.0 (20211119)_

**[Bug Fixes]**
- Fix compilation issue when using old 8266 Arduino Frameworks. (#1639 #1640)
- Fix potential security issue with `scrape_supported_devices.py` (#1616 #1619)

**[Features]**
- SAMSUNG_AC
  - Change `clean` setting to a toggle. (#1676 #1677)
  - Highest fan speed is available without Powerful setting. (#1675 #1678)
  - Change `beep` setting to a toggle. (#1669 #1671)
  - Fix Beep for AR12TXEAAWKNEU (#1668 #1669)
  - Add support for Horizontal Swing & Econo (#1277 #1667)
  - Add support for On, Off, & Sleep Timers (#1277 #1662)
  - Fix power control. Clean-up code & bitmaps from Checksum changes. (#1277 #1648 #1650)
- HAIER_AC176/HAIER_AC_YRW02
  - Add support A/B unit setting (#1672)
  - Add support degree Fahrenheit (#1659)
  - Add support `Lock` function (#1652)
  - Implement horizontal swing feature (#1641)
  - Implement Quiet setting. (#1634 #1635)
- Basic support for Airton Protocol (#1670 #1681)
- HAIER_AC176: Add Turbo and Quiet settings (#1634)
- Gree: Add `SwingH` & `Econo` control. (#1587 #1653)
- MIRAGE
  - Add experimental detailed support. (#1573 #1615)
  - Experimental detailed support for KKG29A-C1 remote. (#1573 #1660)
- ELECTRA_AC: Add support for "IFeel" & Sensor settings. (#1644 #1645)
- Add Russian translation (#1649)
- Add Swedish translation (#1627)
- Reduce flash space used. (#1633)
- Strings finally in Flash! (#1493 #1614 #1623)
- Add support for Rhoss Idrowall MPCV 20-30-35-40 A/C protocol (#1630)
- Make `IRAc::opmodeToString()` output nicer for humans. (#1613)
- TCL112AC/TEKNOPOINT: Add support for `GZ055BE1` model (#1486 #1602)
- Support for Arris protocol. (#1598)
- SharpAc: Allow position control of SwingV (#1590 #1594)

**[Misc]**
- HAIER_AC176/HAIER_AC_YRW02
  - Replace some magic numbers with constants (#1679)
  - Small fix `Quiet` and `Turbo` test (#1674)
  - Fix `IRHaierAC176::getTemp()` return value description (#1663)
- Security Policy creation and changes. (#1616 #1617 #1618 #1621 #1680)
- IRrecvDumpV2/3: Update PlatformIO envs for missing languages (#1661)
- IRMQTTServer
  - Use the correct string for Fan mode in Home Assistant. (#1610 #1657)
  - Move a lot of the strings/text to flash. (#1638)
- Minor code style improvements. (#1656)
- Update Supported Devices
  - HAIER_AC176 (#1673)
  - LG A/C (#1651 #1655)
  - Symphony (#1603 #1605)
  - Epson (#1574 #1601)
  - GREE (#1587 #1588)
  - SharpAc (#1590 #1591)
- Add extra tests for LG2 protocol (#1654)
- Fix parameter expansion in several macros.
- Move some strings to `IRtext.cpp` & `locale/default.h` (#1637)
- RHOSS: Move include and defines to their correct places (#1636)
- Make makefile only build required files when running `run-%` target (#1632)
- Update Portuguese translation (#1628)
- Add possibility to run specific test case (#1625)
- Change `googletest` library ignore (#1626)
- Re-work "Fan Only" strings & matching. (#1610)
- Address `C0209` pylint warnings. (#1608)
@crankyoldgit
Copy link
Owner

FYI, the changes mentioned above have now been included in the new v2.8.0 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SamsungAc: Change beep setting to a toggle. crankyoldgit/IRremoteESP8266
2 participants
@crankyoldgit @xorbital