-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monorepo] - Import flyteidl #4017
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add new phases to Task execution
* Add an ErrorKind field in ContainerError * Bump versions
* Add FailureHandlingStrategy to workflow idl * Rename and allow overrides per LaunchPlan and Execution * Revert override changes * revert
* Only keep options we will implement at the moment * regenerate
* IDL changes for Node-Node relationship refactor * Ability to provide information of the parent node. * Introduction of group_id to indicate grouping of nodes within the Parent node - (instead of dummy nodes) * Support for querying all nodes under node with group. * Support for node_id to point to original node in the workflow/graph, and node_name
…#70) * Catalog store handling * Event proto updated * generated * merged * Dataset Identifier changed * Better model * Exposing TaskNodeMetadata with catalog information in the API * 0.17.38 * Comment * docs updated
…in algorithms) and HyperparameterTuningJob (#66) * adding sagemaker protos Co-authored-by: Haytham AbuelFutuh <[email protected]>
* first cut * bump version * add to project.json * regen Co-authored-by: Konstantin Gizdarski <[email protected]> Co-authored-by: Katrina Rogan <[email protected]>
* add project update endpoint * PR comments * pr comments * pr comments (last one ;p) * spelling * generate Co-authored-by: Konstantin Gizdarski <[email protected]> Co-authored-by: Katrina Rogan <[email protected]>
This PR fixes Stackdriver log link using `resource.labels.pod_name` as `advancedFilter` instead of `logName`.
* Support cron schedule with offset. For example: https://github.com/spotify/styx#schedule-string * Add generated files * Update protos/flyteidl/admin/schedule.proto Co-authored-by: Yee Hing Tong <[email protected]> * Update protos/flyteidl/admin/schedule.proto Co-authored-by: Yee Hing Tong <[email protected]> * Update protos/flyteidl/admin/schedule.proto Co-authored-by: Yee Hing Tong <[email protected]> * Regenerate files * Regenerate files * Change the message name back * Revert "Change the message name back" This reverts commit e468ea836dd30fc01699fd417ee64a182603b7f7. * Add comments for schedule and offset Co-authored-by: Yee Hing Tong <[email protected]>
…ing (#84) * `distributed_protocol` added as a field in training job resource config
* Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * Add backend plugin system service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * update state Signed-off-by: Kevin Su <[email protected]> * dics Signed-off-by: Kevin Su <[email protected]> * Remove output prefix from get request Signed-off-by: Kevin Su <[email protected]> * update Signed-off-by: Kevin Su <[email protected]> * remove prev state Signed-off-by: Kevin Su <[email protected]> * update proto Signed-off-by: Kevin Su <[email protected]> * remove error message Signed-off-by: Kevin Su <[email protected]> * update comment Signed-off-by: Kevin Su <[email protected]> * make generate Signed-off-by: Kevin Su <[email protected]> * Rename the service Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
* Generate rust protobuf using buf Signed-off-by: eduardo apolinario <[email protected]> * Commit generated rust code Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
* Move to official remote plugins Signed-off-by: eduardo apolinario <[email protected]> * Regenerate python files Signed-off-by: eduardo apolinario <[email protected]> --------- Signed-off-by: eduardo apolinario <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
* Add elastic config args to pytorch proto Signed-off-by: Fabio Graetz <[email protected]> * Add elastic config message type for torchrun training Signed-off-by: Fabio Graetz <[email protected]> --------- Signed-off-by: Fabio Graetz <[email protected]> Co-authored-by: Fabio Grätz <[email protected]> Co-authored-by: Ketan Umare <[email protected]>
Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]> #minor
Signed-off-by: Yee Hing Tong <[email protected]> #minor
…ecs for different replica groups (#386) * refactor kubeflow operators proto Signed-off-by: Yubo Wang <[email protected]> * add back the original proto for backward compatible Signed-off-by: Yubo Wang <[email protected]> * clean up comments Signed-off-by: Yubo Wang <[email protected]> * add kubeflow.rs Signed-off-by: Yubo Wang <[email protected]> * add elastic config Signed-off-by: Yubo Wang <[email protected]> * add command to MPI Signed-off-by: Yubo Wang <[email protected]> * add slots and command to mpi spec Signed-off-by: Yubo Wang <[email protected]> --------- Signed-off-by: Yubo Wang <[email protected]> Co-authored-by: Yubo Wang <[email protected]>
Signed-off-by: byhsu <[email protected]> Signed-off-by: eduardo apolinario <[email protected]> Co-authored-by: byhsu <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
* add support for Union Scalar Signed-off-by: Yubo Wang <[email protected]> * support union type and literals Signed-off-by: Yubo Wang <[email protected]> * change union type extraction Signed-off-by: Yubo Wang <[email protected]> --------- Signed-off-by: Yubo Wang <[email protected]> Co-authored-by: Yubo Wang <[email protected]> Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: byhsu <[email protected]> Co-authored-by: byhsu <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: byhsu <[email protected]>
* Rename externalPluginService to AgentService Signed-off-by: Kevin Su <[email protected]> * nit Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
* Add external-plugin-service proto back to the idl Signed-off-by: Kevin Su <[email protected]> * update idl Signed-off-by: Kevin Su <[email protected]> * update idll Signed-off-by: Kevin Su <[email protected]> * update idll Signed-off-by: Kevin Su <[email protected]> * AsyncAgentService Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Yee Hing Tong <[email protected]>
* added initial ArrayNode definition Signed-off-by: Daniel Rammer <[email protected]> * updated parallelism and min_successes int types Signed-off-by: Daniel Rammer <[email protected]> * updated min_successes type Signed-off-by: Daniel Rammer <[email protected]> * updated docs Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]> Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: eduardo apolinario <[email protected]>
* Pass task execution metadata from agent Signed-off-by: Hongxin Liang <[email protected]> * Add doc Signed-off-by: Hongxin Liang <[email protected]> * Update protos/flyteidl/admin/agent.proto Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Honnix <[email protected]> * Regenerate --------- Signed-off-by: Hongxin Liang <[email protected]> Signed-off-by: Honnix <[email protected]> Co-authored-by: Kevin Su <[email protected]>
* add tags to execution spec Signed-off-by: Kevin Su <[email protected]> * add tags to execution spec Signed-off-by: Kevin Su <[email protected]> * add comment Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Katrina Rogan <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Daniel Rammer <[email protected]>
…orepo--import-flyteidl Signed-off-by: Eduardo Apolinario <[email protected]>
pingsutw
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR imports flyteidl as a top-level component in the monorepo. Subsequent PRs are going to fix the module name, fix single-binary compilation, etc.
This brings flyteorg/flyteidl@7f62a15.