Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][java-client] Remove redundant pending messages information while printing the producer stats #17671

Merged
merged 11 commits into from
Sep 16, 2022

Conversation

codertmy
Copy link
Contributor

@codertmy codertmy commented Sep 15, 2022

Motivation

The pending messages information is redundant while print the producer stats

Modifications

Remove redundant pending messages information

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)
  • doc-not-needed
    (Please explain why)
  • doc
    (Your PR contains doc changes)
  • doc-complete
    (Your PR contains doc changes)

tmytangmingyang added 2 commits September 15, 2022 20:29
remove redundant Pending messages log info of ProducerStatsRecorderImpl
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 15, 2022
@AnonHxy AnonHxy changed the title [improve][java-client] Remove redundant pending messages information while print the producer stats #15440 [improve][java-client] Remove redundant pending messages information while print the producer stats Sep 15, 2022
@AnonHxy
Copy link
Contributor

AnonHxy commented Sep 16, 2022

Nice catch. LGTM

BewareMyPower and others added 9 commits September 16, 2022 11:39
### Motivation

There are some wrong steps in the release process and the "Release
workflow" section is just a list and hard to verify directly.

### Modifications

- Remove the "Move master branch to next version" and "Write release
  notes" sections because they should be done in the last few steps and
  they have already been documented.
- Add the steps to build Docker images when running the vote.
- Skip the release of Helm Chart for patch releases.
- Update the step to publish Python clients for macOS because we won't
  need the VirtualBox after apache#15024.

Regenerate the table of contents via `gh-md-toc` to replace the "Release
workflow" section. Then we can verify it by clicking the link to the
corresponding section.
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason918 Jason918 added this to the 2.12.0 milestone Sep 16, 2022
@Jason918 Jason918 added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages component/client-java labels Sep 16, 2022
@Jason918 Jason918 merged commit 364d14b into apache:master Sep 16, 2022
@momo-jun momo-jun changed the title [improve][java-client] Remove redundant pending messages information while print the producer stats [improve][java-client] Remove redundant pending messages information while printing the producer stats Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants