-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][java-client] Remove redundant pending messages information while printing the producer stats #17671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove redundant Pending messages log info of ProducerStatsRecorderImpl
AnonHxy
changed the title
[improve][java-client] Remove redundant pending messages information while print the producer stats #15440
[improve][java-client] Remove redundant pending messages information while print the producer stats
Sep 15, 2022
AnonHxy
approved these changes
Sep 16, 2022
Nice catch. LGTM |
### Motivation There are some wrong steps in the release process and the "Release workflow" section is just a list and hard to verify directly. ### Modifications - Remove the "Move master branch to next version" and "Write release notes" sections because they should be done in the last few steps and they have already been documented. - Add the steps to build Docker images when running the vote. - Skip the release of Helm Chart for patch releases. - Update the step to publish Python clients for macOS because we won't need the VirtualBox after apache#15024. Regenerate the table of contents via `gh-md-toc` to replace the "Release workflow" section. Then we can verify it by clicking the link to the corresponding section.
…Installation" title (apache#17580)
…tioned system topic (apache#17338)
Jason918
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Jason918
added
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
component/client-java
labels
Sep 16, 2022
momo-jun
changed the title
[improve][java-client] Remove redundant pending messages information while print the producer stats
[improve][java-client] Remove redundant pending messages information while printing the producer stats
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/client
doc-not-needed
Your PR changes do not impact docs
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The pending messages information is redundant while print the producer stats
Modifications
Remove redundant pending messages information
Verifying this change
Make sure that the change passes the CI checks.
Documentation
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Your PR contains doc changes)