-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Custom resource actions #5838
Conversation
9b0d8cc
to
451dc25
Compare
Codecov Report
@@ Coverage Diff @@
## master #5838 +/- ##
=======================================
Coverage 40.93% 40.93%
=======================================
Files 147 147
Lines 19661 19661
=======================================
Hits 8049 8049
Misses 10508 10508
Partials 1104 1104
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great write-up btw!
definitions: | ||
- name: suspend | ||
action.lua: | | ||
obj.spec.suspend = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be able to help us with a more realistic example, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this example is very realistic. It makes it really easy to suspend and resume CronJobs from UI. I would even bundle it into Argo CD .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on custom actions documentation @moensch ! It is a shame we did not have it for such a long time.
Can you please add docs/operator-manual/resource_actions.md
to https://github.com/argoproj/argo-cd/blob/master/mkdocs.yml#L52 ?
Signed-off-by: Samuel Suter <[email protected]>
451dc25
to
9fc72f4
Compare
5bc7297 fix: bitbucket server failing diagnostics:ping (argoproj#6029) (argoproj#6034) 8f53bd5 fix: add helm dependencies with custom CA (argoproj#6003) 8fd6f13 docs: Custom resource actions (argoproj#5838) 8a2897d docs: update delete policy verbiage (argoproj#6025) c847bd9 chore: remove Argo CD CRDs from namespaced install (argoproj#6022) 61080b3 docs: improve Orphaned Resources Monitoring with more examples and correct grammar (argoproj#6006) 8301d39 Adding explicit bind to redis and sentinel for IPv4 clusters argoproj#5957 (argoproj#6005) 12cabdf fix: adding tests for helm OCI registry (argoproj#5978) 9da9514 docs: Add Ant Group to the list of users (argoproj#6011) 5e34a8a add Polarpoint.io (argoproj#6010) 2f92777 chore: move access checks from api server to repo server (argoproj#5940) ae2d0ff fix(ui): Unscheduled pods in node view are now visible. Fixes argoproj#5981 (argoproj#5988) b003f70 docs: SealedSecret status missing on k8s 1.16+ (argoproj#5846) 445872f fix: use correct field for evaluating whether or not GitHub Enterprise is selected (argoproj#5987) 9afa833 chore: Make e2e tests runnable against remote cluster (argoproj#5895)
Signed-off-by: Samuel Suter <[email protected]>
Documents how to add custom resource actions to
argocd-cm
.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: