Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update delete policy verbiage #6025

Merged
merged 1 commit into from
Apr 13, 2021
Merged

docs: update delete policy verbiage #6025

merged 1 commit into from
Apr 13, 2021

Conversation

jef
Copy link
Contributor

@jef jef commented Apr 13, 2021

Description

Updated the documentation as it's somewhat vague on the BeforeHookCreation policy.

Ref: #4295

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #6025 (1b022a6) into master (61080b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6025   +/-   ##
=======================================
  Coverage   40.93%   40.93%           
=======================================
  Files         147      147           
  Lines       19661    19661           
=======================================
  Hits         8049     8049           
  Misses      10508    10508           
  Partials     1104     1104           
Impacted Files Coverage Δ
util/settings/settings.go 41.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61080b3...1b022a6. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@alexmt alexmt merged commit 8a2897d into argoproj:master Apr 13, 2021
@jef jef deleted the patch-1 branch April 14, 2021 00:13
@jef
Copy link
Contributor Author

jef commented Apr 14, 2021

Thanks!

yujunz added a commit to abcue/argo-cd that referenced this pull request Apr 15, 2021
5bc7297 fix: bitbucket server failing diagnostics:ping (argoproj#6029) (argoproj#6034)
8f53bd5 fix: add helm dependencies with custom CA (argoproj#6003)
8fd6f13 docs: Custom resource actions (argoproj#5838)
8a2897d docs: update delete policy verbiage (argoproj#6025)
c847bd9 chore: remove Argo CD CRDs from namespaced install (argoproj#6022)
61080b3 docs: improve Orphaned Resources Monitoring with more examples and correct grammar (argoproj#6006)
8301d39 Adding explicit bind to redis and sentinel for IPv4 clusters argoproj#5957 (argoproj#6005)
12cabdf fix: adding tests for helm OCI registry (argoproj#5978)
9da9514 docs: Add Ant Group to the list of users (argoproj#6011)
5e34a8a add Polarpoint.io (argoproj#6010)
2f92777 chore: move access checks from api server to repo server (argoproj#5940)
ae2d0ff fix(ui): Unscheduled pods in node view are now visible. Fixes argoproj#5981 (argoproj#5988)
b003f70 docs: SealedSecret status missing on k8s 1.16+ (argoproj#5846)
445872f fix: use correct field for evaluating whether or not GitHub Enterprise is selected (argoproj#5987)
9afa833 chore: Make e2e tests runnable against remote cluster (argoproj#5895)
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants