Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Unscheduled pods in node view are now visible. Fixes #5981 #5988

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

rbreeze
Copy link
Member

@rbreeze rbreeze commented Apr 8, 2021

Signed-off-by: Remington Breeze [email protected]
Fixes #5981
Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you fix linter error please? Feel free to merge when CI is green

Signed-off-by: Remington Breeze <[email protected]>
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #5988 (bdff113) into master (9afa833) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5988   +/-   ##
=======================================
  Coverage   40.95%   40.95%           
=======================================
  Files         147      147           
  Lines       19656    19656           
=======================================
  Hits         8051     8051           
  Misses      10499    10499           
  Partials     1106     1106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9afa833...bdff113. Read the comment docs.

@rbreeze rbreeze merged commit ae2d0ff into argoproj:master Apr 8, 2021
yujunz added a commit to abcue/argo-cd that referenced this pull request Apr 15, 2021
5bc7297 fix: bitbucket server failing diagnostics:ping (argoproj#6029) (argoproj#6034)
8f53bd5 fix: add helm dependencies with custom CA (argoproj#6003)
8fd6f13 docs: Custom resource actions (argoproj#5838)
8a2897d docs: update delete policy verbiage (argoproj#6025)
c847bd9 chore: remove Argo CD CRDs from namespaced install (argoproj#6022)
61080b3 docs: improve Orphaned Resources Monitoring with more examples and correct grammar (argoproj#6006)
8301d39 Adding explicit bind to redis and sentinel for IPv4 clusters argoproj#5957 (argoproj#6005)
12cabdf fix: adding tests for helm OCI registry (argoproj#5978)
9da9514 docs: Add Ant Group to the list of users (argoproj#6011)
5e34a8a add Polarpoint.io (argoproj#6010)
2f92777 chore: move access checks from api server to repo server (argoproj#5940)
ae2d0ff fix(ui): Unscheduled pods in node view are now visible. Fixes argoproj#5981 (argoproj#5988)
b003f70 docs: SealedSecret status missing on k8s 1.16+ (argoproj#5846)
445872f fix: use correct field for evaluating whether or not GitHub Enterprise is selected (argoproj#5987)
9afa833 chore: Make e2e tests runnable against remote cluster (argoproj#5895)
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node view isn't showing pod that can't get into node
2 participants