chore: remove Argo CD CRDs from namespaced install #6022
Conversation
Signed-off-by: Alexander Matyushentsev <[email protected]>
|
We use namespaced bundle to manage multiple Argo CD instances deployed into separate namespaces. Because CRDs are bundled we cannot just reference I think other users have the same use case . @sbose78 , @jannfis what do you think? |
Codecov Report
@@ Coverage Diff @@
## master #6022 +/- ##
=======================================
Coverage 40.93% 40.93%
=======================================
Files 147 147
Lines 19661 19661
=======================================
Hits 8049 8049
Misses 10508 10508
Partials 1104 1104 Continue to review full report at Codecov.
|
manifests/README.md
Outdated
| > Note: Argo CD CRDs are not included into [namespace-install.yaml](namespace-install.yaml) and have to be installed | ||
| > separately. |
There was a problem hiding this comment.
Can we give instructions on how to install the CRDs manually? E.g. where to find them in the code base?
Signed-off-by: Alexander Matyushentsev <[email protected]>
|
Not a big deal, but Argo CD wouldn't be useful without the CRDs :(
So, the admin anyway needs to have permissions to create CRDs at some
point, just that everything else would be namespace scoped :)
Do you foresee someone else creating the CRDs?
…On Tue, Apr 13, 2021, 12:50 Alexander Matyushentsev < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In manifests/README.md
<#6022 (comment)>:
> +> Note: Argo CD CRDs are not included into [namespace-install.yaml](namespace-install.yaml) and have to be installed
+> separately.
good point. added
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6022 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEFEAH52SCRRL5SIOVE3GLTIRY3JANCNFSM422FV6YQ>
.
|
|
@alexmt we should make respective changes in |
Signed-off-by: Alexander Matyushentsev <[email protected]>
|
Thank you @kshamajain99 ! Fixed. |
|
@sbose78, CRDs have to be applied by cluster-admin, not namespace admin. For example, in our case, CRDs and all other cluster-level resources are managed by a platform team. Our team is responsible for managing Argo CD instances (each instance in a separate namespace). If we removing CRD from namespace-install.yaml simplifies the process for us. We can just reference |
5bc7297 fix: bitbucket server failing diagnostics:ping (argoproj#6029) (argoproj#6034) 8f53bd5 fix: add helm dependencies with custom CA (argoproj#6003) 8fd6f13 docs: Custom resource actions (argoproj#5838) 8a2897d docs: update delete policy verbiage (argoproj#6025) c847bd9 chore: remove Argo CD CRDs from namespaced install (argoproj#6022) 61080b3 docs: improve Orphaned Resources Monitoring with more examples and correct grammar (argoproj#6006) 8301d39 Adding explicit bind to redis and sentinel for IPv4 clusters argoproj#5957 (argoproj#6005) 12cabdf fix: adding tests for helm OCI registry (argoproj#5978) 9da9514 docs: Add Ant Group to the list of users (argoproj#6011) 5e34a8a add Polarpoint.io (argoproj#6010) 2f92777 chore: move access checks from api server to repo server (argoproj#5940) ae2d0ff fix(ui): Unscheduled pods in node view are now visible. Fixes argoproj#5981 (argoproj#5988) b003f70 docs: SealedSecret status missing on k8s 1.16+ (argoproj#5846) 445872f fix: use correct field for evaluating whether or not GitHub Enterprise is selected (argoproj#5987) 9afa833 chore: Make e2e tests runnable against remote cluster (argoproj#5895)
* chore: remove Argo CD CRDs from namespaced install Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: Alexander Matyushentsev [email protected]
The namespaced install is used by Argo CD admins who manage multiple Argo CD instances within one namespace. As per description, it does not require any admin permissions. CRDs are cluster lever resources so should be removed from namespaced manifests bundle.