fix: adding tests for helm OCI registry #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: May Zhang <[email protected]>
mayzhang2000
changed the title
mayzhang2000
changed the title
Signed-off-by: May Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #5978 +/- ##
==========================================
- Coverage 40.95% 40.93% -0.03%
==========================================
Files 147 147
Lines 19656 19661 +5
==========================================
- Hits 8051 8049 -2
- Misses 10499 10508 +9
+ Partials 1106 1104 -2
Continue to review full report at Codecov.
|
Signed-off-by: May Zhang <[email protected]>
� Conflicts: � test/e2e/fixture/fixture.go
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
Signed-off-by: May Zhang <[email protected]>
mayzhang2000
changed the title
Signed-off-by: May Zhang <[email protected]>
alexmt
added
the
cherry-pick/2.0
alexmt
approved these changes
Apr 9, 2021
| @@ -76,14 +76,16 @@ func (h *helm) DependencyBuild() error { | |||
| repo := h.repos[i] | |||
| if repo.EnableOci { | |||
| h.cmd.IsHelmOci = true | |||
| _, err := h.cmd.Login(repo.Repo, repo.Creds) | |||
There was a problem hiding this comment.
Nice catch! 👍
We should cherry-pick it into v2.0
yujunz
added a commit
to abcue/argo-cd
that referenced
this pull request
Apr 15, 2021
5bc7297 fix: bitbucket server failing diagnostics:ping (argoproj#6029) (argoproj#6034) 8f53bd5 fix: add helm dependencies with custom CA (argoproj#6003) 8fd6f13 docs: Custom resource actions (argoproj#5838) 8a2897d docs: update delete policy verbiage (argoproj#6025) c847bd9 chore: remove Argo CD CRDs from namespaced install (argoproj#6022) 61080b3 docs: improve Orphaned Resources Monitoring with more examples and correct grammar (argoproj#6006) 8301d39 Adding explicit bind to redis and sentinel for IPv4 clusters argoproj#5957 (argoproj#6005) 12cabdf fix: adding tests for helm OCI registry (argoproj#5978) 9da9514 docs: Add Ant Group to the list of users (argoproj#6011) 5e34a8a add Polarpoint.io (argoproj#6010) 2f92777 chore: move access checks from api server to repo server (argoproj#5940) ae2d0ff fix(ui): Unscheduled pods in node view are now visible. Fixes argoproj#5981 (argoproj#5988) b003f70 docs: SealedSecret status missing on k8s 1.16+ (argoproj#5846) 445872f fix: use correct field for evaluating whether or not GitHub Enterprise is selected (argoproj#5987) 9afa833 chore: Make e2e tests runnable against remote cluster (argoproj#5895)
shubhamagarwal19
pushed a commit
to shubhamagarwal19/argo-cd
that referenced
this pull request
Apr 15, 2021
* initial draft of adding tests for OCI Signed-off-by: May Zhang <[email protected]> * fix: initial draft of adding tests for OCI Signed-off-by: May Zhang <[email protected]> * bring up registry for tests Signed-off-by: May Zhang <[email protected]> * bring up registry for tests Signed-off-by: May Zhang <[email protected]> * bring up registry for tests Signed-off-by: May Zhang <[email protected]> * fix: just to test if PR is working Signed-off-by: May Zhang <[email protected]> * adding additional helm oci dependencies tests Signed-off-by: May Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: May Zhang [email protected]
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
fixes #5918