With bug #1
Open
With bug #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation layer * Revert "Temporarily revert Android commits in order to create a release of Slate focused solely on Android (ianstormtaylor#4256)" This reverts commit 4f50211. * Updates to android composition manager * Add user input tracking It's necessary to only track mutations that result from user input. Some mutations that happen inside block or leaf nodes can happen outside of the render loop of the Editable component.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…taylor#4271) * Fix typo - rename extractMatch to exactMatch * update changelog * update changelog
…oji and blockquote
… void elements in API
* Update error message for useSlate fixes ianstormtaylor#4479 * Add changeset
* fix: check if data-slate-tring node is not null Only reset the focus node of a selection when the node with attribute `data-slate-string` is defined * fix: rewrite logic for checking triple click * Add changeset Co-authored-by: Dylan Schiemann <[email protected]>
* Remove changeset for the fix for regression caused by triple click fix * fix: incorrect Slate range when triple clicking a block (ianstormtaylor#4455)
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <[email protected]>
* add yarn upgrade-interactive plugin * chore(immer): update immer to address security issue * Add changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Attempt fix the release process * unbreak the release process
…aylor#4512) * fix(react-editor): reset focus offset when triple clicking * fix(react editor): remove commented-out code
* add missing changeset * prettier
* correct immutability lockfile flag for yarn 3 * More experiments to re-enable the Version Packages action * add changeset * more work to fix automated changeset workflow
* another attempt to fix the version packages release * more work to fix automated changeset workflow
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…taylor#4523) * Fix setNodes when called with 'split' and a collapsed range * Only bail if it's a non-empty text node * Fix comment
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix - delete selected inline void in chrome * Add changeset * Fix prettier on changeset Co-authored-by: Dylan Schiemann <[email protected]>
…ianstormtaylor#4497) * Updates "Saving to a Database" example to distinguish actual content changes. * Update docs/walkthroughs/06-saving-to-a-database.md * Update docs/walkthroughs/06-saving-to-a-database.md * Update docs/walkthroughs/06-saving-to-a-database.md * Runs prettier Co-authored-by: Dylan Schiemann <[email protected]>
…ylor#4547) In Firefox, `range.cloneContents()` returns an extra trailing '\n', when the document ends with a new-line character. This results in the offset length being off by one, so we need to subtract one to account for this.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Do NOT use exact match when updating dom selection * Added changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of what this pull request solves. (Please do not just link to a long issue thread. Instead include a clear description here or your pull request will likely not be reviewed as quickly.)
Issue
Fixes: (link to issue)
Example
A GIF or video showing the old and new behaviors after this pull request is merged. Or a code sample showing the usage of a new API. (If you don't include this, your pull request will not be reviewed as quickly, because it's much too hard to figure out exactly what is going wrong, and it makes maintenance much harder.)
Context
If your change is non-trivial, please include a description of how the new logic works, and why you decided to solve it the way you did. (This is incredibly helpful so that reviewers don't have to guess your intentions based on the code, and without it your pull request will likely not be reviewed as quickly.)
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)