Code

Merge main to main-vs-deps#60509

Code

Merged

dotnet-bot merged 201 commits intomain-vs-depsdotnet/roslyn:main-vs-depsfrom merges/main-to-main-vs-depsdotnet/roslyn:merges/main-to-main-vs-depsCopy head branch name to clipboardApr 6, 2022

+7,262-7,071

Commits

Commits on Feb 22, 2022

• Add support for yield return to CompleteStatementCommandHandler

  meziantou

  committed
  5b02222

Commits on Mar 16, 2022

• Move more package initialization to BG.

  CyrusNajmabadi

  committed
  494ef04

Commits on Mar 18, 2022

• Merge remote-tracking branch 'upstream/main' into moarBGLoad

  CyrusNajmabadi

  committed
  6f2e870

• Lint

  CyrusNajmabadi

  committed
  22d7247

• More cases

  CyrusNajmabadi

  committed
  306b35d

• Come back to UI thread before calling vs interface

  CyrusNajmabadi

  committed
  235b7f8

• actually initialize

  CyrusNajmabadi

  committed
  cc29255

• front load workspace

  CyrusNajmabadi

  committed
  2d279ef

• REmove arg

  CyrusNajmabadi

  committed
  577a04b

Commits on Mar 19, 2022

• Merge remote-tracking branch 'sharwell/service-extensions' into moarBGLoad

  CyrusNajmabadi

  committed
  c1bb1aa

• Use extension

  CyrusNajmabadi

  committed
  c62d81c

• Use extension

  CyrusNajmabadi

  committed
  db462af

• Use extension

  CyrusNajmabadi

  committed
  d577e8c

• Use extension

  CyrusNajmabadi

  committed
  c11df69

• Use extension

  CyrusNajmabadi

  committed
  8c11d45

• Use extension

  CyrusNajmabadi

  committed
  966d478

Commits on Mar 21, 2022

• Merge remote-tracking branch 'upstream/main' into moarBGLoad

  CyrusNajmabadi

  committed
  cf3167b

• move

  CyrusNajmabadi

  committed
  288d45e

• Add comment

  CyrusNajmabadi

  committed
  067879a

• REvert

  CyrusNajmabadi

  committed
  4f99127

• Cleanup

  CyrusNajmabadi

  committed
  1312d32

• Add comment

  CyrusNajmabadi

  committed
  c00d7f3

• reorder

  CyrusNajmabadi

  committed
  2177897

• reorder

  CyrusNajmabadi

  committed
  7e14340

• Check accessibility before offering "Implement interface" codefix

  DoctorKrolic

  committed
  b69000b

Commits on Mar 22, 2022

• Changed algorithm to not always remove suggestion, moved accessibility check to a separate helper class, added a bunch of tests

  DoctorKrolic

  committed
  6c4f772

Commits on Mar 23, 2022

• Respect C# naming conventions when generating parameter for record

  DoctorKrolic

  committed
  a221b75

• Remove unnecessary switch to UI thread

  CyrusNajmabadi

  committed
  f65727c

• Async load

  CyrusNajmabadi

  committed
  0dd1ded

• do not throw on failure

  CyrusNajmabadi

  committed
  77deef2

• Add throwOnFailure: False

  CyrusNajmabadi

  committed
  ae60cbf

• lint

  CyrusNajmabadi

  committed
  1429147

• Don't eagerly load services

  Show description for ef6f2fd
  jasonmalinowski

  committed
  ef6f2fd

• Cleanup

  CyrusNajmabadi

  committed
  954a6ab

Commits on Mar 24, 2022

• Fix a race condition in IDE diagnostic service for stale diagnostics

  Show description for 8c24309
  mavasani

  committed
  8c24309

• PR feedback

  DoctorKrolic

  committed
  8e5a95e

• Added test for record struct

  DoctorKrolic

  committed
  f4faa3f

Commits on Mar 25, 2022

• Swich off the UI thread when our work doesn't need it anymore

  jasonmalinowski

  committed
  e05579f

• Move IDE0078 codefix to Analyzers

  Youssef1313

  committed
  c15cde5

• PR feedback 2, added generic constraints tests

  DoctorKrolic

  committed
  2af25b6

Commits on Mar 27, 2022

• Do not recommend async if such modifier is already present

  DoctorKrolic

  committed
  f56bf04

Commits on Mar 28, 2022

• Merge remote-tracking branch 'upstream/main' into moarBGLoad

  CyrusNajmabadi

  committed
  23ddb5b

• Merge pull request #60412 from DoctorKrolic/not-recommend-async-if-already-present

  Show description for e721c94
  CyrusNajmabadi

  authored
  e721c94

• Highlight await and return in top-level statements (#60401)

  DoctorKrolic

  authored
  2aed89b

• Merge pull request #60378 from Youssef1313/move-fixer

  Show description for 634c37a
  mavasani

  authored
  634c37a

• Merge remote-tracking branch 'upstream/main' into FixRaceDiagCompute

  mavasani

  committed
  6ca33d1

• Merge pull request #60365 from mavasani/FixRaceDiagCompute

  Show description for 9704fe2
  mavasani

  authored
  9704fe2

• Merge pull request #60211 from CyrusNajmabadi/moarBGLoad

  Show description for d6bdc4a
  CyrusNajmabadi

  authored
  d6bdc4a

• Merge pull request #60351 from jasonmalinowski/speed-up-visualstudioproject-construction

  Show description for 38885db
  jasonmalinowski

  authored
  38885db

• Support adding new assembly level attributes with SyntaxGenerator when some already exist in the document

  Show description for 43c4b1b
  jkoritzinsky

  committed
  43c4b1b

• Merge branch 'dotnet:main' into check-accessibility-in-implement-interface

  DoctorKrolic

  authored
  58284b3

• Don't complete quotes if they complete a valid string (#60227)

  davidwengier

  authored
  a838dcf

• Don't offer to use patterns when they won't work (#60370)

  Show description for dc76348
  

  davidwengier

  and

  Youssef1313

  authored
  dc76348

Commits on Mar 29, 2022

• Add UnsignedRightShift feature to "Language Feature Status.md" (#60435)

  AlekseyTs

  authored
  a1ca907

• [LSP] Remove the majority of usages of client name. (#60357)

  Show description for 0ead73d
  dibarbet

  authored
  0ead73d

• Initial work to move indentation services down to codestyle layer

  CyrusNajmabadi

  committed
  f51f1d9

• Move indentation options down to codestyle layer

  CyrusNajmabadi

  committed
  43eeb3f

• Get C# ISmartTokenFormatter off of HostWorkspaceServices

  CyrusNajmabadi

  committed
  e86cf01

• WIP

  CyrusNajmabadi

  committed
  00b3391

• Fixes

  CyrusNajmabadi

  committed
  649d323

• Merge branch 'indentationDown3' into indentationDown4

  CyrusNajmabadi

  committed
  9d7f791

• Retrieve smart token formatter up front for indenter

  CyrusNajmabadi

  committed
  b65e986

• Fix

  CyrusNajmabadi

  committed
  98360fe

• Merge branch 'indentationDOwn3' into indentationDown4

  CyrusNajmabadi

  committed
  db77c6a

• Merge branch 'indentationDown4' into indentationDown5

  CyrusNajmabadi

  committed
  786d2c8

• Remove dependency on Document in indenter

  CyrusNajmabadi

  committed
  06ede8f

• INline method

  CyrusNajmabadi

  committed
  e87b2e9

• Reference type directly

  CyrusNajmabadi

  committed
  64ffab4

• Don't use document

  CyrusNajmabadi

  committed
  249d758

• Merge branch 'indentationDown5' into indentationDown6

  CyrusNajmabadi

  committed
  f42ca83

• Merge branch 'dotnet:main' into respect-naming-convention-in-records

  DoctorKrolic

  authored
  a70de47

• Merge branch 'dotnet:main' into check-accessibility-in-implement-interface

  DoctorKrolic

  authored
  8f3463f

• Use immutable array

  CyrusNajmabadi

  committed
  e3eedb1

• Move indenter logic down to codestyle

  CyrusNajmabadi

  committed
  fadaa59

• lint

  CyrusNajmabadi

  committed
  56650f0

• Merge branch 'indentationDown3' into indentationDown4

  CyrusNajmabadi

  committed
  abad43d

• Merge branch 'indentationDown4' into indentationDown5

  CyrusNajmabadi

  committed
  2528bad

• Merge branch 'indentationDown5' into indentationDown6

  CyrusNajmabadi

  committed
  bb810a9

• Merge branch 'indentationDown6' into indentationDown7

  CyrusNajmabadi

  committed
  8ea833e

• in progress

  CyrusNajmabadi

  committed
  f44f7eb

• Move indentation service down

  CyrusNajmabadi

  committed
  93f43bf

• Move ConvertNamespace down to the CodeFixes layer

  CyrusNajmabadi

  committed
  d813465

• lint

  CyrusNajmabadi

  committed
  e015add

• Merge branch 'indentationDown6' into indentationDown7

  CyrusNajmabadi

  committed
  cde4150

• Merge branch 'indentationDown7' into indentationDown8

  CyrusNajmabadi

  committed
  de66f91

• Merge branch 'indentationDown8' into indentationDown9

  CyrusNajmabadi

  committed
  7c86415

• Merge pull request #60443 from CyrusNajmabadi/indentationDown5

  Show description for a5bd496
  CyrusNajmabadi

  authored
  a5bd496

• Merge remote-tracking branch 'upstream/main' into indentationDown6

  CyrusNajmabadi

  committed
  b587d50

• Merge branch 'indentationDown6' into indentationDown7

  CyrusNajmabadi

  committed
  7259eda

• Merge branch 'indentationDown7' into indentationDown8

  CyrusNajmabadi

  committed
  3c925e8

• Merge branch 'indentationDown8' into indentationDown9

  CyrusNajmabadi

  committed
  82dd0f2

• Merge branch 'dotnet:main' into check-accessibility-in-implement-interface

  DoctorKrolic

  authored
  0a0fa14

• Merge branch 'dotnet:main' into respect-naming-convention-in-records

  DoctorKrolic

  authored
  bb7950b

• Merge pull request #60448 from CyrusNajmabadi/indentationDown7

  Show description for 62f85a4
  CyrusNajmabadi

  authored
  62f85a4

• Merge remote-tracking branch 'upstream/main' into indentationDown9

  CyrusNajmabadi

  committed
  8ef40a9

• Merge branch 'dotnet:main' into check-accessibility-in-implement-interface

  DoctorKrolic

  authored
  7acbe27

• Merge branch 'dotnet:main' into respect-naming-convention-in-records

  DoctorKrolic

  authored
  80da7f4

• In progress

  CyrusNajmabadi

  committed
  ab87559

• Update Versions.props and PublishData.json for 17.2 P3 snap (#60432)

  allisonchou

  authored
  6027bbf

• Fixes

  CyrusNajmabadi

  committed
  48bff88

• Merge pull request #60425 from jkoritzinsky/syntaxgen-multiple-assembly-attrs

  Show description for 496bf63
  CyrusNajmabadi

  authored
  496bf63

• Fix

  CyrusNajmabadi

  committed
  d8831bf

• move code to workspace layer

  CyrusNajmabadi

  committed
  b1a8854

• move code to workspace layer

  CyrusNajmabadi

  committed
  abee6a9

• move some code to workspace layer

  CyrusNajmabadi

  committed
  e8660e4

• Add comment

  CyrusNajmabadi

  committed
  993642d

• Fix comment

  CyrusNajmabadi

  committed
  bbcf485

• Delete dead code

  CyrusNajmabadi

  committed
  e497e87

• Merge pull request #60338 from DoctorKrolic/respect-naming-convention-in-records

  Show description for f6e3f0c
  CyrusNajmabadi

  authored
  f6e3f0c

• Merge branch 'dotnet:main' into check-accessibility-in-implement-interface

  DoctorKrolic

  authored
  c87e928

• Fix

  CyrusNajmabadi

  committed
  501327b

• Skip flaky integration tests (#60464)

  allisonchou

  authored
  dcfd613

• Fix

  CyrusNajmabadi

  committed
  fa23c03

• Fix

  CyrusNajmabadi

  committed
  2f53fc5

• Merge branch 'indentationDown10' into indentationDown9

  CyrusNajmabadi

  committed
  618402d

• Enable CSharpGoToBase.GoToBaseFromMetadataAsSource

  Show description for 37f946e
  sharwell

  committed
  37f946e

• Update light bulb workaround version

  Show description for 71449b6
  sharwell

  committed
  71449b6

• Handle CompletedWithoutData state for light bulb

  Show description for 462d5ee
  sharwell

  committed
  462d5ee

• fix conflicting diagnostics

  akhera99

  committed
  b31fc30

• update dependency deployment

  jmarolf

  committed
  9854f2d

• Merge pull request #60452 from CyrusNajmabadi/indentationDown9

  Show description for 99876d2
  CyrusNajmabadi

  authored
  99876d2

• add new codefix mappings

  jmarolf

  committed
  f6044c7

• Honour .editorconfig files when formatting new projects (#60450)

  davidwengier

  authored
  6146f0e

Commits on Mar 30, 2022

• Merge pull request #60469 from jmarolf/bugfix/update-dependencies-in-telemetry-generator-tools

  jmarolf

  authored
  998e65d

• Don't add spaces when list pattern is inside parentheses (#60475)

  davidwengier

  authored
  31c6894

• Use provider type name for CodeAction telemetry for code actions created through CodeAction.Create factory methods

  Show description for 41e5886
  mavasani

  committed
  41e5886

• Update dependencies from https://github.com/dotnet/arcade build 20220329.1 (#60481)

  Show description for 1f2d474
  dotnet-maestro[bot]

  authored
  1f2d474

• added named param

  akhera99

  committed
  3d37248

• Merge pull request #60458 from sharwell/enable-test

  Show description for 88d8b63
  sharwell

  authored
  88d8b63

• Merge pull request #60468 from akhera99/bugs/inline_diagnostics_switch_enum

  Show description for 91bd6e5
  akhera99

  authored
  91bd6e5

• Fixed stack overflow issue with generic constraints, pointing to each other

  DoctorKrolic

  committed
  9da0d6e

• Merge branch 'check-accessibility-in-implement-interface' of https://github.com/DoctorKrolic/roslyn into check-accessibility-in-implement-interface

  DoctorKrolic

  committed
  b3b2123

• look for methodkind.local function when checking intent

  akhera99

  committed
  4629694

• Publish blame heap dumps for new integration tests

  sharwell

  committed
  2659333

• test

  akhera99

  committed
  9b6ef24

Commits on Mar 31, 2022

• Enable NRT in AbstractSyncNamespaceCodeRefactoringProvider

  genlu

  committed
  84c0f52

• Update Spanish queue to Windows.10.Amd64.Server2022.ES.Open

  sharwell

  committed
  7999960

• Fix test and review feedback

  mavasani

  committed
  c050af9

• Merge pull request #60506 from sharwell/update-queue

  Show description for f9f190c
  JoeRobich

  authored
  f9f190c

• Merge branch 'dotnet:main' into check-accessibility-in-implement-interface

  DoctorKrolic

  authored
  17550b5

• Merge pull request #60486 from akhera99/bugs/60145_inline_hints

  Show description for 3ae1d57
  akhera99

  authored
  3ae1d57

• PR feedback

  DoctorKrolic

  committed
  f5b5f0b

• Merge branch 'check-accessibility-in-implement-interface' of https://github.com/DoctorKrolic/roslyn into check-accessibility-in-implement-interface

  DoctorKrolic

  committed
  f0f5c79

• Merge pull request #60487 from sharwell/copy-diags

  Show description for d2f4b6a
  sharwell

  authored
  d2f4b6a

• Move StackTraceAnalyzer over to VirtualCharSequence (#60404)

  Show description for 71dfd27
  ryzngard

  authored
  71dfd27

• Add an aggregate logger for inheritance margin (#60493)

  Show description for 3999961
  Cosifne

  authored
  3999961

• Merge remote-tracking branch 'origin/main' into merges/main-to-main-vs-deps

  JoeRobich

  committed
  89b1bd9

• Add BoundArrayInitialization.IsInferred (#60391)

  jcouv

  authored
  764dcd0

• Document ROSLYN_TEST_USEDASSEMBLIES (#60478)

  jcouv

  authored
  6888cd6

Commits on Apr 1, 2022

• Merge branch 'main-vs-deps' into merges/main-to-main-vs-deps

  JoeRobich

  authored
  ac80b0f

• Merge pull request #60492 from genlu/NRTSyncNamespace

  Show description for 65942dc
  genlu

  authored
  65942dc

• Fix merge

  dibarbet

  committed
  2feed25

• Use isInferred: false when creating BoundArrayInitialization in CreateUTF8ByteRepresentation

  JoeRobich

  committed
  23f2062

• Update Language Feature Status.md (#60482)

  jaredpar

  authored
  4f4fe66

• Move few 'CodeFixProvider's to Analyzers layer

  Youssef1313

  committed
  087bc2c

• Merge remote-tracking branch 'origin/main' into merges/main-to-main-vs-deps

  JoeRobich

  committed
  9d7c980

Commits on Apr 2, 2022

• Merge pull request #60297 from DoctorKrolic/check-accessibility-in-implement-interface

  Show description for 34b0206
  CyrusNajmabadi

  authored
  34b0206

• Revert bad changes

  Youssef1313

  committed
  82f75a5

• Fix errors and remove a hard CodeFixProvider back to Features

  Youssef1313

  committed
  9a7897a

• Update projitems

  Youssef1313

  committed
  f82a7a1

• Move tests

  Youssef1313

  committed
  baa1cd7

• Remove unused abstract property

  Youssef1313

  committed
  0f38b29

• Remove the single unused read of CodeFixCategory

  Youssef1313

  committed
  ea43db0

• Remove overrides in Analyzers

  Youssef1313

  committed
  0f3ebc7

• Remove overrides in Features

  Youssef1313

  committed
  6609890

• Remove unnecessary <Compile Remove

  Youssef1313

  authored
  4bc2a21

Commits on Apr 4, 2022

• Merge pull request #60536 from Youssef1313/remove-fix-category

  Show description for 30ed50e
  mavasani

  authored
  30ed50e

• Merge remote-tracking branch 'upstream/main' into CodeActionTelemetry

  mavasani

  committed
  764a9ac

• Merge branch 'main' into move-some-fixes

  Youssef1313

  committed
  6db1fc1

• Address review comment

  Youssef1313

  committed
  ca0c17c

• Cleanup unused resources in Features layer

  Youssef1313

  committed
  42f00f1

• Merge pull request #60480 from mavasani/CodeActionTelemetry

  Show description for 6039b44
  mavasani

  authored
  6039b44

• Update Roslyn.Diagnostics.Analyzers and remove RS0005 suppressions

  Youssef1313

  committed
  89a0b8f

• Remove some 'MyCodeAction's

  Youssef1313

  committed
  2c50666

• Remove more 'MyCodeAction's

  Youssef1313

  committed
  93650e6

• One more that's not named MyCodeAction

  Youssef1313

  committed
  e2acea2

• Merge pull request #60554 from Youssef1313/delete-unused-resources

  Show description for bd096ed
  JoeRobich

  authored
  bd096ed

• Merge remote-tracking branch 'origin/main-vs-deps' into merges/main-to-main-vs-deps

  JoeRobich

  committed
  cdfbdfb

• Merge remote-tracking branch 'origin/main' into merges/main-to-main-vs-deps

  JoeRobich

  committed
  13d7cb2

• Fix up changes between main and main-vs-deps

  JoeRobich

  committed
  6413f9e

• Merge pull request #60556 from Youssef1313/roslyn-diag-analyzers-update

  Show description for 2624306
  mavasani

  authored
  2624306

• Merge pull request #60538 from Youssef1313/patch-20

  Show description for edd0d45
  jasonmalinowski

  authored
  edd0d45

• Few fixes

  Youssef1313

  committed
  1880e6d

• Note auto-default merged in feature status doc (#60564)

  RikkiGibson

  authored
  8f949c9

• Update PublishData.json for 17.3 P1 (#60559)

  allisonchou

  authored
  2e96927

• Fix formatting

  Youssef1313

  authored
  c8876af

• Add Rebuild badge to README (#60298)

  RikkiGibson

  authored
  6b1593b

• Avoid using --blame-crash with CollectDumps

  Show description for b7b37c3
  sharwell

  committed
  b7b37c3

• Merge pull request #60561 from sharwell/no-blame-crash

  Show description for 318d44c
  sharwell

  authored
  318d44c

Commits on Apr 5, 2022

• Fix the Compiler VSIX extension so it works with CPS projects again

  Show description for bb33e53
  jasonmalinowski

  committed
  bb33e53

• Merge pull request #60557 from Youssef1313/remove-my-code-actions

  Show description for b51d065
  mavasani

  authored
  b51d065

• Make NotificationOption2 a serializable struct (#60573)

  tmat

  authored
  90112dd

• Merge remote-tracking branch 'upstream/main' into move-some-fixes

  Youssef1313

  committed
  97ba8a2

• Merge pull request #60580 from jasonmalinowski/fix-compilerextension

  Show description for 8c08dcb
  jasonmalinowski

  authored
  8c08dcb

• Update status for UTF8 literals and checked operators (#60587)

  jcouv

  authored
  74912d4

• Merge pull request #59683 from meziantou/issues/54709

  Show description for f3d2ec1
  CyrusNajmabadi

  authored
  f3d2ec1

• Workspace config options (#59790)

  tmat

  authored
  b999a65

• Merge pull request #60524 from Youssef1313/move-some-fixes

  Show description for 60a165c
  mavasani

  authored
  60a165c

• Merge remote-tracking branch 'origin/main' into merges/main-to-main-vs-deps

  JoeRobich

  committed
  e6fa932

Commits on Apr 6, 2022

• Fix merge from main

  JoeRobich

  committed
  02a7f02

• Do not assert we are on the main thread in the constructor

  dibarbet

  committed
  1160a11