Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1743: Add VMGroup to VSphere Provider workspace #2074

Merged
merged 1 commit into from
Nov 26, 2024
Merged

SPLAT-1743: Add VMGroup to VSphere Provider workspace #2074

merged 1 commit into from
Nov 26, 2024

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Oct 22, 2024 •
edited
Loading

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 22, 2024

Hello @jcpowermac! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 22, 2024
@openshift-ci openshift-ci bot requested review from deads2k and mandre October 22, 2024 19:14
@jcpowermac jcpowermac changed the title Add VMGroup to VSphere Provider workspace SPLAT-1743: Add VMGroup to VSphere Provider workspace Oct 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

For the machine api operator to support
vm-host based zonal a single new field of
vmGroup needs to be added that will indicate
the vCenter cluster group to add a newly created
virtual machine into.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 22, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Changes

For the machine api operator to support
vm-host based zonal a single new field of
vmGroup needs to be added that will indicate
the vCenter cluster group to add a newly created
virtual machine into.

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac jcpowermac mentioned this pull request Oct 22, 2024
Open
@jcpowermac
Copy link
Contributor Author

/assign @JoelSpeed

@jcpowermac jcpowermac force-pushed the vsphere-machine-add-vmgroup-workspace branch from fcf94c8 to f8d9434 Compare November 11, 2024 18:39
This was referenced Nov 13, 2024
Open
Merged
@jcpowermac
Add VMGroup to VSphere Provider workspace
6398ee4 
For the machine api operator to support
vm-host based zonal a single new field of
`vmGroup` needs to be added that will indicate
the vCenter cluster group to add a newly created
virtual machine into.
@jcpowermac jcpowermac force-pushed the vsphere-machine-add-vmgroup-workspace branch from f8d9434 to 6398ee4 Compare November 21, 2024 15:18
@jcpowermac
Copy link
Contributor Author

@JoelSpeed updated

JoelSpeed
JoelSpeed reviewed Nov 21, 2024
View reviewed changes
machine/v1beta1/types_vsphereprovider.go
@@ -190,6 +190,10 @@ type Workspace struct {
// ResourcePool is the resource pool in which VMs are created/located.
// +optional
ResourcePool string `gcfg:"resourcepool-path,omitempty" json:"resourcePool,omitempty"`
// vmGroup is the cluster vm group in which virtual machines will be added for vm host group based zonal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the failure domains API, we limit this field to 80 characters IIRC, is that also being implemented in the MAPI validation webhook?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 21, 2024

@jcpowermac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6398ee4 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 98fc036 into openshift:master Nov 26, 2024
10 of 11 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202411262308.p0.g98fc036.assembly.stream.el9.
All builds following this will include this PR.

@jcpowermac jcpowermac mentioned this pull request Dec 2, 2024
Merged
@chiragkyal chiragkyal mentioned this pull request Dec 3, 2024
Merged
@jcpowermac jcpowermac mentioned this pull request Dec 3, 2024
Merged
@jcpowermac jcpowermac mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@deads2k deads2k deads2k left review comments

@mandre mandre Awaiting requested review from mandre

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcpowermac @openshift-ci-robot @JoelSpeed @openshift-bot @deads2k