Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1742: vSphere - enable host group based zonal #8873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SPLAT-1742: vSphere - enable host group based zonal #8873

wants to merge 1 commit into from
+4,156 −1,728

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Aug 19, 2024 •
edited
Loading

Changes

  • Migrated to https://github.com/uber-go/mock
  • Updated validations to include vm-host group of type Host and tagging. Also associated tests.
  • Create capv FailureDomain and DeploymentZone
  • Delete vm-host group of type VirtualMachine and vm-host rule created by installer
  • Create an associated vm-host group of type virtual machine and a affinity vm-host rule.
  • Update platform spec topology to include hostGroup which needs to be created day 0, prior to installation.

Additional PRs

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 19, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1742 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jcpowermac
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 19, 2024

@jcpowermac: The following commands are available to trigger required jobs:

  • /test altinfra-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-edge-zones-manifest-validation
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-ovn-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test integration-tests
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test terraform-images
  • /test terraform-verify-vendor
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-custom-security-groups
  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-fips
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-proxy
  • /test altinfra-e2e-aws-ovn-public-ipv4-pool
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-local-zones
  • /test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones
  • /test altinfra-e2e-aws-ovn-single-node
  • /test altinfra-e2e-aws-ovn-wavelengthzones
  • /test altinfra-e2e-azure-capi-ovn
  • /test altinfra-e2e-azure-ovn-shared-vpc
  • /test altinfra-e2e-gcp-capi-ovn
  • /test altinfra-e2e-gcp-ovn-byo-network-capi
  • /test altinfra-e2e-gcp-ovn-secureboot-capi
  • /test altinfra-e2e-gcp-ovn-xpn-capi
  • /test altinfra-e2e-ibmcloud-capi-ovn
  • /test altinfra-e2e-nutanix-capi-ovn
  • /test altinfra-e2e-openstack-capi-ccpmso
  • /test altinfra-e2e-openstack-capi-ccpmso-zone
  • /test altinfra-e2e-openstack-capi-dualstack
  • /test altinfra-e2e-openstack-capi-dualstack-upi
  • /test altinfra-e2e-openstack-capi-dualstack-v6primary
  • /test altinfra-e2e-openstack-capi-externallb
  • /test altinfra-e2e-openstack-capi-nfv-intel
  • /test altinfra-e2e-openstack-capi-ovn
  • /test altinfra-e2e-openstack-capi-proxy
  • /test altinfra-e2e-vsphere-capi-multi-vcenter-ovn
  • /test altinfra-e2e-vsphere-capi-ovn
  • /test altinfra-e2e-vsphere-capi-static-ovn
  • /test altinfra-e2e-vsphere-capi-zones
  • /test azure-ovn-marketplace-images
  • /test e2e-agent-compact-ipv4-add-nodes
  • /test e2e-agent-compact-ipv4-appliance-diskimage
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-aws-overlay-mtu-ovn-1200
  • /test e2e-aws-ovn-custom-iam-profile
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-heterogeneous
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc-custom-security-groups
  • /test e2e-aws-ovn-shared-vpc-edge-zones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-techpreview
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azure-ovn-techpreview
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-external-aws
  • /test e2e-external-aws-ccm
  • /test e2e-gcp-ovn-byo-vpc
  • /test e2e-gcp-ovn-heterogeneous
  • /test e2e-gcp-ovn-techpreview
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-swapped-hosts
  • /test e2e-metal-ipi-ovn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack
  • /test e2e-openstack-dualstack-upi
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-powervs-capi-ovn
  • /test e2e-vsphere-multi-vcenter-ovn
  • /test e2e-vsphere-ovn-techpreview
  • /test e2e-vsphere-ovn-upi-zones
  • /test e2e-vsphere-ovn-zones
  • /test e2e-vsphere-ovn-zones-techpreview
  • /test e2e-vsphere-static-ovn
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-ha-dualstack
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-images
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn-techpreview
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn-zones
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn-zones-techpreview
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Contributor Author

/test gofmt
/test golint
/test govet
/test unit

@jcpowermac
Copy link
Contributor Author

/test images

@jcpowermac jcpowermac force-pushed the SPLAT-1742 branch 2 times, most recently from 9818585 to ff2a1da Compare September 3, 2024 20:56
This was referenced Sep 23, 2024
Merged
Open
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@jcpowermac jcpowermac force-pushed the SPLAT-1742 branch 7 times, most recently from 4f1a731 to 13d5505 Compare October 3, 2024 16:39
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@jcpowermac jcpowermac force-pushed the SPLAT-1742 branch 2 times, most recently from 2ce9465 to fe4106b Compare October 4, 2024 13:36
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 4, 2024
@jcpowermac
Copy link
Contributor Author

/test gofmt
/test golint
/test govet
/test unit

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 18, 2024
@jcpowermac
Copy link
Contributor Author

/retest-required

@jcpowermac
Copy link
Contributor Author

/retest

1 similar comment
@jcpowermac
Copy link
Contributor Author

/retest

@jcpowermac
Copy link
Contributor Author

/test e2e-vsphere-ovn

2 similar comments
@jcpowermac
Copy link
Contributor Author

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

/test e2e-vsphere-ovn

@jcpowermac
Copy link
Contributor Author

/test e2e-vsphere-ovn-techpreview

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@jcpowermac
Copy link
Contributor Author

/hold cancel

I tested techpreviewnoupgrade locally no issues

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2025
@patrickdillon
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 334309f and 2 for PR HEAD 1fc0ee4 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2025
@vr4manta
Copy link
Contributor

vr4manta commented Jan 8, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2025
@jcpowermac jcpowermac mentioned this pull request Jan 8, 2025
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 8, 2025

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upi c285d3d link true /test e2e-azure-ovn-upi
ci/prow/e2e-azure-ovn-resourcegroup 52cb95f link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-gcp-ovn-byo-vpc 52cb95f link false /test e2e-gcp-ovn-byo-vpc
ci/prow/e2e-openstack-ovn 52cb95f link true /test e2e-openstack-ovn
ci/prow/e2e-openstack-proxy 52cb95f link false /test e2e-openstack-proxy
ci/prow/e2e-vsphere-ovn-zones-techpreview 52cb95f link false /test e2e-vsphere-ovn-zones-techpreview
ci/prow/e2e-vsphere-ovn-techpreview 52cb95f link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-vsphere-static-ovn 52cb95f link false /test e2e-vsphere-static-ovn
ci/prow/e2e-vsphere-multi-vcenter-ovn 52cb95f link false /test e2e-vsphere-multi-vcenter-ovn
ci/prow/e2e-gcp-ovn-xpn 52cb95f link false /test e2e-gcp-ovn-xpn
ci/prow/e2e-gcp-secureboot 52cb95f link false /test e2e-gcp-secureboot
ci/prow/e2e-azurestack 52cb95f link false /test e2e-azurestack
ci/prow/e2e-vsphere-ovn-multi-network 52cb95f link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-gcp-default-config 52cb95f link false /test e2e-gcp-default-config
ci/prow/e2e-gcp-ovn 52cb95f link true /test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn 52cb95f link true /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor Author

/hold

all vsphere jobs are doing the same thing, they never delete the storage policy, tag or tag category. This needs more investigation

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phaow Phaow Phaow left review comments

@gnufied gnufied gnufied left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@pawanpinjarkar pawanpinjarkar Awaiting requested review from pawanpinjarkar

Assignees

@vr4manta vr4manta

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jcpowermac @openshift-ci-robot @gnufied @rvanderp3 @patrickdillon @vr4manta @Phaow @openshift-merge-robot