Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1780: api bump for host zonal infra change #1782

Merged
merged 1 commit into from
Dec 10, 2024
Merged

SPLAT-1780: api bump for host zonal infra change #1782

merged 1 commit into from
Dec 10, 2024

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Aug 28, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 28, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@openshift-ci openshift-ci bot requested review from bertinatto and soltysh August 28, 2024 12:37
@jcpowermac jcpowermac force-pushed the host-zonal-bump branch 3 times, most recently from 344adc0 to 466afdc Compare September 16, 2024 18:09
This was referenced Sep 23, 2024
Merged
Open
@jcpowermac jcpowermac force-pushed the host-zonal-bump branch 4 times, most recently from 3e8f611 to 31bed7d Compare October 2, 2024 13:17
This was referenced Oct 22, 2024
Merged
Open
@jcpowermac jcpowermac force-pushed the host-zonal-bump branch 4 times, most recently from 6d9725f to 0f0d5ca Compare October 31, 2024 14:17
This was referenced Nov 13, 2024
Open
Merged
@jcpowermac jcpowermac mentioned this pull request Dec 2, 2024
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 3, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Changes

  • API bump for vm host zone infrastructure changes

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2024
@jcpowermac jcpowermac changed the title WIP - SPLAT-1780: api bump for host zonal infra change SPLAT-1780: api bump for host zonal infra change Dec 3, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2024
@vr4manta
Copy link

vr4manta commented Dec 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@jcpowermac
Copy link
Contributor Author

/assign @p0lyn0mial

@jcpowermac
Copy link
Contributor Author

/assign @bertinatto

@p0lyn0mial
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, p0lyn0mial, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8d0b2ce into openshift:master Dec 10, 2024
4 checks passed
@jcpowermac jcpowermac mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@bertinatto bertinatto

@p0lyn0mial p0lyn0mial

@vr4manta vr4manta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcpowermac @openshift-ci-robot @vr4manta @p0lyn0mial @bertinatto @openshift-merge-robot