Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1799: Add support for vSphere host and vm group based zonal #325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

SPLAT-1799: Add support for vSphere host and vm group based zonal #325

wants to merge 2 commits into from

Conversation

jcpowermac
Copy link

@jcpowermac jcpowermac commented Sep 9, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jcpowermac
Copy link
Author

/test ?

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

@jcpowermac: The following commands are available to trigger required jobs:

  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-upgrade
  • /test fmt
  • /test generate
  • /test images
  • /test lint
  • /test security
  • /test unit
  • /test vendor
  • /test vet

The following commands are available to trigger optional jobs:

  • /test e2e-aws-periodic-pre
  • /test e2e-azure-operator
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-azure-periodic-pre
  • /test e2e-gcp-operator
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-periodic-pre
  • /test e2e-nutanix-ovn
  • /test e2e-openstack-operator
  • /test e2e-openstack-operator-zone
  • /test e2e-vsphere-multi-zone-operator
  • /test e2e-vsphere-operator
  • /test e2e-vsphere-ovn-etcd-scaling
  • /test okd-scos-images
  • /test regression-clusterinfra-aws-ipi-cpms-allcases

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-operator
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-etcd-scaling
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-aws-ovn-upgrade
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-azure-operator
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-azure-ovn-etcd-scaling
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-gcp-operator
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-gcp-ovn-etcd-scaling
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-nutanix-ovn
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-openstack-operator
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-openstack-operator-zone
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-vsphere-multi-zone-operator
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-vsphere-operator
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-e2e-vsphere-ovn-etcd-scaling
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-fmt
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-generate
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-images
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-lint
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-regression-clusterinfra-aws-ipi-cpms-allcases
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-security
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-unit
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-vendor
  • pull-ci-openshift-cluster-control-plane-machine-set-operator-main-vet

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Author

/test fmt
/test generate
/test images
/test lint
/test security
/test unit
/test vendor
/test vet

@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 3 times, most recently from b30d2ef to 08ed3d2 Compare September 12, 2024 20:19
@jcpowermac
Copy link
Author

/test fmt
/test generate
/test images
/test lint
/test security
/test unit
/test vendor
/test vet

@jcpowermac jcpowermac changed the title Add support for vSphere host and vm group based zonal SPLAT-1799: Add support for vSphere host and vm group based zonal Sep 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1799 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Sep 23, 2024
Merged
Open
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 27, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2024
@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 3 times, most recently from 324f4df to 32ff986 Compare October 2, 2024 14:20
@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from d19e25c to c35d0fa Compare October 12, 2024 15:00
This was referenced Oct 22, 2024
Merged
Open
@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from 37a140b to 45761cd Compare October 31, 2024 14:19
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2024
This was referenced Dec 2, 2024
Merged
Merged
Merged
@jcpowermac
Copy link
Author

/test fmt
/test generate
/test images
/test lint
/test security
/test unit
/test vendor
/test vet

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcpowermac
vendor
82369ad
@jcpowermac
Changes to support vm-host group and api bump
c354006 
- Modified events.NewLoggingEventRecorder adding clock.RealClock{} param
- Add checks for failureDomain hostgroup vmgroup fields
- Add checks for machine workspace vmgroup fields
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 12, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1799 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Changes

  • Modified events.NewLoggingEventRecorder adding clock.RealClock{} param
  • Add checks for failureDomain hostgroup vmgroup fields
  • Add checks for machine workspace vmgroup fields

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac jcpowermac marked this pull request as ready for review December 12, 2024 20:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2024
@jcpowermac
Copy link
Author

/retest

1 similar comment
@jcpowermac
Copy link
Author

/retest

@jcpowermac
Copy link
Author

/retest-required

@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@jcpowermac
Copy link
Author

/assign @RadekManak

@jcpowermac
Copy link
Author

/retest-required

1 similar comment
@jcpowermac
Copy link
Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025 •
edited
Loading

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-etcd-scaling c354006 link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling c354006 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-gcp-operator c354006 link false /test e2e-gcp-operator
ci/prow/regression-clusterinfra-aws-ipi-cpms-allcases c354006 link false /test regression-clusterinfra-aws-ipi-cpms-allcases
ci/prow/okd-scos-e2e-aws-ovn c354006 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-etcd-scaling c354006 link false /test e2e-azure-ovn-etcd-scaling

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Author

/test e2e-aws-ovn-etcd-scaling

@elmiko
Copy link
Contributor

elmiko commented Jan 7, 2025

changes lgtm, just a quick question about testing. do we exercise this functionality in e2e's or anything? just curious if we should have unit test.

@jcpowermac
Copy link
Author

changes lgtm, just a quick question about testing. do we exercise this functionality in e2e's or anything? just curious if we should have unit test.

Thanks @elmiko it looks like I missed some potential unit tests I could add.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadekManak RadekManak Awaiting requested review from RadekManak

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@RadekManak RadekManak

@rvanderp3 rvanderp3

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jcpowermac @openshift-ci-robot @rvanderp3 @elmiko @RadekManak