Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1800: Add support for vSphere host and vm group based zonal #1285

Merged
merged 3 commits into from
Dec 18, 2024
Merged

SPLAT-1800: Add support for vSphere host and vm group based zonal #1285

merged 3 commits into from
Dec 18, 2024

Conversation

jcpowermac
Copy link
Contributor

@jcpowermac jcpowermac commented Sep 9, 2024 •
edited
Loading

Changes

Misc required change:

  • Added RealClock to NewKubeRecorder and NewLoggingEventRecorder

Changes:

  • Added FeatureGateVSphereHostVMGroupZonal
  • Added modifyVMGroup which adds or removes a virtual machine from
    the vCenter cluster's vm-host group associated with the failure domain
  • Added validation for the length of a vm-group name
  • Added vm-host group tests

Additional PRs

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 9, 2024
@jcpowermac jcpowermac changed the title Hostvmgroupzones Add support for vSphere host and vm group based zonal Sep 9, 2024
@jcpowermac
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2024

@jcpowermac: The following commands are available to trigger required jobs:

  • /test e2e-aws-operator
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test goimports
  • /test golint
  • /test govet
  • /test images
  • /test unit
  • /test verify-crds-sync
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-azure-manual-oidc
  • /test e2e-azure-operator
  • /test e2e-azure-ovn
  • /test e2e-gcp-operator
  • /test e2e-gcp-ovn
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-upgrade
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-nutanix
  • /test e2e-openstack
  • /test e2e-vsphere-operator
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-ovn-serial
  • /test e2e-vsphere-ovn-upgrade
  • /test e2e-vsphere-static-ovn
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-api-operator-master-e2e-aws-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-aws-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-machine-api-operator-master-e2e-azure-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-azure-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-gcp-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-ovn-dualstack
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-upgrade
  • pull-ci-openshift-machine-api-operator-master-e2e-metal-ipi-virtualmedia
  • pull-ci-openshift-machine-api-operator-master-e2e-nutanix
  • pull-ci-openshift-machine-api-operator-master-e2e-openstack
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-operator
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-ovn
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-ovn-serial
  • pull-ci-openshift-machine-api-operator-master-e2e-vsphere-ovn-upgrade
  • pull-ci-openshift-machine-api-operator-master-goimports
  • pull-ci-openshift-machine-api-operator-master-golint
  • pull-ci-openshift-machine-api-operator-master-govet
  • pull-ci-openshift-machine-api-operator-master-images
  • pull-ci-openshift-machine-api-operator-master-unit
  • pull-ci-openshift-machine-api-operator-master-verify-crds-sync
  • pull-ci-openshift-machine-api-operator-master-yaml-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@jcpowermac
Copy link
Contributor Author

/test goimports
/test golint
/test govet
/test images
/test unit
/test verify-crds-sync
/test yaml-lint

@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from d098ada to 188cb86 Compare September 11, 2024 12:58
@jcpowermac jcpowermac changed the title Add support for vSphere host and vm group based zonal SPLAT-1800: Add support for vSphere host and vm group based zonal Sep 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 12, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 12, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from 1ae6b9b to b856851 Compare September 16, 2024 18:21
This was referenced Sep 23, 2024
Merged
Open
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 3 times, most recently from bf7b850 to 4a4d0f3 Compare October 2, 2024 13:18
This was referenced Oct 22, 2024
Merged
Open
@jcpowermac jcpowermac marked this pull request as ready for review December 10, 2024 15:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2024
JoelSpeed
JoelSpeed reviewed Dec 10, 2024
View reviewed changes
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
@jcpowermac jcpowermac force-pushed the hostvmgroupzones branch 2 times, most recently from a9f4094 to 4e9d690 Compare December 11, 2024 13:08
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2024 •
edited by openshift-ci bot
Loading

@jcpowermac: This pull request references SPLAT-1800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Changes

Misc required change:

  • Added RealClock to NewKubeRecorder and NewLoggingEventRecorder

Changes:

  • Added FeatureGateVSphereHostVMGroupZonal
  • Added modifyVMGroup which adds or removes a virtual machine from
    the vCenter cluster's vm-host group associated with the failure domain
  • Added validation for the length of a vm-group name
  • Added vm-host group tests

Additional PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

JoelSpeed
JoelSpeed reviewed Dec 13, 2024
View reviewed changes
pkg/webhooks/machine_webhook.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
pkg/controller/vsphere/reconciler.go Outdated Show resolved Hide resolved
@jcpowermac
Copy link
Contributor Author

/hold

see a test problem

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@jcpowermac
Add vSphere vm-host group zonal
9b838c3 
This PR adds vm-host group zonal feature to MAO.

Misc required change:
- Added RealClock to NewKubeRecorder and NewLoggingEventRecorder

Changes:
- Added FeatureGateVSphereHostVMGroupZonal
- Added modifyVMGroup which adds or removes a virtual machine from
the vCenter cluster's vm-host group associated with the failure domain
- Added validation for the length of a vm-group name
- Added vm-host group tests
@jcpowermac
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2024
@jcpowermac
Copy link
Contributor Author

/retest

@jcpowermac
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator 9b838c3 link false /test e2e-azure-operator
ci/prow/e2e-azure-ovn 9b838c3 link false /test e2e-azure-ovn
ci/prow/okd-scos-e2e-aws-ovn 9b838c3 link false /test okd-scos-e2e-aws-ovn
ci/prow/regression-clusterinfra-aws-ipi-mapi 9b838c3 link false /test regression-clusterinfra-aws-ipi-mapi
ci/prow/e2e-nutanix 9b838c3 link false /test e2e-nutanix

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

JoelSpeed
JoelSpeed reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ea1636d into openshift:master Dec 18, 2024
23 of 30 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.19.0-202412181837.p0.gea1636d.assembly.stream.el9.
All builds following this will include this PR.

@jcpowermac jcpowermac mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vr4manta vr4manta vr4manta left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@JoelSpeed JoelSpeed

@vr4manta vr4manta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jcpowermac @openshift-ci-robot @vr4manta @openshift-bot @JoelSpeed @openshift-merge-robot