Pjlast/sourcegraph cody support #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For zed-industries#9401 --------- Co-authored-by: Joseph T. Lyons <[email protected]>
TL;DR: - shaves off about 0.5 seconds from most of our debug builds. - It would've slightly regressed release build due to preventing build pipelining, but as a tradeoff I've bumped up codegen-units for zed. \# What did you come up with this time Piotr In our zed repository I've noticed that merely *loading dependencies* in each crate takes non-trivial amount of time (~800ms in case of editor). That is to say, the moment you \`use editor\`, your build time increases by 800ms - this happens just once in crate though, as it looks like compiler has to load .rlibs of all of the referenced dependencies. This is visible under rustc's self-profile. Repro steps on twitter: https://twitter.com/PiotrOsiewicz/status/1762845413072101567 \# How does this commit alleviate this? zed lib + zed bin are on critical path of every build and cumulatively take about 3s to build. This commit bundles all of this up into ~2.2s of bin build time instead. \# Wait, splitting binary targets is good, no? Splitting up a binary target into lib + bin is generally considered to be a good practice, as you can then reuse the lib part elsewhere if needed. It also allows the build to kick off the moment metadata for all of the dependencies is available (thus, you don't need to wait for codegen). However, we do not really use zed as a lib, so the first benefit is not really a thing for us. The latter *is* indeed something we lose out on in release mode (in dev codegen phase of leaf-ish crates is insignificant, as we use shared generics - thus we don't spend much time codegening). That's why I've bumped codegen units for zed crate to 16 in release mode to keep build times in tact.
Removes some redundant dependency defenitions and updates one dependency.
Release Notes: - Improved Ruby language to recognize Guardfile.
…-industries#9523) This will be used in the [extensions](https://github.com/zed-industries/extensions) repository for packaging the extensions that users submit. Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <[email protected]>
`HANDLE` is wrapped in a RAII struct. Release Notes: - N/A Co-authored-by: Mikayla Maki <[email protected]>
…#9443) I mainly focused on improving the `font_id` function, see the description of e286483 for more details. The rest are some drive-by changes I could not resist to. When I am right about af4d6c4, someone with a Mac could change it there as well. This PR is probably best reviewed commit by commit :) cc @gabydd @h3mosphere Release Notes: - N/A --------- Signed-off-by: Niklas Wimmer <[email protected]>
Follow-up from zed-industries#9138 Release Notes: - Adds suggested extensions for some filetypes ([zed-industries#7096](zed-industries#7096)). --------- Co-authored-by: Felix Zeller <[email protected]>
This PR updates the binary name used by the extension CLI from `extension_cli` to `zed-extension`. Release Notes: - N/A
This builds on zed-industries#9353 by adding an image viewer to Zed. Closes zed-industries#5251. Release Notes: - Added support for rendering image files ([zed-industries#5251](zed-industries#5251)). <img width="1840" alt="image" src="https://github.com/zed-industries/zed/assets/836375/3bccfa8e-aa5c-421f-9dfa-671caa274c3c"> --------- Co-authored-by: Mikayla Maki <[email protected]>
Spinner go spinny. Extra thanks to @kvark for helping me with the shaders. https://github.com/zed-industries/zed/assets/2280405/9d5f4f4e-0d43-44d2-a089-5d69939938e9 Release Notes: - Added a spinning animation to the LSP checking indicator --------- Co-authored-by: Dzmitry Malyshau <[email protected]>
the space key was being reported as key " " which didn't allow it to be used in keybindings Release Notes: - N/A
Release Notes: - Fixed a bug that would cause certain tooltips to not show up (preview-only).
This PR adds a GitHub Action for publishing the extension CLI. When the `extension-cli` tag is pushed, this Action will run, build the `zed-extension` binary, and upload it to DigitalOcean for consumption. This will allow us to consume the pre-built binary in the CI for the extensions repo. Release Notes: - N/A --------- Co-authored-by: Max <[email protected]>
… need an API key (zed-industries#7367) Co-authored-by: Antonio <[email protected]> Resurrected this from some assistant work I did in Spring of 2023. - [x] Resurrect streaming responses - [x] Use streaming responses to enable AI via Zed's servers by default (but preserve API key option for now) - [x] Simplify protobuf - [x] Proxy to OpenAI on zed.dev - [x] Proxy to Gemini on zed.dev - [x] Improve UX for switching between openAI and google models - We current disallow cycling when setting a custom model, but we need a better solution to keep OpenAI models available while testing the google ones - [x] Show remaining tokens correctly for Google models - [x] Remove semantic index - [x] Delete `ai` crate - [x] Cloud front so we can ban abuse - [x] Rate-limiting - [x] Fix panic when using inline assistant - [x] Double check the upgraded `AssistantSettings` are backwards-compatible - [x] Add hosted LLM interaction behind a `language-models` feature flag. Release Notes: - We are temporarily removing the semantic index in order to redesign it from scratch. --------- Co-authored-by: Antonio <[email protected]> Co-authored-by: Antonio Scandurra <[email protected]> Co-authored-by: Thorsten <[email protected]> Co-authored-by: Max <[email protected]>
) zed-industries#9103 broke touchpad scrolling on Wayland This PR correctly filters the `Axis` to handle all non-discrete scroll events (see https://wayland.app/protocols/wayland#wl_pointer:enum:axis_source) Should fix zed-industries#9525 Release Notes: - N/A
As I mentioned before, there are the following issues with how GPUI handles scale factors greater than 1.0: 1. The title bar buttons do not function correctly, with minimizing button performing maximization and maximizing button performing closure. 2. As discussed in zed-industries#8809, setting a scale factor greater than 1.0 causes GPUI's drawing content to be pushed off the screen. This PR introduces `LogicalSize` and `PhysicalSize` to differentiate between coordinate systems for proper GPUI rendering, and now scale factors above 1.5 are working correctly. `Zed` with a scale factor equals 1.5, and change between different scale factors: https://github.com/zed-industries/zed/assets/14981363/3348536d-8bd3-41dd-82f6-052723312a5b Release Notes: - N/A
…two crashes (zed-industries#9306) Release Notes: - N/A
#### Call `app_version`:  #### `Zed.exe` info:  Release Notes: - N/A
Release Notes: - N/A --------- Co-authored-by: Marshall <[email protected]>
Co-authored-by: Marshall <[email protected]>
Release Notes: - N/A
**Summary**: - Removed reply message from message_menu - Made render_popover_buttons a bit more reusable - Fixed issue that you can't close the reply/edit preview when you are not focusing the message editor - Notify only the new people that were mentioned inside the edited message **Follow up** - Fix that we update the notification message for the people that we mentioned already - Fix that we remove the notification when a message gets deleted. - Fix last acknowledge message id is in correct now **Todo**: - [x] Add tests - [x] Change new added bindings to the `Editor::Cancel` event. Release Notes: - Added editing of chat messages ([zed-industries#6707](zed-industries#6707)). <img width="239" alt="Screenshot 2024-03-09 at 11 55 23" src="https://github.com/zed-industries/zed/assets/62463826/b0949f0d-0f8b-43e1-ac20-4c6d40ac41e1"> <img width="240" alt="Screenshot 2024-03-13 at 13 34 23" src="https://github.com/zed-industries/zed/assets/62463826/d0636da2-c5aa-4fed-858e-4bebe5695ba7"> --------- Co-authored-by: Bennet Bo Fenner <[email protected]> Co-authored-by: Conrad Irwin <[email protected]>
screenshots and description incoming ## title bar when window is maximized | before | after | | --- | --- | |  |  | ## ~~caption buttons at 200%~~ ~~buttons are now properly responsive at different scales~~ ~~closes zed-industries#9438~~ ~~proper scale factor handling in follow up PR (possibly zed-industries#9440)~~ <details> <summary>out of date image</summary>  </details> should be fixed by zed-industries#9456 Release Notes: - N/A
Adds the `always_treat_brackets_as_autoclosed` setting to control how the autoclosed characters are handled. The setting is off by default, meaning the behaviour stays the same (following how VSCode handles autoclosed characters). When set to `true`, the autoclosed characters are always skipped over and auto-removed no matter how they were inserted (following how Sublime Text/Xcode handle this). https://github.com/zed-industries/zed/assets/471335/304cd04a-59fe-450f-9c65-cc31b781b0db https://github.com/zed-industries/zed/assets/471335/0f5b09c2-260f-48d4-8528-23f122dee45f Release Notes: - Added the setting `always_treat_brackets_as_autoclosed` (default: `false`) to always treat brackets as "auto-closed" brackets, i.e. deleting the pair when deleting start/end, etc. ([zed-industries#7146](zed-industries#7146)). --------- Co-authored-by: Thorsten Ball <[email protected]>
…ns (zed-industries#9609) Closes zed-industries#7645 Release Notes: - Added support for inserting newlines (`\n`) and tabs (`\t`) in editor Regex search replacements ([zed-industries#7645](zed-industries#7645)).
The ashpd update removes the dependency on an older zbus version which decreases compile times. Signed-off-by: Niklas Wimmer <[email protected]>
This removes bindgen and cbindgen from the dependency graph on non-macos systems, improving compile times on those systems. Signed-off-by: Niklas Wimmer <[email protected]>
This unifies the rustybuzz dependency to the same version. Signed-off-by: Niklas Wimmer <[email protected]>
The latest update to resvg bumped some transitive dependencies which lead to duplicates. The update to the image dependency unifies most of their versions again. Most notably, gif and kurbo are still duplicated, which is best fixed downstream however. Signed-off-by: Niklas Wimmer <[email protected]>
The same changes have been used on linux here 5003504 and here 34832d49b09071846ff6f55f8ca1df019980a1df. Signed-off-by: Niklas Wimmer <[email protected]>
This PR fixes zed-industries#9567 Release Notes: - Changed default indentation for Prisma files to 2 spaces ([zed-industries#9567](zed-industries#9567)).
Reverts zed-industries#9741 /cc @niklaswimmer it looks like that PR change broke our rendering of avatars (as @bennetbo found out) - they have a blue-ish tint now, which I suppose might have to do with change between BGRA and RGBA. I'm gonna revert it for now, let's reopen it though.  Release Notes: - N/A
<img width="209" alt="image" src="https://github.com/zed-industries/zed/assets/38318044/0dcc4d0b-db9e-4eba-aa36-5c35f185e7e3"> Release Notes: - Fixed alignment of items in the title bar ([zed-industries#9709](zed-industries#9709)).
…ries#9704) That's nicer & more readable. (I just noticed that this looks weird while trying to understand why zed changes my cursor, so decided to make a quick fix (btw the issue with the cursor is that zed always loads cursor named "default" on wayland)) Release Notes: - N/A --------- Co-authored-by: Marshall Bowers <[email protected]>
…sion.json` (zed-industries#9780) This PR fixes an issue in the extension CLI when building extensions using the old manifest schema (`extension.json`). If there were values provided for the `languages`, `grammars`, or `themes` collections, these could interfere with the packaging process. We aren't expecting these fields to be set in the source `extension.json` (just in the generated one), so we can clear them out when building up the manifest. Release Notes: - N/A Co-authored-by: Max <[email protected]>
Co-authored-by: Marshall <[email protected]>
Moved `SetCursor` calls to `WM_SETCURSOR`, which occurs when OS is requires set cursor. Release Notes: - N/A
Added a check to `script/linux` so the script does not try to enable CSB or add EPEL if the user is on Fedora, which does not need these steps. The script now runs nicely on Fedora! :) Release Notes: - N/A
Added `restart` and `app_path` method for linux platform which was marked as `//todo(linux)` Release Notes: - N/A
mouse scroll wasn't working unless the window was maximized or in the top left corner because the Windows wheel events give screen coordinates Release Notes: - N/A
Separate from zed-industries#9451 On Windows, a new window may already active immediate after creation. Release Notes: - N/A --------- Co-authored-by: Mikayla <[email protected]>
…tries#9768) Quick fix that fixes key repeat not working when releasing a different key than the current one being held Don't really know much rust yet, so unsure this is the best way to handle this, but this does seem like a good starting point to get at least a tad familiar with it Release Notes: - N/A
This copies the logic from zed-industries#9608 to the X11 client. Fixes zed-industries#9707. Release Notes: - N/A Co-authored-by: Mikayla Maki <[email protected]>
There is also `.C` and `.H` (capital), but I can't imagine they are very popular and I'd be worried clashing with C. Release Notes: - Added more path suffixes recognized as C++
In zed-industries#9722, the jump-to-excerpt-source buttons where shrunk too far. Release Notes: - N/A
) This PR fixes the unexpected File Finder behaviour described in zed-industries#8782 (comment) Any change of the modifier keys except for the release of the initial modifier keys now prevents opening the selected file. Release Notes: - N/A
Release Notes: - N/A
* Store extensions versions' wasm API version in the database * Share a common struct for extension API responses between collab and client * Add wasm API version and schema version to extension API responses Release Notes: - N/A Co-authored-by: Marshall <[email protected]>
Fixes zed-industries#9799 Release Notes: - Fixed a bug where upgrading an extension did not work correctly if the extension had switched from using an old extension schema with `extension.json` to the new schema with `extension.toml`.
…nt and server (zed-industries#9797) Release Notes: - N/A
) This uses the language server settings added in zed-industries#9293 to allow users to specify the binary path and arguments with which to start up `gopls`. Example user settings for `gopls`: ```json { "lsp": { "gopls": { "binary": { "path": "/Users/thorstenball/tmp/gopls", "arguments": ["-debug=0.0.0.0:8080"] }, } } } ``` Constraints: * Right now this only allows ABSOLUTE paths. Release Notes: - Added ability to specify `gopls` binary `path` (must be absolute) and `arguments` in user settings. Example: `{"lsp": {"gopls": {"binary": {"path": "/my/abs/path/gopls", "arguments": ["-debug=0.0.0.0:8080"] }}}}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Optionally, include screenshots / media showcasing your addition that can be included in the release notes.
or