-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: use packageName and not depName for datasource lookups #20474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `rangeStrategy` default value from `'replace'` to `'auto'`. Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function. Closes #19800 BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.
Set default GOPROXY value to match `go`'s own default. Closes #20040 BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
Checks file cache for expired items at the end of a run. Non-breaking change but it may result in some long cleanup jobs for any bots which have been left to populate their package cache for a long time. Closes #13732
Co-authored-by: HonkingGoose <[email protected]>
BREAKING CHANGE: Anyone using renovate as a library and calling getPkgReleases must supply packageName and not depName
rarkins
commented
Feb 17, 2023
viceice
reviewed
Feb 17, 2023
Co-authored-by: Michael Kriese <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
rarkins
commented
Feb 17, 2023
rarkins
commented
Feb 17, 2023
viceice
reviewed
Feb 17, 2023
rarkins
commented
Feb 17, 2023
viceice
reviewed
Feb 17, 2023
@@ -228,6 +228,12 @@ describe('modules/manager/bazel/parser', () => { | |||
group = "com.example2", | |||
artifact = "bar", | |||
version = "2.2.2", | |||
), | |||
maven.artifact( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like a bad merge. 🤔
# Conflicts: # lib/modules/datasource/index.spec.ts # lib/modules/datasource/pypi/index.spec.ts # lib/workers/repository/process/lookup/common.spec.ts
viceice
reviewed
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last thing, otherwise LGTM
rarkins
added a commit
that referenced
this pull request
Feb 23, 2023
rarkins
added a commit
that referenced
this pull request
Feb 25, 2023
rarkins
added a commit
that referenced
this pull request
Feb 27, 2023
rarkins
added a commit
that referenced
this pull request
Mar 4, 2023
rarkins
added a commit
that referenced
this pull request
Mar 8, 2023
rarkins
added a commit
that referenced
this pull request
Mar 10, 2023
rarkins
added a commit
that referenced
this pull request
Mar 10, 2023
rarkins
added a commit
that referenced
this pull request
Mar 10, 2023
rarkins
added a commit
that referenced
this pull request
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors datasources + lookup to use
packageName
primarily and notdepName
.BREAKING CHANGE: Anyone using renovate as a library and calling getPkgReleases must supply packageName and not depName