Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning)!: bump short ranges to version #20494

Merged
merged 12 commits into from
Feb 20, 2023
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Feb 18, 2023

Changes

Bumps short ranges to full version ranges

Context

Closes #20488

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

RahulGautamSingh and others added 10 commits February 17, 2023 08:16
Changes `rangeStrategy` default value from `'replace'` to `'auto'`.

Changes `auto` behavior so that `update-lockfile` is preferred if the manager supports the `updateLockedDependency()` function.

Closes #19800

BREAKING CHANGE: Renovate will now default to updating locked dependency versions. To revert to previous behavior, configure rangeStrategy=replace.
…9958)

Sets new defaults:
- `prConcurrentLimit`: 10 (instead of 0)
- `prHourlyLimit`: 2 (instead of 0)

Closes #19800

BREAKING CHANGE: Renovate now defaults to applying hourly and concurrent PR limits. To revert to unlimited, configure them back to `0`.
Set default GOPROXY value to match `go`'s own default.

Closes #20040

BREAKING CHANGE: Renovate will now use go's default `GOPROXY` settings. To avoid using the public proxy, configure `GOPROXY=direct`.
Checks file cache for expired items at the end of a run. Non-breaking change but it may result in some long cleanup jobs for any bots which have been left to populate their package cache for a long time.

Closes #13732
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this a breaking change?

Copy link
Contributor

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems more correct to me than before. I agree that it's probably a breaking change even though it could be considered a bug fix as well. to avoid surprised users it might be best to ship this with a major version bump.

@rarkins
Copy link
Collaborator Author

rarkins commented Feb 18, 2023

Majority of users don't really have a choice now to opt in though. But sure, v35 is nearly ready to go

@Turbo87
Copy link
Contributor

Turbo87 commented Feb 18, 2023

you mean because they're using it via GitHub app? makes sense, but even just for communication purposes it might be better to clearly mark it as a breaking change :)

@secustor
Copy link
Collaborator

LGTM, I will approve when the target branch has been changed

@rarkins rarkins added the breaking Breaking change, requires major version bump label Feb 18, 2023
@rarkins rarkins changed the base branch from main to v35 February 20, 2023 14:22
@rarkins rarkins changed the title fix(versioning): bump short ranges to version fix(versioning)!: bump short ranges to version Feb 20, 2023
@rarkins rarkins merged commit c24ed82 into v35 Feb 20, 2023
@rarkins rarkins deleted the fix/20488-bump-range branch February 20, 2023 17:11
rarkins added a commit that referenced this pull request Mar 10, 2023
When rangeStrategy=bump, and the existing range is "short" (e.g. `^1`), and a bump is required, the new result will be a version range (e.g. `^1.0.7`).

Closes #20488
rarkins added a commit that referenced this pull request Mar 10, 2023
When rangeStrategy=bump, and the existing range is "short" (e.g. `^1`), and a bump is required, the new result will be a version range (e.g. `^1.0.7`).

Closes #20488
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo: tilde bump does not bump if satisfying existing range
5 participants