Fix `noop_method_call` detection #116201

Jarcho · 2023-09-27T14:24:18Z

This needs to be merged before #116198 can compile. The error occurs before the compiler is built so this needs to be a separate PR.

rustbot · 2023-09-27T14:24:26Z

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

WaffleLapkin

Can you please provide some context on what you are trying to fix here? And also preferably please add a test.

cc @fee1-dead since you've recently changed this lint
r? WaffleLapkin

compiler/rustc_lint/src/noop_method_call.rs

Jarcho · 2023-09-27T14:41:40Z

And also preferably please add a test.

A test case would require adding a diagnostic item to std.

compiler/rustc_lint/src/noop_method_call.rs

fee1-dead · 2023-09-28T14:05:05Z

@bors r+ rollup

bors · 2023-09-28T14:05:07Z

📌 Commit 66bc682 has been approved by fee1-dead

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#116133 (ref(bootstrap.py): add `eprint` function) - rust-lang#116201 (Fix `noop_method_call` detection) - rust-lang#116231 (Remove `rustc_lint_defs::lint_array`) - rust-lang#116234 (Miri subtree update) - rust-lang#116239 (Only visit reachable nodes in SsaLocals.) - rust-lang#116245 (Clippy backport: Move needless_raw_string_hashes to pedantic) - rust-lang#116253 (Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116201 - Jarcho:noop_fix, r=fee1-dead Fix `noop_method_call` detection This needs to be merged before rust-lang#116198 can compile. The error occurs before the compiler is built so this needs to be a separate PR.

rustbot assigned wesleywiser Sep 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 27, 2023

WaffleLapkin reviewed Sep 27, 2023

View reviewed changes

rustbot assigned WaffleLapkin and unassigned wesleywiser Sep 27, 2023

WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 27, 2023

fee1-dead reviewed Sep 27, 2023

View reviewed changes

compiler/rustc_lint/src/noop_method_call.rs Outdated Show resolved Hide resolved

compiler/rustc_lint/src/noop_method_call.rs Outdated Show resolved Hide resolved

Jarcho force-pushed the noop_fix branch 2 times, most recently from 3909223 to 127699e Compare September 27, 2023 16:40

This comment has been minimized.

Sign in to view

Jarcho force-pushed the noop_fix branch from 127699e to 6647b99 Compare September 27, 2023 17:30

This comment has been minimized.

Sign in to view

Jarcho force-pushed the noop_fix branch from 6647b99 to 51d339e Compare September 27, 2023 18:13

fee1-dead reviewed Sep 28, 2023

View reviewed changes

compiler/rustc_lint/src/noop_method_call.rs Outdated Show resolved Hide resolved

Fix noop_method_call detection for new diagnostic items

66bc682

Jarcho force-pushed the noop_fix branch from 51d339e to 66bc682 Compare September 28, 2023 12:23

fee1-dead approved these changes Sep 28, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2023

matthiaskrgr mentioned this pull request Sep 29, 2023

Rollup of 7 pull requests #116260

Merged

bors merged commit e814f1e into rust-lang:master Sep 29, 2023
11 checks passed

rustbot added this to the 1.74.0 milestone Sep 29, 2023

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `noop_method_call` detection #116201

Fix `noop_method_call` detection #116201

Jarcho commented Sep 27, 2023

rustbot commented Sep 27, 2023

WaffleLapkin left a comment

Jarcho commented Sep 27, 2023

This comment has been minimized.

This comment has been minimized.

fee1-dead commented Sep 28, 2023

bors commented Sep 28, 2023

Fix noop_method_call detection #116201

Fix noop_method_call detection #116201

Conversation

Jarcho commented Sep 27, 2023

rustbot commented Sep 27, 2023

WaffleLapkin left a comment

Choose a reason for hiding this comment

Jarcho commented Sep 27, 2023

This comment has been minimized.

This comment has been minimized.

fee1-dead commented Sep 28, 2023

bors commented Sep 28, 2023

Fix `noop_method_call` detection #116201

Fix `noop_method_call` detection #116201