Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted #116253

asquared31415 · 2023-09-28T22:58:52Z

Makes the suggestion to add adt_const_params formatted like every other feature gate (notably this makes it such that the playground recognizes it). Additionally improves the situations in which that help is emitted so that it's only emitted when the type would be valid or the type could be valid (using a slightly incorrect heuristic that favors suggesting the feature over not) instead of, for example, implying that adding the feature would allow the use of String.

Also adds the "the only supported types are integers, bool and char" note to the errors on fn and raw pointers.

r? @compiler-errors

compiler-errors · 2023-09-28T23:02:14Z

r=me unless you want a double check from boxy. looks good to me considering it's just heuristic :3

@bors delegate+

bors · 2023-09-28T23:02:17Z

✌️ @asquared31415, you can now approve this pull request!

If @compiler-errors told you to "r=me" after making some further change, please make that change, then do @bors r=@compiler-errors

…and only suggest it when the type can probably work

asquared31415 · 2023-09-29T01:57:54Z

@bors r=@compiler-errors

bors · 2023-09-29T01:57:56Z

📌 Commit b53a1b3 has been approved by compiler-errors

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#116133 (ref(bootstrap.py): add `eprint` function) - rust-lang#116201 (Fix `noop_method_call` detection) - rust-lang#116231 (Remove `rustc_lint_defs::lint_array`) - rust-lang#116234 (Miri subtree update) - rust-lang#116239 (Only visit reachable nodes in SsaLocals.) - rust-lang#116245 (Clippy backport: Move needless_raw_string_hashes to pedantic) - rust-lang#116253 (Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116253 - asquared31415:adt_const_params_feature, r=compiler-errors Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted Makes the suggestion to add `adt_const_params` formatted like every other feature gate (notably this makes it such that the playground recognizes it). Additionally improves the situations in which that help is emitted so that it's only emitted when the type would be valid or the type *could* be valid (using a slightly incorrect heuristic that favors suggesting the feature over not) instead of, for example, implying that adding the feature would allow the use of `String`. Also adds the "the only supported types are integers, `bool` and `char`" note to the errors on fn and raw pointers. r? `@compiler-errors`

rustbot assigned compiler-errors Sep 28, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2023

compiler-errors approved these changes Sep 28, 2023

View reviewed changes

This comment has been minimized.

Sign in to view

make adt_const_params feature suggestion more consistent with others …

b53a1b3

…and only suggest it when the type can probably work

rust-cloud-vms bot force-pushed the adt_const_params_feature branch from 2a15beb to b53a1b3 Compare September 28, 2023 23:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2023

matthiaskrgr mentioned this pull request Sep 29, 2023

Rollup of 7 pull requests #116260

Merged

bors merged commit 95262e4 into rust-lang:master Sep 29, 2023
11 checks passed

rustbot added this to the 1.74.0 milestone Sep 29, 2023

asquared31415 deleted the adt_const_params_feature branch September 29, 2023 15:51

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted #116253

Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted #116253

asquared31415 commented Sep 28, 2023

compiler-errors commented Sep 28, 2023

bors commented Sep 28, 2023

This comment has been minimized.

asquared31415 commented Sep 29, 2023

bors commented Sep 29, 2023

Make adt_const_params feature suggestion consistent with other features and improve when it is emitted #116253

Make adt_const_params feature suggestion consistent with other features and improve when it is emitted #116253

Conversation

asquared31415 commented Sep 28, 2023

compiler-errors commented Sep 28, 2023

bors commented Sep 28, 2023

This comment has been minimized.

asquared31415 commented Sep 29, 2023

bors commented Sep 29, 2023

Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted #116253

Make `adt_const_params` feature suggestion consistent with other features and improve when it is emitted #116253