Some small cleanups in `rustc_abi` #116313

nnethercote · 2023-10-01T11:38:50Z

Minor things I found while looking at this crate's code.

To match `parse_address_space` and `parse_bits` above.

the8472 · 2023-10-01T14:58:33Z

compiler/rustc_abi/src/layout.rs

        if repr.can_randomize_type_layout() && cfg!(feature = "randomize") {
-            #[cfg(feature = "randomize")]
-            {
-                // `ReprOptions.layout_seed` is a deterministic seed that we can use to
-                // randomize field ordering with
-                let mut rng = Xoshiro128StarStar::seed_from_u64(repr.field_shuffle_seed.as_u64());


The Xoshiro128StarStar import is conditional on that feature.

Hmm, I see. I will remove that commit.

Now I'm wondering why the "randomize" feature exists. I bet it's never disabled within rustc itself. rust-analyzer, maybe?

It is currently disabled in rust-analyzer yes, and now that it's depended on the Hash64 type of rustc_data_structures r-a is unlikely to ever enable it as we don't want to pull in that crate.

By making every `alt_foo` exactly match a `foo`.

nnethercote · 2023-10-01T22:20:35Z

I have updated the code, removing the commit touching the feature gates.

the8472 · 2023-10-02T09:35:05Z

@bors r+ rollup

bors · 2023-10-02T09:35:07Z

📌 Commit 17e3793 has been approved by the8472

It is now in the queue for this repository.

…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#116313 (Some small cleanups in `rustc_abi`) - rust-lang#116326 (Correct misleading std::fmt::Binary example (rust-lang#116165)) - rust-lang#116340 (`skip_binder` to `instantiate_identity`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116313 - nnethercote:rustc_abi, r=the8472 Some small cleanups in `rustc_abi` Minor things I found while looking at this crate's code. r? `@the8472`

nnethercote added 3 commits October 1, 2023 21:57

Minor comment and whitespace tweaks.

86ecfdd

Rename two parsing closures.

ddb7422

To match `parse_address_space` and `parse_bits` above.

Remove unnecessary pubs.

2369adc

rustbot assigned the8472 Oct 1, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 1, 2023

the8472 reviewed Oct 1, 2023

View reviewed changes

Name some local variables more consistently.

17e3793

By making every `alt_foo` exactly match a `foo`.

nnethercote force-pushed the rustc_abi branch from 926002a to 17e3793 Compare October 1, 2023 22:18

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2023

matthiaskrgr mentioned this pull request Oct 2, 2023

Rollup of 3 pull requests #116346

Merged

bors merged commit e51a2aa into rust-lang:master Oct 2, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 2, 2023

nnethercote deleted the rustc_abi branch October 3, 2023 00:46

pvdrz mentioned this pull request Oct 4, 2023

Fix divergence from upstream master ferrocene/ferrocene#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some small cleanups in `rustc_abi` #116313

Some small cleanups in `rustc_abi` #116313

nnethercote commented Oct 1, 2023

the8472 Oct 1, 2023

nnethercote Oct 1, 2023

Veykril Oct 2, 2023

nnethercote commented Oct 1, 2023

the8472 commented Oct 2, 2023

bors commented Oct 2, 2023

Some small cleanups in rustc_abi #116313

Some small cleanups in rustc_abi #116313

Conversation

nnethercote commented Oct 1, 2023

the8472 Oct 1, 2023

Choose a reason for hiding this comment

nnethercote Oct 1, 2023

Choose a reason for hiding this comment

Veykril Oct 2, 2023

Choose a reason for hiding this comment

nnethercote commented Oct 1, 2023

the8472 commented Oct 2, 2023

bors commented Oct 2, 2023

Some small cleanups in `rustc_abi` #116313

Some small cleanups in `rustc_abi` #116313