Bring back generic parameters for indices in rustc_abi and make it compile on stable

[Veykril]

This effectively reverses #107163, allowing rust-analyzer to depend on this crate again,

It also moves some glob imports / expands them in the first commit because they made it more difficult for me to reason about things.

[rustbot]

r? @WaffleLapkin

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[WaffleLapkin]

What's the reason for not simply reverting the commit, why did you need to re-do all changes?

[Veykril]

Because a bunch of other changes have been commited on top of it making a revert non-trivial.

Back then FieldIdx + IndexVec wasn't really used, the Hash64 type wasn't used and some other stuff. I tried doing a revert first but it was too much effort figuring out what has changed on top of that compared to just re-doing the changes from scratch.

[bors]

☔ The latest upstream changes (presumably #116346) made this pull request unmergeable. Please resolve the merge conflicts.

[WaffleLapkin]

Annoying that we have to do that, as the code without generics is a little easier to read, but I understand the reasoning. LGTM, modulo the formatting nitpick.

cc @mikebenfield as the author of #107163, you might have an opinion here (is there a way to make it easier to read/make less changes, but still keep the r-a use-case?).

[WaffleLapkin]

Can you add one or two newlines here? Formatting looks very weird here...

[Veykril]

Merged the change into the last commit

[Veykril]

is there a way to make it easier to read/make less changes, but still keep the r-a use-case?

This is as minimal as it gets as far as I can tell. We need to be generic over the index types since r-a and rustc use different ones here, and since we wan't to build on stable (and because we don't need them), all the serialize derives etc have to be gated. It would be nice if we could extract things out such that the nightly feature becomes unnecessary but given the derives for serialization and hashing are required for rustc that's not feasible.

[WaffleLapkin]

@bors r+

[bors]

📌 Commit 0aedec4 has been approved by WaffleLapkin

It is now in the queue for this repository.

[bors]

⌛ Testing commit 0aedec4 with merge 2c9b0de...

[bors]

☀️ Test successful - checks-actions
Approved by: WaffleLapkin
Pushing 2c9b0de to master...

[rust-timer]

Finished benchmarking commit (2c9b0de): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.3%, 1.6%]	2
Regressions ❌ (secondary)	3.1%	[2.6%, 3.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[1.3%, 1.6%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 624.508s -> 624.256s (-0.04%)
Artifact size: 270.64 MiB -> 270.63 MiB (-0.00%)