Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML viewport meta tag to IRServer and IRMQTTServer examples #1467

Closed
touchgadget opened this issue Apr 27, 2021 · 2 comments · Fixed by #1469
Closed

Add HTML viewport meta tag to IRServer and IRMQTTServer examples #1467

touchgadget opened this issue Apr 27, 2021 · 2 comments · Fixed by #1469

Comments

@touchgadget
Copy link
Contributor

Version/revision of the library used

v2.7.18

Describe the bug

The IRServer and IRMQTTServer web pages are easier to read with a viewport meta tag when using a phone or tablet in portrait mode.

Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag

To Reproduce

IRServer View page in portrait mode without viewport meta tag. The user must zoom to get the page to fill the screen. With viewport meta tag, the page fills the screen.

Example code used

            "content=\"text/html;charset=utf-8\">"
            "<meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=5.0\">"
            "</head><body><center><h1>");

Other useful information

I can generate a PR but it is only a 1 line change to two examples. The Web-AC-control example includes the viewport meta tag so not change is needed.

@NiKiZe
Copy link
Collaborator

NiKiZe commented Apr 27, 2021

A PR would be great

crankyoldgit pushed a commit that referenced this issue Apr 29, 2021
The IRServer and IRMQTTServer web pages are easier to read with a viewport meta tag when using a phone or tablet in portrait mode.

Fixes #1467
crankyoldgit added a commit that referenced this issue Jul 6, 2021
_v2.7.19 (20210706)_

**[Bug Fixes]**
- Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517)
- PANASONIC_AC: Fix Low and High fan speeds (#1515)
- Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499)
- IRac: Fix off-by-one error in Coolix's sleep setting. (#1500)
- Fix undefined constant (#1490)

**[Features]**
- Add detailed support for Kelon ACs (#1494)
- Experimental basic support for Teknopoint A/C protocol (#1486 #1504)
- Daikin64: Add support for Heat mode (#1492)
- Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481)

**[Misc]**
- GREE: Update inter-message gap timing (#1508 #1509)
- IRac: Change Coolix to send special messages after a normal message. (#1501 #1502)
- Fix compiler warnings causing Travis failures. (#1491)
- Update supported model info (#1477 #1485 #1488 #1489)
- Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
crankyoldgit added a commit that referenced this issue Jul 6, 2021
* Regenerate Doxygen documentation

* v2.7.19 release
_v2.7.19 (20210706)_

**[Bug Fixes]**
- Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517)
- PANASONIC_AC: Fix Low and High fan speeds (#1515)
- Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499)
- IRac: Fix off-by-one error in Coolix's sleep setting. (#1500)
- Fix undefined constant (#1490)

**[Features]**
- Add detailed support for Kelon ACs (#1494)
- Experimental basic support for Teknopoint A/C protocol (#1486 #1504)
- Daikin64: Add support for Heat mode (#1492)
- Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481)

**[Misc]**
- GREE: Update inter-message gap timing (#1508 #1509)
- IRac: Change Coolix to send special messages after a normal message. (#1501 #1502)
- Fix compiler warnings causing Travis failures. (#1491)
- Update supported model info (#1477 #1485 #1488 #1489)
- Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
@crankyoldgit
Copy link
Owner

FYI, the committed & merged changes thus far have been included in the newly released version of the library. i.e. v2.7.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants