Panasonic AC - Fix Low and High fan speed

[ajaypala]

Added the missing low and high fan speeds for Panasonic AC. Regression from previous. Tested with my Panasonic unit.

[crankyoldgit]

Removing myself as a reviewer as I've now made significant changes myself.
I'm happy with it as it is now. i.e. LGTM

Over to @NiKiZe for an impartial code review.

[ajaypala]

LGTM.
@crankyoldgit Thanks for all your efforts on this library.

[NiKiZe]

This might give unexpected behaviour for any current consumers of fanspeeds?
Also what happens if this gets set on a unit that does not support it? Any chance for 🔥?

[ajaypala]

This might give unexpected behaviour for any current consumers of fanspeeds?
Also what happens if this gets set on a unit that does not support it? Any chance for fire?

I don't think it will affect current consumers unless they are intentionally setting the fan speed to Low or High, in which case the result would be auto fan speed.

[crankyoldgit]

This might give unexpected behaviour for any current consumers of fanspeeds?
Also what happens if this gets set on a unit that does not support it? Any chance for fire?

I don't think it will affect current consumers unless they are intentionally setting the fan speed to Low or High, in which case the result would be auto fan speed.

Looking at the rest of the code, we clearly expected those values. It looks like we lost the ability to set them in a re-factor along the way. Now you've made me look: ;-)

e.g. Prior to #934 it was:

void IRPanasonicAc::setFan(const uint8_t speed) {
  if (speed <= kPanasonicAcFanMax || speed == kPanasonicAcFanAuto)
    remote_state[16] =
        (remote_state[16] & 0x0F) | ((speed + kPanasonicAcFanOffset) << 4);
}

So I clearly screwed that up!

[crankyoldgit]

FYI, the committed & merged changes have been included in the newly released version of the library. i.e. v2.7.19