[BUG] Illegal Heap write in rawbuf when the capture has overflowed. #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix an issue where we write past the end of the capture buffer when it is full. Two options to fix this: 1. Extend all capture buffers by 1 entry. i.e. upto 4 bytes of extra unused heap and some FLASH/PROGMEM bytes. _or_ 2. Skip the memory write when we have overflowed. i.e. Possibly slightly more than 4 bytes of FLASH/PROGMEM used. - CPU overhead should be about the same. - Given heap & memory is a more critical resource than Flash/PROGMEM, opting for Option 2. TODO: Add unit tests to confirm this works and never happens again. Kudos to @davepl for reporting the issue and diagnosing the offending line of code. Fixes #1516
So we can be sure it is fixed, and it doesn't happen again. * Add a helper method `IRrecv::_getParamsPtr` to access `params` in Unit tests. Fixes #1516
NiKiZe
approved these changes
Jul 5, 2021
crankyoldgit
added a commit
that referenced
this pull request
Jul 6, 2021
_v2.7.19 (20210706)_ **[Bug Fixes]** - Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517) - PANASONIC_AC: Fix Low and High fan speeds (#1515) - Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499) - IRac: Fix off-by-one error in Coolix's sleep setting. (#1500) - Fix undefined constant (#1490) **[Features]** - Add detailed support for Kelon ACs (#1494) - Experimental basic support for Teknopoint A/C protocol (#1486 #1504) - Daikin64: Add support for Heat mode (#1492) - Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481) **[Misc]** - GREE: Update inter-message gap timing (#1508 #1509) - IRac: Change Coolix to send special messages after a normal message. (#1501 #1502) - Fix compiler warnings causing Travis failures. (#1491) - Update supported model info (#1477 #1485 #1488 #1489) - Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jul 6, 2021
* Regenerate Doxygen documentation * v2.7.19 release _v2.7.19 (20210706)_ **[Bug Fixes]** - Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517) - PANASONIC_AC: Fix Low and High fan speeds (#1515) - Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499) - IRac: Fix off-by-one error in Coolix's sleep setting. (#1500) - Fix undefined constant (#1490) **[Features]** - Add detailed support for Kelon ACs (#1494) - Experimental basic support for Teknopoint A/C protocol (#1486 #1504) - Daikin64: Add support for Heat mode (#1492) - Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481) **[Misc]** - GREE: Update inter-message gap timing (#1508 #1509) - IRac: Change Coolix to send special messages after a normal message. (#1501 #1502) - Fix compiler warnings causing Travis failures. (#1491) - Update supported model info (#1477 #1485 #1488 #1489) - Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRrecv::_getParamsPtrto accessparamsin Unit tests.Kudos to @davepl for reporting the issue and diagnosing the offending line of code.
Fixes #1516