Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best if order of sending signal in "COOLIX" protocol is alternate #1501

Closed
MarkEvens opened this issue Jun 14, 2021 · 5 comments · Fixed by #1502
Closed

Best if order of sending signal in "COOLIX" protocol is alternate #1501

MarkEvens opened this issue Jun 14, 2021 · 5 comments · Fixed by #1502
Assignees

Comments

@MarkEvens
Copy link

Right now what I am facing issue is In "COOLIX" for turbo mode it is first send turbo toggle and after it send all the other settings. So because of this if my AC is OFF and I directly send turbo frame with Turbo ON is useless, but instead you just change the order and alternate by first send all the other settings after it send turbo toggle than it is worked even If my AC is OFF.

@crankyoldgit crankyoldgit self-assigned this Jun 14, 2021
crankyoldgit added a commit that referenced this issue Jun 16, 2021
Sending a special message after a normal message ensures the unit is on.
Reports are that if a state with special setting (e.g. Turbo) and turning the unit on, the special message is ignored because the unit must be powered on before it will accept it.
So, change the order, send the normal state first, then the special message/settings, except for "Off" of course.

Fixes #1501
@crankyoldgit crankyoldgit added the Pending Confirmation Waiting for confirmation from user label Jun 16, 2021
@crankyoldgit
Copy link
Owner

Hey @MarkEvens Can you please download/try out PR #1502 / Branch https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1501 and let me know if this fixes the issue for you?

My tests indicate it should, but nothing beats testing against a real device.

i.e. It should now send in order: the normal/on message, then the turbo message.

@crankyoldgit
Copy link
Owner

Ping @MarkEvens

@MarkEvens
Copy link
Author

Sorry for late response, I tested it and it's working

 ac.next.protocol = decode_type_t::COOLIX;  // Set a protocol to use.
  ac.next.model = 1;  // Some A/Cs have different models. Try just the first.
  ac.next.mode = stdAc::opmode_t::kCool;  // Run in cool mode initially.
  ac.next.celsius = true;  // Use Celsius for temp units. False = Fahrenheit
  ac.next.degrees = 25;  // 25 degrees.
  ac.next.fanspeed = stdAc::fanspeed_t::kMedium;  // Start the fan at medium.
  ac.next.swingv = stdAc::swingv_t::kOff;  // Don't swing the fan up or down.
  ac.next.swingh = stdAc::swingh_t::kOff;  // Don't swing the fan left or right.
  ac.next.light = false;  // Turn off any LED/Lights/Display that we can.
  ac.next.beep = false;  // Turn off any beep from the A/C if we can.
  ac.next.econo = false;  // Turn off any economy modes if we can.
  ac.next.filter = false;  // Turn off any Ion/Mold/Health filters if we can.
  ac.next.turbo = true;  // Don't use any turbo/powerful/etc modes.
  ac.next.quiet = false;  // Don't use any quiet/silent/etc modes.
  ac.next.sleep = -1;  // Don't set any sleep time or modes.
  ac.next.clean = false;  // Turn off any Cleaning options if we can.
  ac.next.clock = -1;  // Don't set any current time if we can avoid it.
  ac.next.power = true;  // Initially start with the unit off.

In my setup I fired this frame when my AC is OFF and It turns ON and start in turbo mode

@crankyoldgit
Copy link
Owner

Thanks for confirming it works

@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Jun 23, 2021
crankyoldgit added a commit that referenced this issue Jun 23, 2021
…1502)

Sending a special message after a normal message ensures the unit is on.
Reports are that if a state with special setting (e.g. Turbo) and turning the unit on, the special message is ignored because the unit must be powered on before it will accept it.
So, change the order, send the normal state first, then the special message/settings, except for "Off" of course.

Fixes #1501
crankyoldgit added a commit that referenced this issue Jul 6, 2021
_v2.7.19 (20210706)_

**[Bug Fixes]**
- Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517)
- PANASONIC_AC: Fix Low and High fan speeds (#1515)
- Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499)
- IRac: Fix off-by-one error in Coolix's sleep setting. (#1500)
- Fix undefined constant (#1490)

**[Features]**
- Add detailed support for Kelon ACs (#1494)
- Experimental basic support for Teknopoint A/C protocol (#1486 #1504)
- Daikin64: Add support for Heat mode (#1492)
- Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481)

**[Misc]**
- GREE: Update inter-message gap timing (#1508 #1509)
- IRac: Change Coolix to send special messages after a normal message. (#1501 #1502)
- Fix compiler warnings causing Travis failures. (#1491)
- Update supported model info (#1477 #1485 #1488 #1489)
- Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
crankyoldgit added a commit that referenced this issue Jul 6, 2021
* Regenerate Doxygen documentation

* v2.7.19 release
_v2.7.19 (20210706)_

**[Bug Fixes]**
- Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517)
- PANASONIC_AC: Fix Low and High fan speeds (#1515)
- Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499)
- IRac: Fix off-by-one error in Coolix's sleep setting. (#1500)
- Fix undefined constant (#1490)

**[Features]**
- Add detailed support for Kelon ACs (#1494)
- Experimental basic support for Teknopoint A/C protocol (#1486 #1504)
- Daikin64: Add support for Heat mode (#1492)
- Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481)

**[Misc]**
- GREE: Update inter-message gap timing (#1508 #1509)
- IRac: Change Coolix to send special messages after a normal message. (#1501 #1502)
- Fix compiler warnings causing Travis failures. (#1491)
- Update supported model info (#1477 #1485 #1488 #1489)
- Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
@crankyoldgit
Copy link
Owner

FYI, the committed & merged changes thus far have been included in the newly released version of the library. i.e. v2.7.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants