-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kelon ACs #1494
Conversation
0dc50b2
to
f223564
Compare
ab6cccb
to
30566a3
Compare
FYI, you'll probably need to |
4e0d367
to
7838ff6
Compare
Code + tests should be good, unit tests run on my machine. Let's see if the CI agrees. Let me know if there's any other changes I need to make. |
I'll start a proper code review of this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off, thanks for doing this. I know it's a huge amount of work, it's appreciated.
Most of these comments are nitpicks and automated linter issues.
Sorry there are so many of them.
Oh I missed the lint check :)
I actually put it there on purpose to make it clear that I specifically intended for "fan auto" / "smart" to be handled by the default case and that I didn't just forget about it. Anyway I'll address the requests in the next few days. Do you have any requirements on squashing or can I just commit a "lint fixes" + whatever makes sense for everything that's not a lint issue? |
Usually squash and merge is used so go nuts ;) |
I reverted the additions to print signed integer strings and the tests don't run since Arduino's String class is only available on Arduino. I think I'll have to put it back. |
Still have a number of linter errors to correct/address:
https://travis-ci.org/github/crankyoldgit/IRremoteESP8266/jobs/774565115#L615-L868 |
Hi, |
So if there isn't anything left to address, this is good to go for me :) |
Automatic linter check fails: All the other tests look fine. I'll try to get to the human-side of the review later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nitpicks and a few subtle corrections & suggestions. Other than that, looks good. Great work!
src/IRutils.h
Outdated
String addSignedIntToString(const int16_t value, const String label, | ||
const bool precomma = true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same style issue.
Everything should be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor issues related to the new stuff. Other than that, Looks Good To Me!
[optional] I suggest adding a unit test to cover those cases too. |
Ok, these two should also be addressed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. Sorry for the long process.
LGTM!
_v2.7.19 (20210706)_ **[Bug Fixes]** - Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517) - PANASONIC_AC: Fix Low and High fan speeds (#1515) - Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499) - IRac: Fix off-by-one error in Coolix's sleep setting. (#1500) - Fix undefined constant (#1490) **[Features]** - Add detailed support for Kelon ACs (#1494) - Experimental basic support for Teknopoint A/C protocol (#1486 #1504) - Daikin64: Add support for Heat mode (#1492) - Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481) **[Misc]** - GREE: Update inter-message gap timing (#1508 #1509) - IRac: Change Coolix to send special messages after a normal message. (#1501 #1502) - Fix compiler warnings causing Travis failures. (#1491) - Update supported model info (#1477 #1485 #1488 #1489) - Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
* Regenerate Doxygen documentation * v2.7.19 release _v2.7.19 (20210706)_ **[Bug Fixes]** - Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517) - PANASONIC_AC: Fix Low and High fan speeds (#1515) - Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499) - IRac: Fix off-by-one error in Coolix's sleep setting. (#1500) - Fix undefined constant (#1490) **[Features]** - Add detailed support for Kelon ACs (#1494) - Experimental basic support for Teknopoint A/C protocol (#1486 #1504) - Daikin64: Add support for Heat mode (#1492) - Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481) **[Misc]** - GREE: Update inter-message gap timing (#1508 #1509) - IRac: Change Coolix to send special messages after a normal message. (#1501 #1502) - Fix compiler warnings causing Travis failures. (#1491) - Update supported model info (#1477 #1485 #1488 #1489) - Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
FYI, the committed & merged changes have been included in the newly released version of the library. i.e. v2.7.19 |
This PR adds support for Kelon-branded (HiSense) AC units.
Tests aren't ready yet, I'm submitting this early to ensure CI tests run and for an early review if someone can give a look.,
By the way, fyi: https://blog.travis-ci.com/2021-05-07-orgshutdown