Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MDNS in IRServer and IRMQTTServer #1499

Merged
merged 3 commits into from
Jun 12, 2021

Conversation

touchgadget
Copy link
Contributor

Fix MDNS service in IRServer and IRMQTTServer examples

In the examples IRServer and IRMQTTServer, Chromium and Firefox running on Ubuntu fail to connect to the ESP8266 using the MDNS hostname. For example, esp8266.local and ir_server.local do not resolve.

Based on the MDNS examples included with the ESP8266 board package, adding calls to mdns.addService() and mdns.update() fixes the problems.

Fixes #1498

Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thanks for this! Really appreciated. Sorry for being nit-picky.

examples/IRMQTTServer/IRMQTTServer.ino Show resolved Hide resolved
examples/IRMQTTServer/IRMQTTServer.ino Outdated Show resolved Hide resolved
examples/IRServer/IRServer.ino Outdated Show resolved Hide resolved
@crankyoldgit crankyoldgit self-requested a review June 12, 2021 01:37
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Let me know when you've finished testing etc, and I'll merge it.

@crankyoldgit crankyoldgit added enhancement Pending Confirmation Waiting for confirmation from user labels Jun 12, 2021
@crankyoldgit crankyoldgit merged commit b86aa36 into crankyoldgit:master Jun 12, 2021
@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Jun 12, 2021
crankyoldgit added a commit that referenced this pull request Jul 6, 2021
_v2.7.19 (20210706)_

**[Bug Fixes]**
- Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517)
- PANASONIC_AC: Fix Low and High fan speeds (#1515)
- Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499)
- IRac: Fix off-by-one error in Coolix's sleep setting. (#1500)
- Fix undefined constant (#1490)

**[Features]**
- Add detailed support for Kelon ACs (#1494)
- Experimental basic support for Teknopoint A/C protocol (#1486 #1504)
- Daikin64: Add support for Heat mode (#1492)
- Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481)

**[Misc]**
- GREE: Update inter-message gap timing (#1508 #1509)
- IRac: Change Coolix to send special messages after a normal message. (#1501 #1502)
- Fix compiler warnings causing Travis failures. (#1491)
- Update supported model info (#1477 #1485 #1488 #1489)
- Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
@crankyoldgit crankyoldgit mentioned this pull request Jul 6, 2021
crankyoldgit added a commit that referenced this pull request Jul 6, 2021
* Regenerate Doxygen documentation

* v2.7.19 release
_v2.7.19 (20210706)_

**[Bug Fixes]**
- Illegal Heap write in rawbuf when the capture has overflowed. (#1516 #1517)
- PANASONIC_AC: Fix Low and High fan speeds (#1515)
- Fix MDNS in IRServer and IRMQTTServer example code (#1498 #1499)
- IRac: Fix off-by-one error in Coolix's sleep setting. (#1500)
- Fix undefined constant (#1490)

**[Features]**
- Add detailed support for Kelon ACs (#1494)
- Experimental basic support for Teknopoint A/C protocol (#1486 #1504)
- Daikin64: Add support for Heat mode (#1492)
- Basic support for `HAIER_AC176` 176 bit protocol. (#1480 #1481)

**[Misc]**
- GREE: Update inter-message gap timing (#1508 #1509)
- IRac: Change Coolix to send special messages after a normal message. (#1501 #1502)
- Fix compiler warnings causing Travis failures. (#1491)
- Update supported model info (#1477 #1485 #1488 #1489)
- Add HTML viewport meta tag to IRServer and IRMQTTServer examples (#1467 #1469)
@crankyoldgit
Copy link
Owner

FYI, the committed & merged changes have been included in the newly released version of the library. i.e. v2.7.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect via MDNS hostname.local fails
2 participants