Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 'main' into RefStructInterfaces #72650

Merged

Commits on Feb 29, 2024

  1. Configuration menu
    Copy the full SHA
    ea500de View commit details
    Browse the repository at this point in the history
  2. Merge pull request dotnet#72348 from dotnet/dev/gel/bumpPatchVer

    Bump patch version for NuGet publish purpose
    genlu authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9934fb9 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    152094f View commit details
    Browse the repository at this point in the history
  2. Merge pull request dotnet#72349 from dotnet/merges/release/dev17.9-to…

    …-release/dev17.10
    
    Merge release/dev17.9 to release/dev17.10
    dotnet-bot authored Mar 1, 2024
    Configuration menu
    Copy the full SHA
    14680fc View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Configuration menu
    Copy the full SHA
    2c0d29f View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    28bf4cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aed9cf4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2cf6e47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c910040 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7564430 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Configuration menu
    Copy the full SHA
    4d3093f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e3a92bf View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    fb7890e View commit details
    Browse the repository at this point in the history
  2. Update dependencies from https://github.com/dotnet/source-build-exter…

    …nals build 20240311.3
    
    Microsoft.SourceBuild.Intermediate.source-build-externals
     From Version 9.0.0-alpha.1.24158.2 -> To Version 9.0.0-alpha.1.24161.3
    dotnet-maestro[bot] committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b75c4c1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f4a962 View commit details
    Browse the repository at this point in the history
  4. Use the project cone information in Scope.FindAssetsAsync

    This avoids full solution level searches in scenarios where a project cone is being searched. This was particularly bad when the AssetHint didn't indicate a project/document.
    ToddGrun committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    aa63897 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    95b7e38 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    efd7530 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4769457 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b26cf95 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7a83e99 View commit details
    Browse the repository at this point in the history
  10. undo

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    42752cf View commit details
    Browse the repository at this point in the history
  11. fix

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    643cd2f View commit details
    Browse the repository at this point in the history
  12. fix

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    931f784 View commit details
    Browse the repository at this point in the history
  13. Simplify

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    b10a170 View commit details
    Browse the repository at this point in the history
  14. Simplify

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    833777d View commit details
    Browse the repository at this point in the history
  15. Extract file

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    22521fc View commit details
    Browse the repository at this point in the history
  16. Add assert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    2f82a01 View commit details
    Browse the repository at this point in the history
  17. Apply PR feedback

    - Rename option to be `RazorSourceGenerator`
    - Cache results in analyzer provider, since result is fixed per roslyn instance
    - Remove duped names taken out of ProjectSystemProject
    maryamariyan committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5ac9b68 View commit details
    Browse the repository at this point in the history
  18. Add assert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    32904a7 View commit details
    Browse the repository at this point in the history
  19. Add assert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    79d4a49 View commit details
    Browse the repository at this point in the history
  20. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    9c8996b View commit details
    Browse the repository at this point in the history
  21. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    4174498 View commit details
    Browse the repository at this point in the history
  22. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    60810f3 View commit details
    Browse the repository at this point in the history
  23. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    615b6e9 View commit details
    Browse the repository at this point in the history
  24. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    0aa9398 View commit details
    Browse the repository at this point in the history
  25. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    7dc12fa View commit details
    Browse the repository at this point in the history
  26. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    15e75cf View commit details
    Browse the repository at this point in the history
  27. Revert

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    175874f View commit details
    Browse the repository at this point in the history
  28. Comment

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e63278f View commit details
    Browse the repository at this point in the history
  29. Simplify

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5bb7218 View commit details
    Browse the repository at this point in the history
  30. REmove

    CyrusNajmabadi committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    1a62751 View commit details
    Browse the repository at this point in the history
  31. Add a unit test to ensure object initialisers supports completion in …

    …collection expressions
    aldelaro5 committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    8e50612 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    85e0e2f View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    70b4083 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. in proc

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    42a391b View commit details
    Browse the repository at this point in the history
  2. in proc

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    4f55d54 View commit details
    Browse the repository at this point in the history
  3. in proc

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    3538ab6 View commit details
    Browse the repository at this point in the history
  4. in proc

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    afd29eb View commit details
    Browse the repository at this point in the history
  5. in progress

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    a739993 View commit details
    Browse the repository at this point in the history
  6. Make generic

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    762c01a View commit details
    Browse the repository at this point in the history
  7. Add tests

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d45336a View commit details
    Browse the repository at this point in the history
  8. Comment

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b8bd878 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    629715c View commit details
    Browse the repository at this point in the history
  10. Docs

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    405abde View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    f5038ee View commit details
    Browse the repository at this point in the history
  12. Store all indices

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    77871ac View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0871a35 View commit details
    Browse the repository at this point in the history
  14. Simplify base case

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2c3db16 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    ad878cc View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    98cd7d7 View commit details
    Browse the repository at this point in the history
  17. nrt

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    326db66 View commit details
    Browse the repository at this point in the history
  18. Use ProvideSettingsManifest to specify Unfied Settings registration f…

    …ile (dotnet#72429)
    
    * Update versions
    
    * Rename registration.json and add ProvideSettingsManifest
    
    * Add name
    
    * fix test
    
    * Fix name
    
    * Clean
    
    * Add an entry in pkgdef
    
    * Add comment
    
    * Change csproj
    
    * Fix source build
    
    * Remove blank line
    
    * Add comment
    
    * Fix typo
    Cosifne authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    900a62a View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    88bd6b2 View commit details
    Browse the repository at this point in the history
  20. Suppress Lock conversion warnings when using object equality operators (

    dotnet#72459)
    
    * Suppress Lock conversion warnings when using object equality operators
    
    * Use `AccumulatesDiagnostics` helper
    
    * Avoid resolving diagnostic code
    jjonescz authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    c40aa62 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    9be4c18 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    7537f71 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    2919928 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    32dfeb4 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    bb16de6 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    5c844f4 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    35abb42 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    72396c0 View commit details
    Browse the repository at this point in the history
  29. Update tests

    CyrusNajmabadi committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ac8e437 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    3704535 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    ad9182d View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    f057dc9 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    ed4c468 View commit details
    Browse the repository at this point in the history
  34. Address code review

    aldelaro5 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    48a38ef View commit details
    Browse the repository at this point in the history
  35. Fix formatting

    aldelaro5 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b19afd0 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    a093664 View commit details
    Browse the repository at this point in the history
  37. Fix formatting

    aldelaro5 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    10a82d0 View commit details
    Browse the repository at this point in the history
  38. Exclude VS-related packages on non-Windows (dotnet#72470)

    * Conditionalize setup packages to build only on Windows
    Set static graph restore to true on non-windows to align with windows scripting.
    
    * Fix EOL
    
    * Nothing hard is ever easy
    mmitche authored Mar 13, 2024
    Configuration menu
    Copy the full SHA
    f087922 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge pull request dotnet#72531 from dibarbet/lsp_server_debug

    Always log LSP server processId and increase attach timeout
    dibarbet authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    369fbe6 View commit details
    Browse the repository at this point in the history
  2. Remove ImmutableHashMap in favor of ImmutableDictionary (dotnet#72520)

    My understanding is that ImmutableHashMap precedes ImmutableDictionary and only exists because of that reason. These two data structures appear to have similar performance and functionality. There is no reason to have our own implementation if there isn't an advantage to doing so.
    ToddGrun authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c87268a View commit details
    Browse the repository at this point in the history
  3. Reduce allocations in SynchronizeAssetsAsync (dotnet#72533)

    This method was allocating an ImmutableArray<Checksum> each time it would request asset synchronization. Instead, we can use a pooled checksum array.
    ToddGrun authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    f520a73 View commit details
    Browse the repository at this point in the history
  4. Check PublishData.json feeds (dotnet#72333)

    * Update BuildBoss docs
    
    * Check PublishData.json
    jjonescz authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    26b809d View commit details
    Browse the repository at this point in the history
  5. Fix InvalidCastException when initializing the properties of an undec…

    …lared class inside a lambda function (dotnet#72480)
    
    Fixes dotnet#72456.
    
    Building the following snippet in a VB project breaks the compilation:
    ```vb
    Imports System
    Imports System.Linq.Expressions
    Module Program
        Public Function CreateExpression() As Expression(Of Func(Of Object))
            Return Function() (New UndeclaredClass() With {.Name = "testName"})
        End Function
    End Module
    ```
    
    There is a difference between `VisualBasic` and `CSharp` when getting diagnostics for the snippet above. The latter checks for the initializer type while the former forces a `DirectCast` which throws an `InvalidCastException`. This PR checks the type before forcing the cast similar to the `CSharp` approach.
    
    ### Expected result
    `Error BC30002: Type 'UndeclaredClass' is not defined.`
    ### Actual result
    Compilation breaks with the following trace:
    ```
    System.InvalidCastException
      HResult=0x80004002
      Message=Unable to cast object of type 'Microsoft.CodeAnalysis.VisualBasic.BoundLiteral' to type 'Microsoft.CodeAnalysis.VisualBasic.BoundAssignmentOperator'.
    
    This exception was originally thrown at this call stack:
    Microsoft.CodeAnalysis.VisualBasic.dll!Microsoft.CodeAnalysis.VisualBasic.DiagnosticsPass.VisitObjectInitializerExpression(Microsoft.CodeAnalysis.VisualBasic.BoundObjectInitializerExpression node) Line 126	Basic
    Microsoft.CodeAnalysis.VisualBasic.dll!Microsoft.CodeAnalysis.VisualBasic.BoundObjectInitializerExpression.Accept(Microsoft.CodeAnalysis.VisualBasic.BoundTreeVisitor visitor) Line 3792	Basic
    Microsoft.CodeAnalysis.VisualBasic.dll!Microsoft.CodeAnalysis.VisualBasic.BoundTreeWalkerWithStackGuard.VisitExpressionWithoutStackGuard(Microsoft.CodeAnalysis.VisualBasic.BoundExpression node) Line 61	Basic
    Microsoft.CodeAnalysis.VisualBasic.dll!Microsoft.CodeAnalysis.VisualBasic.BoundTreeVisitor.VisitExpressionWithStackGuard(Integer recursionDepth, Microsoft.CodeAnalysis.VisualBasic.BoundExpression node) Line 186	Basic
    Microsoft.CodeAnalysis.VisualBasic.dll!Microsoft.CodeAnalysis.VisualBasic.BoundTreeWalkerWithStackGuard.Visit(Microsoft.CodeAnalysis.VisualBasic.BoundNode node) Line 50	Basic
    Microsoft.CodeAnalysis.VisualBasic.dll!Microsoft.CodeAnalysis.VisualBasic.DiagnosticsPass.Visit(Microsoft.CodeAnalysis.VisualBasic.BoundNode node) Line 208	Basic
    ...
    ```
    andrei-ungureanu-uipath authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    224f1a3 View commit details
    Browse the repository at this point in the history
  6. Merge pull request dotnet#72495 from davidwengier/RazorSemanticTokens

    Expose semantic tokens functionality to Razor EA
    davidwengier authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    711e122 View commit details
    Browse the repository at this point in the history
  7. Add explicit package reference to System.Threading.Tasks.Dataflow

    in Microsoft.CodeAnalysis.InteractiveHost to ensure it's included for binding redirect
    genlu committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0862838 View commit details
    Browse the repository at this point in the history
  8. Add comment

    genlu committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3b5b0d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Fix tests

    CyrusNajmabadi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b77e470 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f42d5d View commit details
    Browse the repository at this point in the history
  3. Remove stale test

    CyrusNajmabadi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    616fc28 View commit details
    Browse the repository at this point in the history
  4. Merge pull request dotnet#72554 from genlu/fixBindingRedirect

    Add explicit package reference to System.Threading.Tasks.Dataflow
    genlu authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a67b2af View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9538771 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    299eb84 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    837af9e View commit details
    Browse the repository at this point in the history
  8. Update dependencies from https://github.com/dotnet/source-build-refer…

    …ence-packages build 20240311.2 (dotnet#72502)
    
    Microsoft.SourceBuild.Intermediate.source-build-reference-packages
     From Version 9.0.0-alpha.1.24155.1 -> To Version 9.0.0-alpha.1.24161.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    a615340 View commit details
    Browse the repository at this point in the history
  9. Update dependencies from https://github.com/dotnet/arcade build 20240…

    …311.1 (dotnet#72503)
    
    Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
     From Version 8.0.0-beta.24158.4 -> To Version 8.0.0-beta.24161.1
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    ff27b08 View commit details
    Browse the repository at this point in the history
  10. Fix failing tests

    maryamariyan committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    dea4c7f View commit details
    Browse the repository at this point in the history
  11. Fix the incorrect usage of color tokens in the RenameFlyout and Dispo…

    …sableToolTip. The change makes those controls use DynamicResources for the color tokens rather than using the VSColorTheme helper or directly querying the Application-level resource dictionary. The change also removes an invalid set of ImageThemingUtilities.ImageBackgroundColor. (dotnet#72538)
    Newrad0603 authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    b63b5c5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8d932e9 View commit details
    Browse the repository at this point in the history
  13. ExternalAccess.Xaml fixes

    - Replaced incompatible `CreateHoverResultAsync` with `CreateMarkdownContent`
    - Fixed XAML `DesciptionService` to show code examples in proper code blocks
    mgoertz-msft committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    2ab1ea9 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    70a21ef View commit details
    Browse the repository at this point in the history
  15. Remove import

    CyrusNajmabadi committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    351f72e View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    93fb581 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Merge pull request dotnet#72500 from dotnet/darc-main-80385c89-e800-4…

    …931-9cfa-445739138ec1
    
    [main] Update dependencies from dotnet/source-build-externals
    jjonescz authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2348a50 View commit details
    Browse the repository at this point in the history
  2. Reduce allocations in NodeExtensions.LogTables (dotnet#72536)

    The call to typeof(T).FullName is showing in speedometer allocation profiles as 0.8% of allocations during the session in the roslyn OOP. Although these allocations only occur when logging is on, it's still nice to get rid of them and improve our numbers and the experience of customers that have this logging on.
    ToddGrun authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    19f9e65 View commit details
    Browse the repository at this point in the history
  3. Merge pull request dotnet#72560 from mgoertz-msft/dev/mgoertz/ea-xaml

    ExternalAccess.Xaml fixes
    dibarbet authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b18dfa9 View commit details
    Browse the repository at this point in the history
  4. In progress

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9e216ac View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a9e7443 View commit details
    Browse the repository at this point in the history
  6. In progress

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bc43807 View commit details
    Browse the repository at this point in the history
  7. Almost done

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7f51760 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1eb6570 View commit details
    Browse the repository at this point in the history
  9. Fixes

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    21a9d0e View commit details
    Browse the repository at this point in the history
  10. Usings

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1467b86 View commit details
    Browse the repository at this point in the history
  11. Remove assert

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    244847f View commit details
    Browse the repository at this point in the history
  12. Tweak

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    a453e3e View commit details
    Browse the repository at this point in the history
  13. Merge pull request dotnet#72582 from dotnet/merges/release/dev17.9-to…

    …-release/dev17.10
    
    Merge release/dev17.9 to release/dev17.10
    dotnet-bot authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    caffb97 View commit details
    Browse the repository at this point in the history
  14. Lint

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f9e9b5b View commit details
    Browse the repository at this point in the history
  15. lint

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    383d897 View commit details
    Browse the repository at this point in the history
  16. Comment

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    41d9222 View commit details
    Browse the repository at this point in the history
  17. Remove unused method

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6bdcef6 View commit details
    Browse the repository at this point in the history
  18. Remove checks

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    9e71c1b View commit details
    Browse the repository at this point in the history
  19. Cleanup

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    cfb756d View commit details
    Browse the repository at this point in the history
  20. Detach later

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4657126 View commit details
    Browse the repository at this point in the history
  21. Error paths

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3668aa9 View commit details
    Browse the repository at this point in the history
  22. Rename

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6bf26cf View commit details
    Browse the repository at this point in the history
  23. Simplify

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1453e39 View commit details
    Browse the repository at this point in the history
  24. Make static

    CyrusNajmabadi committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c9f8dd9 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    765141d View commit details
    Browse the repository at this point in the history
  26. Merge pull request dotnet#72482 from maryamariyan/dev/maryamariyan/sg…

    …en-razor-vscode
    
    Allow VS Code to provide razor source geneator references.
    dibarbet authored Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7809895 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    134bc2e View commit details
    Browse the repository at this point in the history
  2. Fix

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c2c4be0 View commit details
    Browse the repository at this point in the history
  3. Add check

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    0383ef4 View commit details
    Browse the repository at this point in the history
  4. Fix

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    cd71e7f View commit details
    Browse the repository at this point in the history
  5. better thread transitions

    Cyrus Najmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    9c73cd2 View commit details
    Browse the repository at this point in the history
  6. disable diagnostics when solution crawler option is disabled

    Cyrus Najmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6777b43 View commit details
    Browse the repository at this point in the history
  7. disable diagnostics when solution crawler option is disabled

    Cyrus Najmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b691056 View commit details
    Browse the repository at this point in the history
  8. Reduce allocations in AbstractTypeMap (dotnet#72588)

    Partial fix for dotnet#68996
    
    Both SubstituteTypesWithoutModifiers and SubstituteNamedTypes allocate a temporary array that is used to potentially return an immutable array. Previously, this immutable array was allocated if needed, whereas we can not perform the extra allocation by utilizing ImmutableCollectionsMarshal as the array being wrapped is local to this method.
    ToddGrun authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4880891 View commit details
    Browse the repository at this point in the history
  9. Reduce File I/O under the AnalyzerAssemblyLoader folder (dotnet#72412)

    Assemblies and their corresponding resource dlls are copied/deleted under this folder on solution open. When opening Rosly, I see about 700 dlls copied/deleted under this folder. Over 90% of these dlls are resource dlls, not something in use for my setup.
    
    This change separates the code that ensures the assembly is shadow-copied properly from the code that ensures that it's supporting resource assemblies are shadow-copied properly. Resource assemblies as copied on assembly load demand.
    
    With this change locally, I see over 90% reduction in the number of these file I/O operations.
    ToddGrun authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    02069ce View commit details
    Browse the repository at this point in the history
  10. Merge pull request dotnet#72395 from sharwell/collection-utils

    Implement SegmentedCollectionsMarshal
    sharwell authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    b2a0a98 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    05f015c View commit details
    Browse the repository at this point in the history
  12. Update __arglist.md (dotnet#72523)

    Fix dead-link with Wayback Machine
    colejohnson66 authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6e4c3ce View commit details
    Browse the repository at this point in the history
  13. Update src/Analyzers/CSharp/Tests/UseCollectionExpression/UseCollecti…

    …onExpressionForArrayTests.cs
    
    Co-authored-by: Cyrus Najmabadi <[email protected]>
    Samuel Delarosbil and CyrusNajmabadi authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    1d019d5 View commit details
    Browse the repository at this point in the history
  14. in progress

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c77453d View commit details
    Browse the repository at this point in the history
  15. Fix potential exception in AssetProvider.SynchronizeAssetsAsync

    In a perf fix I made last week, I assumed _assetCache wouldn't change underneath me during execution of SynchronizeAssetsAsync. That assumption is not true.
    
    Now, if the asset cache changes such that the missingChecksums array is no longer sufficient to hold all missing checksums, then grow the array capacity such that it can hold additional entries that might now be missing.
    ToddGrun committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    140f02d View commit details
    Browse the repository at this point in the history
  16. Fix

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ea8d450 View commit details
    Browse the repository at this point in the history
  17. Merge pull request dotnet#72584 from CyrusNajmabadi/eventHookup

    Make event-hookup-completion async, and hook up to the background work indicator
    CyrusNajmabadi authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    991d1f2 View commit details
    Browse the repository at this point in the history
  18. Merge remote-tracking branch 'ToddGrun/FixExceptionIn_AssetProvider.S…

    …ynchronizeAssetsAsync' into assets
    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    98ee137 View commit details
    Browse the repository at this point in the history
  19. Be reseilient

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    04f679e View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    c74b503 View commit details
    Browse the repository at this point in the history
  21. Task type

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    980a7d3 View commit details
    Browse the repository at this point in the history
  22. use marshal

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7e0629a View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    84b8b50 View commit details
    Browse the repository at this point in the history
  24. tests

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    be360df View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    a77a730 View commit details
    Browse the repository at this point in the history
  26. Fix potential exception in AssetProvider.SynchronizeAssetsAsync (dotn…

    …et#72597)
    
    In a perf fix I made last week, I assumed _assetCache wouldn't change underneath me during execution of SynchronizeAssetsAsync. That assumption is not true.
    
    Now, if the asset cache changes such that the missingChecksums array is no longer sufficient to hold all missing checksums, then grow the array capacity such that it can hold additional entries that might now be missing.
    ToddGrun authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    98cd097 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    e72e626 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    f756df4 View commit details
    Browse the repository at this point in the history
  29. remove unused usings

    CyrusNajmabadi committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8dbdf7d View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    721e3c9 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    b2ea40f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Fix event hookup even when in a projection buffer

    Cyrus Najmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2c76467 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e5112ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    76f8770 View commit details
    Browse the repository at this point in the history
  4. Fix dotnet#69628 Analyzer summary should show suppressor ID (dotnet#7…

    …2569)
    
    * Show suppressor ids in analyser report
    
    * Reuse old test
    
    ---------
    
    Co-authored-by: Juan C. Diaz <[email protected]>
    juan-carlos-diaz and juan-diaz-at-nicklaus authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    20f2319 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    59ebc41 View commit details
    Browse the repository at this point in the history
  6. In progress

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    23b8170 View commit details
    Browse the repository at this point in the history
  7. Tweak

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e93e02a View commit details
    Browse the repository at this point in the history
  8. Lower batch size

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    563c543 View commit details
    Browse the repository at this point in the history
  9. Sort

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a5893b0 View commit details
    Browse the repository at this point in the history
  10. Add initial size

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b337107 View commit details
    Browse the repository at this point in the history
  11. Fix

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    b9d81ae View commit details
    Browse the repository at this point in the history
  12. Simplify

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    da8aa51 View commit details
    Browse the repository at this point in the history
  13. remove chunking

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ab3090d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f6a05ab View commit details
    Browse the repository at this point in the history
  15. rename

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    934f465 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    5228fd7 View commit details
    Browse the repository at this point in the history
  17. Clean

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a70d0ff View commit details
    Browse the repository at this point in the history
  18. Simplify

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    02905f2 View commit details
    Browse the repository at this point in the history
  19. Docs

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    c9ef99e View commit details
    Browse the repository at this point in the history
  20. Docs

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    1dfd632 View commit details
    Browse the repository at this point in the history
  21. Free

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    660af5d View commit details
    Browse the repository at this point in the history
  22. Simplify

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    519d839 View commit details
    Browse the repository at this point in the history
  23. Invert if

    CyrusNajmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8802727 View commit details
    Browse the repository at this point in the history
  24. Lint

    Cyrus Najmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    452661a View commit details
    Browse the repository at this point in the history
  25. fix

    Cyrus Najmabadi committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8bbc1b7 View commit details
    Browse the repository at this point in the history
  26. Merge pull request dotnet#72237 from dibarbet/clasp_source_package

    Convert Clasp into a source package
    dibarbet authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    bfa6269 View commit details
    Browse the repository at this point in the history
  27. Merge pull request dotnet#72603 from dibarbet/remove_workaround

    Remove workaround for .net7 r2r assembly loading issue
    dibarbet authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8f02ba0 View commit details
    Browse the repository at this point in the history
  28. Merge pull request dotnet#72605 from dibarbet/remove_win_ia32

    Drop win32-ia32 language server support
    dibarbet authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    2ac6ca2 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    ea65bdf View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    9c6f910 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    712873f View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    9aea13f View commit details
    Browse the repository at this point in the history
  33. Pass the temp path to DesktopStrongNameProvider ctor (dotnet#72587)

    This addresses feedback ticket: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1950505
    
    The underlying issue here is that the DesktopStrongNameProvider assumes it's caller will pass it a temp directory as EmitStream.CreateStream fails if the path isn't set. Jared indicated the compiler has a ban on calling Path.GetTempPath within their codebase, so it's on the caller to specify a value.
    ToddGrun authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    a66551a View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Small allocation optimization in StateTable.Builder.ToImmutable (dotn…

    …et#72364)
    
    Small performance optimization around in StateTable.Builder.ToImmutable to no longer allocate an array
    ToddGrun authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9baba7e View commit details
    Browse the repository at this point in the history
  2. Simpler on netcore

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    74b3512 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    65c67e0 View commit details
    Browse the repository at this point in the history
  4. Disable integration tests

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    51c08bd View commit details
    Browse the repository at this point in the history
  5. Merge branch 'disableTests' into embeddedPerf

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    82ccaf1 View commit details
    Browse the repository at this point in the history
  6. Merge branch 'disableTests' into docStates

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4627db9 View commit details
    Browse the repository at this point in the history
  7. use semaphore

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4413612 View commit details
    Browse the repository at this point in the history
  8. formaatting

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    cc749a0 View commit details
    Browse the repository at this point in the history
  9. skip

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    484b3bb View commit details
    Browse the repository at this point in the history
  10. remove

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e2c2cda View commit details
    Browse the repository at this point in the history
  11. Merge branch 'disableTests' into embeddedPerf

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e582be6 View commit details
    Browse the repository at this point in the history
  12. Merge branch 'disableTests' into docStates

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    5383093 View commit details
    Browse the repository at this point in the history
  13. Merge remote-tracking branch 'upstream/main' into docStates

    Cyrus Najmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    49a6f4a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    fb05d57 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c8dd474 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a9d970d View commit details
    Browse the repository at this point in the history
  17. Merge pull request dotnet#72352 from dotnet/merges/release/dev17.10-t…

    …o-main
    
    Merge release/dev17.10 to main
    dotnet-bot authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    fef7b5c View commit details
    Browse the repository at this point in the history
  18. [main] Update dependencies from dotnet/source-build-externals (dotnet…

    …#72612)
    
    [main] Update dependencies from dotnet/source-build-externals
    dotnet-maestro[bot] authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9bd2481 View commit details
    Browse the repository at this point in the history
  19. Merge pull request dotnet#72621 from CyrusNajmabadi/docStates

    Break added documents into batches when processing solution/compilation translation states.
    CyrusNajmabadi authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    c4f4202 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b050e48 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    b5b2653 View commit details
    Browse the repository at this point in the history
  22. Merge remote-tracking branch 'upstream/main' into support-primary-con…

    …structor-base-speculative
    CyrusNajmabadi committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    5dc6451 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    2f72b4d View commit details
    Browse the repository at this point in the history
  24. Merge pull request dotnet#72421 from sdelarosbil/support-primary-cons…

    …tructor-base-speculative
    CyrusNajmabadi authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    d2b48fe View commit details
    Browse the repository at this point in the history
  25. Merge pull request dotnet#72508 from sdelarosbil/no-equals-quotes-com…

    …pletion
    
    Do not put an equals and quotes when completing an xml attribute if present
    CyrusNajmabadi authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    460975c View commit details
    Browse the repository at this point in the history
  26. Replay Binary Log Tool (dotnet#72619)

    This adds a tool for replaying compilation events from binary logs directly to the compiler server. This is an effective tool for profiling the compiler server as it removes MSBuild overhead from the logs leaving just the compiler.
    
    Further because it's integrated into our code base it makes it very easy to evaluate the efficacy of performance fixes. One simply needs to run `replay` with and without the changes against the same binary log and evaluate the differences in perfview.
    jaredpar authored Mar 21, 2024
    Configuration menu
    Copy the full SHA
    35aea35 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    0e9dc88 View commit details
    Browse the repository at this point in the history