Rollup of 4 pull requests

[matthiaskrgr]

Successful merges:

• add some comments and some cleanup around Miri intptrcast #116650 (add some comments and some cleanup around Miri intptrcast)
• Only check in a single place if a pass is enabled. #116896 (Only check in a single place if a pass is enabled.)
• Use v0.0.0 in compiler crates #116906 (Use v0.0.0 in compiler crates)
• fix(bootstrap) info message show correct path now #116921 (fix(bootstrap) info message show correct path now)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=4

[bors]

📌 Commit e8544f8 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit e8544f8 with merge c104861...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing c104861 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#116650	add some comments and some cleanup around Miri intptrcast	e11bc2caa7b9c8e89177eb7e1beed4733381aa2d (link)
#116896	Only check in a single place if a pass is enabled.	2bd81ebd9699758df813dd91c6bafc878138b1d7 (link)
#116906	Use v0.0.0 in compiler crates	9a9479fe7aa663b6d1989671f999e291cd9b2bde (link)
#116921	fix(bootstrap) info message show correct path now	b0d69527dfffcfa81fa01d630cb02cede9e9e3c5 (link)

previous master: 3fbcfd2b6f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (c104861): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 1.2%]	18
Regressions ❌ (secondary)	1.0%	[0.7%, 1.2%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	0.7%	[0.2%, 1.2%]	18

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-2.7%, -2.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.089s -> 628.785s (0.11%)
Artifact size: 304.03 MiB -> 304.02 MiB (-0.00%)

[lqd]

I think this is all in mir transforms, likely the additional pass name calls and string finds in turn -- and since is all static data, maybe should be cached, and stored in a better-suited data structure.

@rust-timer build 2bd81eb

[rust-timer]

Finished benchmarking commit (2bd81eb): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.2%, 1.3%]	18
Regressions ❌ (secondary)	0.9%	[0.7%, 1.2%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.2%, 1.3%]	18

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.089s -> 630.269s (0.35%)
Artifact size: 304.03 MiB -> 304.03 MiB (0.00%)

[lqd]

Looking at the PR, this looks likely easy to mitigate if anyone following at home wants to take it -- but I'll cc #116896 author @cjgillot in any case.

[rylev]

@cjgillot any chance you'd be able to look into this?