Stash and cancel cycle errors for auto trait leakage in opaques #117241

compiler-errors · 2023-10-26T17:34:15Z

We don't need to emit a traditional cycle error when we have a selection error that explains what's going on but in more detail.

We may want to augment this error to actually point out the cycle, now that the cycle error is not being emitted. We could do that by storing the set of opaques that was in the CyclePlaceholder that gets returned from type_of_opaque.

r? @oli-obk cc @estebank #117235

compiler/rustc_macros/src/query.rs

compiler/rustc_query_impl/src/plumbing.rs

oli-obk · 2023-10-27T08:18:20Z

@bors r+ rollup

bors · 2023-10-27T08:18:21Z

📌 Commit 1836c1f has been approved by oli-obk

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#114998 (feat(docs): add cargo-pgo to PGO documentation 📝) - rust-lang#116868 (Tweak suggestion span for outer attr and point at item following invalid inner attr) - rust-lang#117240 (Fix documentation typo in std::iter::Iterator::collect_into) - rust-lang#117241 (Stash and cancel cycle errors for auto trait leakage in opaques) - rust-lang#117262 (Create a new ConstantKind variant (ZeroSized) for StableMIR) - rust-lang#117266 (replace transmute by raw pointer cast) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117241 - compiler-errors:auto-trait-leak-cycle, r=oli-obk Stash and cancel cycle errors for auto trait leakage in opaques We don't need to emit a traditional cycle error when we have a selection error that explains what's going on but in more detail. We may want to augment this error to actually point out the cycle, now that the cycle error is not being emitted. We could do that by storing the set of opaques that was in the `CyclePlaceholder` that gets returned from `type_of_opaque`. r? `@oli-obk` cc `@estebank` rust-lang#117235

rustbot assigned oli-obk Oct 26, 2023

compiler-errors commented Oct 26, 2023

View reviewed changes

compiler/rustc_macros/src/query.rs Outdated Show resolved Hide resolved

compiler-errors commented Oct 26, 2023

View reviewed changes

compiler/rustc_query_impl/src/plumbing.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Stash and cancel cycle errors for auto trait leakage in opaques

1836c1f

rust-cloud-vms bot force-pushed the auto-trait-leak-cycle branch from 2ddd0fe to 1836c1f Compare October 26, 2023 17:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2023

matthiaskrgr mentioned this pull request Oct 27, 2023

Rollup of 6 pull requests #117272

Merged

bors merged commit 5459333 into rust-lang:master Oct 27, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 27, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stash and cancel cycle errors for auto trait leakage in opaques #117241

Stash and cancel cycle errors for auto trait leakage in opaques #117241

compiler-errors commented Oct 26, 2023

This comment has been minimized.

oli-obk commented Oct 27, 2023

bors commented Oct 27, 2023

Stash and cancel cycle errors for auto trait leakage in opaques #117241

Stash and cancel cycle errors for auto trait leakage in opaques #117241

Conversation

compiler-errors commented Oct 26, 2023

This comment has been minimized.

oli-obk commented Oct 27, 2023

bors commented Oct 27, 2023