Stabilize inline asm usage with rustc_codegen_cranelift #117365

bjorn3 · 2023-10-29T20:36:33Z

Previously using inline asm with the cg_clif version built as part of rustc would return an error that inline asm support is unstable. Recently I implemented everything that remained for full support of inline asm with the exception of sym operands (which remain marked as unstable for cg_clif). As such I think it is time to declare the inline asm support of cg_clif stable.

@rustbot label +A-codegen +A-cranelift +T-compiler

…clif-2023-10-24

…t-codegen This ensures that cg_clif can be built for targets that aren't natively supported by Cranelift. It will not be possible to compile for the host in this case, but cross-compilation will still be possible. We won't distribute cg_clif as rustup component for any targets that aren't natively supported by Cranelift, but will still build it if codegen-backends lists "cranelift".

This adds support for loongarch and a bunch of other targets

…ilee Bump stdarch submodule and remove special handling for LLVM intrinsics that are no longer needed Bumps stdarch to pull rust-lang/stdarch#1477, which reimplemented some functions with portable SIMD intrinsics instead of arch specific LLVM intrinsics. Handling of those LLVM intrinsics is removed from cranelift codegen and miri. cc `@RalfJung` `@bjorn3`

…rk-Simulacrum Distribute cg_clif as rustup component on the nightly channel This makes it possible to use cg_clif using: ```bash $ rustup component add rustc-codegen-cranelift-preview --toolchain nightly $ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build ``` cc rust-lang/compiler-team#405. r? `@Mark-Simulacrum`

The LLVM backend is generally available, while the gnu assembler is not on Windows and many other platforms by default.

But exclude sym operands for now as they are somewhat broken.

…assembler Support and stabilize inline asm on all platforms

…clif-2023-10-29

rustbot · 2023-10-29T20:36:41Z

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

bjorn3 · 2023-10-29T20:36:45Z

See rust-lang/rustc_codegen_cranelift#1204

TaKO8Ki · 2023-10-30T08:08:21Z

It's better to reroll. @bors r? compiler

oli-obk · 2023-10-30T09:15:49Z

@bors r+

bors · 2023-10-30T09:15:51Z

📌 Commit a9b21bb has been approved by oli-obk

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#117147 (Print variadic argument pattern in HIR pretty printer) - rust-lang#117177 (Use ImageDataType for allocation type) - rust-lang#117205 (Allows `#[diagnostic::on_unimplemented]` attributes to have multiple) - rust-lang#117350 (coverage: Replace manual debug indents with nested tracing spans in `counters`) - rust-lang#117365 (Stabilize inline asm usage with rustc_codegen_cranelift) - rust-lang#117371 (Ignore RPIT duplicated lifetimes in `opaque_types_defined_by`) - rust-lang#117382 (Fail typeck for illegal break-with-value) - rust-lang#117385 (deduce_param_attrs: explain a read-only case) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117365 - bjorn3:sync_cg_clif-2023-10-29, r=oli-obk Stabilize inline asm usage with rustc_codegen_cranelift Previously using inline asm with the cg_clif version built as part of rustc would return an error that inline asm support is unstable. Recently I implemented everything that remained for full support of inline asm with the exception of sym operands (which remain marked as unstable for cg_clif). As such I think it is time to declare the inline asm support of cg_clif stable. `@rustbot` label +A-codegen +A-cranelift +T-compiler

eduardosm and others added 15 commits October 12, 2023 11:20

Remove from cranelift codegen LLVM intrinsics that are no longer needed

40cc891

Merge commit '93a5433f17ab5ed48cc88f1e69b0713b16183373' into sync_cg_…

a302610

…clif-2023-10-24

Merge branch 'sync_from_rust'

6d30a7d

Update target-lexicon to 0.12.12

1cb7bdb

This adds support for loongarch and a bunch of other targets

Use the LLVM rustc backend as external assembler

827a6d8

The LLVM backend is generally available, while the gnu assembler is not on Windows and many other platforms by default.

Unconditionally handle int $$0x29 using a shim

b1e7051

Stabilize inline asm usage on all platforms

35453ac

But exclude sym operands for now as they are somewhat broken.

Avoid infinite recursion when cranelift is the default codegen backend

69c6aa5

Merge pull request rust-lang#1403 from rust-lang/use_llvm_backend_as_…

9436eae

…assembler Support and stabilize inline asm on all platforms

Sync from rust e5cfc55

e281e6f

Rustup to rustc 1.75.0-nightly (e5cfc55 2023-10-28)

dde5880

Merge commit 'dde58803fd6cbb270c7a437f36a8a3a29fbef679' into sync_cg_…

a9b21bb

…clif-2023-10-29

rustbot assigned TaKO8Ki Oct 29, 2023

bjorn3 removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Oct 29, 2023

rustbot assigned cjgillot and unassigned TaKO8Ki Oct 30, 2023

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 30, 2023

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 30, 2023

fmease mentioned this pull request Oct 30, 2023

Rollup of 8 pull requests #117387

Merged

bors merged commit fd5ffab into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

bjorn3 deleted the sync_cg_clif-2023-10-29 branch October 30, 2023 13:12

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize inline asm usage with rustc_codegen_cranelift #117365

Stabilize inline asm usage with rustc_codegen_cranelift #117365

bjorn3 commented Oct 29, 2023

rustbot commented Oct 29, 2023

bjorn3 commented Oct 29, 2023

TaKO8Ki commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023

Stabilize inline asm usage with rustc_codegen_cranelift #117365

Stabilize inline asm usage with rustc_codegen_cranelift #117365

Conversation

bjorn3 commented Oct 29, 2023

rustbot commented Oct 29, 2023

bjorn3 commented Oct 29, 2023

TaKO8Ki commented Oct 30, 2023

oli-obk commented Oct 30, 2023

bors commented Oct 30, 2023