Rollup of 8 pull requests #117387

fmease · 2023-10-30T09:48:21Z

Successful merges:

Print variadic argument pattern in HIR pretty printer #117147 (Print variadic argument pattern in HIR pretty printer)
Use ImageDataType for allocation type #117177 (Use ImageDataType for allocation type)
Allows #[diagnostic::on_unimplemented] attributes to have multiple #117205 (Allows #[diagnostic::on_unimplemented] attributes to have multiple)
coverage: Replace manual debug indents with nested tracing spans in counters #117350 (coverage: Replace manual debug indents with nested tracing spans in counters)
Stabilize inline asm usage with rustc_codegen_cranelift #117365 (Stabilize inline asm usage with rustc_codegen_cranelift)
Ignore RPIT duplicated lifetimes in opaque_types_defined_by #117371 (Ignore RPIT duplicated lifetimes in opaque_types_defined_by)
Fail typeck for illegal break-with-value #117382 (Fail typeck for illegal break-with-value)
deduce_param_attrs: explain a read-only case #117385 (deduce_param_attrs: explain a read-only case)

r? @ghost
@rustbot modify labels: rollup

…clif-2023-10-24

notes This commit extends the `#[diagnostic::on_unimplemented]` (and `#[rustc_on_unimplemented]`) attributes to allow multiple `note` options. This enables emitting multiple notes for custom error messages. For now I've opted to not change any of the existing usages of `#[rustc_on_unimplemented]` and just updated the relevant compile tests.

…t-codegen This ensures that cg_clif can be built for targets that aren't natively supported by Cranelift. It will not be possible to compile for the host in this case, but cross-compilation will still be possible. We won't distribute cg_clif as rustup component for any targets that aren't natively supported by Cranelift, but will still build it if codegen-backends lists "cranelift".

This adds support for loongarch and a bunch of other targets

…ilee Bump stdarch submodule and remove special handling for LLVM intrinsics that are no longer needed Bumps stdarch to pull rust-lang/stdarch#1477, which reimplemented some functions with portable SIMD intrinsics instead of arch specific LLVM intrinsics. Handling of those LLVM intrinsics is removed from cranelift codegen and miri. cc `@RalfJung` `@bjorn3`

…rk-Simulacrum Distribute cg_clif as rustup component on the nightly channel This makes it possible to use cg_clif using: ```bash $ rustup component add rustc-codegen-cranelift-preview --toolchain nightly $ RUSTFLAGS="-Zcodegen-backend=cranelift" cargo +nightly build ``` cc rust-lang/compiler-team#405. r? `@Mark-Simulacrum`

The LLVM backend is generally available, while the gnu assembler is not on Windows and many other platforms by default.

But exclude sym operands for now as they are somewhat broken.

…assembler Support and stabilize inline asm on all platforms

…clif-2023-10-29

Now that we don't manually pass around indent levels, there's no need for these worker methods to exist separately from their main callers.

Signed-off-by: Ayush Singh <[email protected]>

This is fixes the issue wherein typeck was succeeding for break-with-value at illegal locations such as inside `while`, `while let` and `for` loops which eventually caused an ICE during MIR interpetation for const eval. Now we fail typeck for such code which prevents faulty MIR from being generated and interpreted, thus fixing the ICE.

…piler-errors Print variadic argument pattern in HIR pretty printer Variadic argument name/pattern was ignored during HIR pretty printing. Could not figure out why it only works on normal functions (`va2`) and not in foreign ones (`va1`).

…ngjubilee Use ImageDataType for allocation type Suggested at rust-lang#100499 cc `@dvdhrm` cc `@nicholasbishop`

…mplemented, r=compiler-errors Allows `#[diagnostic::on_unimplemented]` attributes to have multiple notes This commit extends the `#[diagnostic::on_unimplemented]` (and `#[rustc_on_unimplemented]`) attributes to allow multiple `note` options. This enables emitting multiple notes for custom error messages. For now I've opted to not change any of the existing usages of `#[rustc_on_unimplemented]` and just updated the relevant compile tests. r? `@compiler-errors` I'm happy to adjust any of the existing changed location to emit the old error message if that's desired.

coverage: Replace manual debug indents with nested tracing spans in `counters` Instead of indenting these debug messages manually, we can get `#[instrument]` to do a better job of it for us, giving us some nice little simplifications.

…oli-obk Stabilize inline asm usage with rustc_codegen_cranelift Previously using inline asm with the cg_clif version built as part of rustc would return an error that inline asm support is unstable. Recently I implemented everything that remained for full support of inline asm with the exception of sym operands (which remain marked as unstable for cg_clif). As such I think it is time to declare the inline asm support of cg_clif stable. `@rustbot` label +A-codegen +A-cranelift +T-compiler

…li-obk Ignore RPIT duplicated lifetimes in `opaque_types_defined_by` An RPIT's or TAIT's own generics are kinda useless -- so just ignore them. For TAITs, they will always be empty, and for RPITs, they're always duplicated lifetimes. Fixes rust-lang#115013.

…-obk Fail typeck for illegal break-with-value This is fixes the issue wherein typeck was succeeding for break-with-value exprs at illegal locations such as inside `while`, `while let` and `for` loops which eventually caused an ICE during MIR interpretation for const eval. Now we fail typeck for such code which prevents faulty MIR from being generated and interpreted, thus fixing the ICE. Fixes rust-lang#114529

…-obk deduce_param_attrs: explain a read-only case This takes the discussion [here](https://github.com/rust-lang/rust/pull/111517/files#r1243443625) and adds it as comment in the code. Cc `@lukas-code`

fmease · 2023-10-30T09:48:46Z

@bors r+ rollup=never p=8

bors · 2023-10-30T09:48:48Z

📌 Commit 288ab16 has been approved by fmease

It is now in the queue for this repository.

bors · 2023-10-30T10:59:26Z

⌛ Testing commit 288ab16 with merge e324cf0...

bors · 2023-10-30T13:12:00Z

☀️ Test successful - checks-actions
Approved by: fmease
Pushing e324cf0 to master...

rust-timer · 2023-10-30T13:14:15Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#117147	Print variadic argument pattern in HIR pretty printer	`9b6958417e58a57bfcddeaaf1b75dd8b135a8a93` (link)
#117177	Use ImageDataType for allocation type	`26e6cf7f2a04284aa67e4029b8848339f513c91e` (link)
#117205	Allows `#[diagnostic::on_unimplemented]` attributes to have…	`9627a3f16614746ef8b4e275b7dda9218d2aa898` (link)
#117350	coverage: Replace manual debug indents with nested tracing …	`d2e82e85dfb6c3d48ec11a0104c9f4644ca91529` (link)
#117365	Stabilize inline asm usage with rustc_codegen_cranelift	`5ceda2013a33e7552a493235721dd271c02b034f` (link)
#117371	Ignore RPIT duplicated lifetimes in `opaque_types_defined_b…	`b7e760afdf45b71d5aee32f6d1b9db8661d403d8` (link)
#117382	Fail typeck for illegal break-with-value	`b708b79ebeccba1de72c535f37f9f20e3c9e9e91` (link)
#117385	deduce_param_attrs: explain a read-only case	`8f7b6e0a773dfa9de45e6d341840bf9ca1cf4c99` (link)

previous master: 91bbdd927a

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-10-30T14:59:52Z

Finished benchmarking commit (e324cf0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[1.8%, 1.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	1.8%	[1.8%, 1.8%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 634.756s -> 637.739s (0.47%)
Artifact size: 304.45 MiB -> 304.42 MiB (-0.01%)

eduardosm and others added 30 commits October 12, 2023 11:20

Remove from cranelift codegen LLVM intrinsics that are no longer needed

40cc891

Merge commit '93a5433f17ab5ed48cc88f1e69b0713b16183373' into sync_cg_…

a302610

…clif-2023-10-24

Merge branch 'sync_from_rust'

6d30a7d

Print variadic argument pattern in HIR pretty printer

2c1dbed

Remove unnecessary CVarArgs name skipping logic

6aead74

Update target-lexicon to 0.12.12

1cb7bdb

This adds support for loongarch and a bunch of other targets

Use the LLVM rustc backend as external assembler

827a6d8

The LLVM backend is generally available, while the gnu assembler is not on Windows and many other platforms by default.

Unconditionally handle int $$0x29 using a shim

b1e7051

Stabilize inline asm usage on all platforms

35453ac

But exclude sym operands for now as they are somewhat broken.

Avoid infinite recursion when cranelift is the default codegen backend

69c6aa5

Merge pull request rust-lang#1403 from rust-lang/use_llvm_backend_as_…

9436eae

…assembler Support and stabilize inline asm on all platforms

Sync from rust e5cfc55

e281e6f

Rustup to rustc 1.75.0-nightly (e5cfc55 2023-10-28)

dde5880

Merge commit 'dde58803fd6cbb270c7a437f36a8a3a29fbef679' into sync_cg_…

a9b21bb

…clif-2023-10-29

Ignore RPIT duplicated lifetimes in opaque_types_defined_by

c561325

coverage: Replace manual debug indents with nested tracing spans

6d69eb1

coverage: Inline the "recursive" worker methods for assigning counters

2f1be08

Now that we don't manually pass around indent levels, there's no need for these worker methods to exist separately from their main callers.

coverage: Use a tracing span to group the parts of a sum-up expression

10c4734

Use ImageDataType for allocation type

441068b

Signed-off-by: Ayush Singh <[email protected]>

deduce_param_attrs: explain a read-only case

3f7e506

Rollup merge of rust-lang#117177 - Ayush1325:uefi-alloc-type, r=worki…

098bb37

…ngjubilee Use ImageDataType for allocation type Suggested at rust-lang#100499 cc `@dvdhrm` cc `@nicholasbishop`

fmease added 3 commits October 30, 2023 10:48

Rollup merge of rust-lang#117385 - RalfJung:deduce_param_attrs, r=oli…

288ab16

…-obk deduce_param_attrs: explain a read-only case This takes the discussion [here](https://github.com/rust-lang/rust/pull/111517/files#r1243443625) and adds it as comment in the code. Cc `@lukas-code`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2023

bors merged commit e324cf0 into rust-lang:master Oct 30, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 30, 2023

fmease deleted the rollup-5958nsf branch October 30, 2023 13:36

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

matthiaskrgr mentioned this pull request Nov 11, 2023

ICE: no type for local variable #117821

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #117387

Rollup of 8 pull requests #117387

fmease commented Oct 30, 2023

fmease commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

rust-timer commented Oct 30, 2023

rust-timer commented Oct 30, 2023

Rollup of 8 pull requests #117387

Rollup of 8 pull requests #117387

Conversation

fmease commented Oct 30, 2023

fmease commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

bors commented Oct 30, 2023

rust-timer commented Oct 30, 2023

rust-timer commented Oct 30, 2023

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size