Merge `impl_wf_inference` (`check_mod_impl_wf`) check into coherence checking #117133

compiler-errors · 2023-10-24T17:03:38Z

Problem here is that we call collect_impl_trait_in_trait_types when checking check_mod_impl_wf which is performed before coherence. Due to the tcx.sess.track_errors, since we end up reporting an error, we never actually proceed to coherence checking, where we would be emitting a more useful impl overlap error.

This change means that we may report more errors in some cases, but can at least proceed far enough to leave a useful message for overlapping traits with RPITITs in them.

Fixes #116982

r? types

oli-obk · 2023-10-25T14:37:22Z

@bors r+ rollup

bors · 2023-10-25T14:37:24Z

📌 Commit a947654 has been approved by oli-obk

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#116801 (Add test for 113326) - rust-lang#117133 (Merge `impl_wf_inference` (`check_mod_impl_wf`) check into coherence checking) - rust-lang#117136 (Intern `LocalDefId` list from `opaque_types_defined_by` query) - rust-lang#117150 (Update cargo) - rust-lang#117158 (Update THIR unused_unsafe lint) - rust-lang#117160 (Fix typo in test comment) - rust-lang#117168 (Fix some coroutine sentences that don't make sense anymore.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117133 - compiler-errors:coherence-constrained, r=oli-obk Merge `impl_wf_inference` (`check_mod_impl_wf`) check into coherence checking Problem here is that we call `collect_impl_trait_in_trait_types` when checking `check_mod_impl_wf` which is performed before coherence. Due to the `tcx.sess.track_errors`, since we end up reporting an error, we never actually proceed to coherence checking, where we would be emitting a more useful impl overlap error. This change means that we may report more errors in some cases, but can at least proceed far enough to leave a useful message for overlapping traits with RPITITs in them. Fixes rust-lang#116982 r? types

Merge impl_wf_inference into coherence checking

a947654

rustbot assigned oli-obk Oct 24, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2023

compiler-errors changed the title ~~Merge impl_wf_inference into coherence checking~~ Merge impl_wf_inference (check_mod_impl_wf) check into coherence checking Oct 24, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2023

matthiaskrgr mentioned this pull request Oct 25, 2023

Rollup of 7 pull requests #117172

Merged

bors merged commit 96074be into rust-lang:master Oct 25, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 25, 2023

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge `impl_wf_inference` (`check_mod_impl_wf`) check into coherence checking #117133

Merge `impl_wf_inference` (`check_mod_impl_wf`) check into coherence checking #117133

compiler-errors commented Oct 24, 2023 •

edited

Loading

oli-obk commented Oct 25, 2023

bors commented Oct 25, 2023

Merge impl_wf_inference (check_mod_impl_wf) check into coherence checking #117133

Merge impl_wf_inference (check_mod_impl_wf) check into coherence checking #117133

Conversation

compiler-errors commented Oct 24, 2023 • edited Loading

oli-obk commented Oct 25, 2023

bors commented Oct 25, 2023

Merge `impl_wf_inference` (`check_mod_impl_wf`) check into coherence checking #117133

Merge `impl_wf_inference` (`check_mod_impl_wf`) check into coherence checking #117133

compiler-errors commented Oct 24, 2023 •

edited

Loading