Improve `stringify.rs` test #117114

nnethercote · 2023-10-24T05:08:09Z

Best reviewed one commit at a time.

Currently it only tests AST pretty-printing. This commit changes it to run every example through both AST pretty-printing and TokenStream pretty-printing. This makes it clear where there two pretty-printing approaches produce different results.

By adding tests (or placeholders, or comments) for missing AST variants.

By making some case more complex, adding some new cases, tweaking formatting, and removing unnecessary `rustfmt` attributes.

petrochenkov · 2023-10-26T18:21:32Z

@bors r+

bors · 2023-10-26T18:21:35Z

📌 Commit c1800fb has been approved by petrochenkov

It is now in the queue for this repository.

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#116968 (Invalid `?` suggestion on mismatched `Ok(T)`) - rust-lang#117032 (Enable cg_clif tests for riscv64gc) - rust-lang#117106 (When expecting closure argument but finding block provide suggestion) - rust-lang#117114 (Improve `stringify.rs` test) - rust-lang#117188 (Avoid repeated interning of `env!("CFG_RELEASE")`) - rust-lang#117243 (Explain implementation of mem::replace) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#117114 - nnethercote:improve-stringify-test, r=petrochenkov Improve `stringify.rs` test Best reviewed one commit at a time. r? `@petrochenkov`

nnethercote added 3 commits October 24, 2023 15:56

Redo stringify.rs test.

f0a2635

Currently it only tests AST pretty-printing. This commit changes it to run every example through both AST pretty-printing and TokenStream pretty-printing. This makes it clear where there two pretty-printing approaches produce different results.

Augment stringify.rs test.

2e2e780

By adding tests (or placeholders, or comments) for missing AST variants.

Augment stringify.rs test some more.

c1800fb

By making some case more complex, adding some new cases, tweaking formatting, and removing unnecessary `rustfmt` attributes.

rustbot assigned petrochenkov Oct 24, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2023

matthiaskrgr mentioned this pull request Oct 26, 2023

Rollup of 6 pull requests #117249

Merged

bors merged commit a8f7acd into rust-lang:master Oct 27, 2023
11 checks passed

rustbot added this to the 1.75.0 milestone Oct 27, 2023

nnethercote deleted the improve-stringify-test branch October 27, 2023 03:47

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve `stringify.rs` test #117114

Improve `stringify.rs` test #117114

nnethercote commented Oct 24, 2023

petrochenkov commented Oct 26, 2023

bors commented Oct 26, 2023

Improve stringify.rs test #117114

Improve stringify.rs test #117114

Conversation

nnethercote commented Oct 24, 2023

petrochenkov commented Oct 26, 2023

bors commented Oct 26, 2023

Improve `stringify.rs` test #117114

Improve `stringify.rs` test #117114